This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inject_styles
can be emitted as achunk
instead of anasset
since it's a.js
file. This allows it to be minified, which makes a better use of bandwidth. It also makes it have a hash in it's name, which is important for avoiding caching bugs. URLs under the/client
path are cached. I potentially wanted to change the contents ofinject_styles
while coming up with a fix for #1505 (e.g. as in #1525), but that wouldn't work if the file is cached because users would get the old version of the fileAlso, I think it would be nice to have
inject_styles
be processed by Babel. This seems like it would be necessary for that to happen. However, from my testing, it does not appear sufficient