Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ts preprocessor to consider store suffixed with number #461

Merged
merged 1 commit into from Jan 12, 2022
Merged

fix: ts preprocessor to consider store suffixed with number #461

merged 1 commit into from Jan 12, 2022

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Jan 12, 2022 •
edited

Fixes sveltejs/svelte#7120

the original regex had +-=, which forgot to escape -, resulting ignoring any characters between + to =

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

kaisermann
kaisermann approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@kaisermann kaisermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks 🙏

@dummdidumm dummdidumm merged commit a7a94cf into sveltejs:main Jan 12, 2022
@kaisermann
Copy link
Member

Released in v4.10.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangxxh sangxxh sangxxh approved these changes

@kaisermann kaisermann kaisermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store variable name containing number throws undefined error
4 participants
@tanhauhau @kaisermann @sangxxh @dummdidumm