Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile errors when typechecking svelte.config.js with moduleResolution set to nodenext #591

Open
DetachHead opened this issue Apr 14, 2023 · 3 comments

Comments

@DetachHead
Copy link

Describe the bug
when typechecking svelte.config.js with moduleResolution set to nodenext, the following compile errors occur:

node_modules/svelte-preprocess/dist/types/index.d.ts:2:106 - error TS2307: Cannot find module 'svelte/types/compiler/preprocess' or its corresponding type declarations.

2 import type { Processed as SvelteProcessed, Preprocessor as SveltePreprocessor, PreprocessorGroup } from 'svelte/types/compiler/preprocess';
                                                                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/svelte-preprocess/dist/types/index.d.ts:4:35 - error TS2307: Cannot find module 'svelte/types/compiler/preprocess' or its corresponding type declarations.

4 export { PreprocessorGroup } from 'svelte/types/compiler/preprocess';
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svelte.config.js:12:14 - error TS2349: This expression is not callable.
  Type 'typeof import("/home/projects/sveltejs-kit-template-default-b9wpnr/node_modules/svelte-preprocess/dist/index")' has no call signatures.

12  preprocess: preprocess()
                ~~~~~~~~~~

Logs
Please include browser console and server logs around the time this bug occurred.

To Reproduce

  1. go to https://stackblitz.com/edit/sveltejs-kit-template-default-b9wpnr?file=svelte.config.js
  2. wait for the dev npm script to finish
  3. check the output

Expected behavior
A clear and concise description of what you expected to happen.

Information about your project:

  • svelte-preprocess version: 5.0.3

Additional context

other related issues:

@DetachHead
Copy link
Author

DetachHead commented Sep 11, 2023

minimized comment, off topic

this also causes two even more severe issues:

compile errors when trying to import another svelte component

<script lang='ts'>
    import Foo from './Foo.svelte' // svelte file that exists
</script>

<Foo/>
> svelte-kit sync && svelte-check --tsconfig ./tsconfig.json


====================================
Loading svelte-check in workspace: c:\Users\user\Documents\my-app2
Getting Svelte diagnostics...

c:\Users\user\Documents\my-app2\src\routes\+page.svelte:5:1
Warn: 'Foo' is not defined (svelte)

<Foo/>

====================================
svelte-check found 0 errors and 1 warning in 1 file

also why is an undefined variable only a warning instead of an error?

runtime crash

attempting to run my app with moduleResolution set to NodeNext causes this error:

ReferenceError: exports is not defined
    at eval (C:/Users/user/Documents/my-app2/src/routes/+page.svelte:14:24)
    at Object.$$render (C:/Users/user/Documents/my-app2/node_modules/svelte/src/runtime/internal/ssr.js:174:16)
    at Object.default (C:/Users/user/Documents/my-app2/.svelte-kit/generated/root.svelte:74:138)
    at eval (C:/Users/user/Documents/my-app2/node_modules/@sveltejs/kit/src/runtime/components/layout.svelte:8:41)
    at Object.$$render (C:/Users/user/Documents/my-app2/node_modules/svelte/src/runtime/internal/ssr.js:174:16)
    at eval (C:/Users/user/Documents/my-app2/.svelte-kit/generated/root.svelte:63:129)
    at $$render (C:/Users/user/Documents/my-app2/node_modules/svelte/src/runtime/internal/ssr.js:174:16)
    at Object.render (C:/Users/user/Documents/my-app2/node_modules/svelte/src/runtime/internal/ssr.js:182:17)
    at Module.render_response (C:/Users/user/Documents/my-app2/node_modules/@sveltejs/kit/src/runtime/server/page/render.js:185:29)
    at async Module.render_page (C:/Users/user/Documents/my-app2/node_modules/@sveltejs/kit/src/runtime/server/page/index.js:295:10)

@dummdidumm
Copy link
Member

Could you provide a reproduction for this? This sounds a bit unrelated - moduleResolution shouldn't have impact on how things are resolved at runtime, unless Vite is doing something funky there.

@DetachHead
Copy link
Author

yeah i can't reproduce that anymore updating to typescript 5, must've been the same issue as #612

however the issue in the OP still occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants