chore: simplify effects further #11570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trueadm
approved these changes
May 12, 2024
Rich-Harris
added a commit
that referenced
this pull request
May 12, 2024
* optimise effects * tweak * don't allocate array unnecessarily * filter_flags appears to be unnecessary? * lint * tweak * simplify (#11570) * changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #11569. Per #11569 (comment), it appears that
flush_local_render_effectsis unnecessary (at the very least, I can't figure out a test that fails if we remove it). It's possible that it was made redundant by the unification of render effects and pre effects, or by the fact that we now process effects in tree order.If we remove that, we can simplify some code and remove a bunch of indirection.