Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive variable no longer reacting in 3.56.0 #8374

Closed
gwww opened this issue Mar 12, 2023 · 3 comments · Fixed by #8382
Closed

Reactive variable no longer reacting in 3.56.0 #8374

gwww opened this issue Mar 12, 2023 · 3 comments · Fixed by #8382

Comments

@gwww
Copy link

gwww commented Mar 12, 2023

Describe the bug

I have code similar to what is in the REPL below. When I upgraded to 3.56.0 my code broke. The REPL is the simplest I could think of to show the problem.

I can make the REPL work in both Svelte versions by changing line 3 in the REPL to let name = 'Not defined';. This is a suitable workaround for my code.

Reproduction

https://svelte.dev/repl/ceb487d75cfa4a6d880a0193fa4fc859?version=3.55.1 - works

https://svelte.dev/repl/ceb487d75cfa4a6d880a0193fa4fc859?version=3.56.0 - same REPL just Svelte version change, does not work

Logs

No response

System Info

System:
    OS: macOS 13.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 1.96 GB / 32.00 GB
    Shell: 5.9 - /opt/homebrew/bin/zsh
  Binaries:
    Node: 19.7.0 - ~/.local/share/rtx/installs/nodejs/19.7.0/bin/node
    npm: 9.5.0 - ~/.local/share/rtx/installs/nodejs/19.7.0/bin/npm
  Browsers:
    Chrome: 110.0.5481.177
    Firefox: 110.0
    Safari: 16.2
  npmPackages:
    svelte: ^3.56.0 => 3.56.0

Severity

annoyance

@csjh
Copy link

csjh commented Mar 12, 2023

Seems to be a result of #7942, specifically is_reactive_static being too broadly applied(?).

jgerigmeyer added a commit to oddbird/oddcontrast that referenced this issue Mar 13, 2023
dummdidumm added a commit to dummdidumm/svelte that referenced this issue Mar 14, 2023
KaiMagnusMueller added a commit to KaiMagnusMueller/Tree-Navigator that referenced this issue Mar 14, 2023
- Fix unreactive variable, (bug sveltejs/svelte#8374, but it wasn't necessary anyways)
- Switched all onmessage event to more robust window.addEventListener('message')
- Add key events to SuggestionItems
KaiMagnusMueller added a commit to KaiMagnusMueller/Tree-Navigator that referenced this issue Mar 14, 2023
* Update UI strings, fix hidden layers error

- Update UI strings for layer tree
- Fix selection of hidden layers causing an error toast (because figma.skipInvisibleInstanceChildren = true), maybe consider adding a setting toggle for this

* Add tutorials

- Add tutorials
- Hide viewed tutorials
- Reset viewed tutorials
- Fix bug that could cause a undefined selection

* Add dark mode for tutorial card

* Add second tutorial

* Add tutorial navigation

- Add tutorial navigation
- Update Svelte 3.49 -> 3.56

* Add tutorial nav styling, fix card backgrounds

* Card CSS improvements

- Fix card shadow getting cut off
- Remove pointer events from image
- Improve 2nd card gradient start color
- Add fade transition for tutorial card
- Fix tutorial navigation appearing when only one tutorial is visible

* Fix unreliable messages from Figma

- Made messages from Figma much more (completely?) reliable
- Fix autofocus warning in InputFlexible component

* Update visible tutorials directly after reset

* Fix unreactive variable

- Fix unreactive variable, (bug sveltejs/svelte#8374, but it wasn't necessary anyways)
- Switched all onmessage event to more robust window.addEventListener('message')
- Add key events to SuggestionItems
@mustafa0x
Copy link
Contributor

This majorly broke my component, forced to rollback to 3.55.1.

@Conduitry
Copy link
Member

The buggy optimization in #7942 has been reverted in 3.57.0 - apologies everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants