Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when animation directive is on component #8641

Merged
merged 6 commits into from
May 26, 2023

Conversation

ngtr6788
Copy link
Contributor

Fixes #8639, hopefully, unless maintainers want otherwise

HEADS UP: BIG RESTRUCTURING UNDERWAY

The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler aswell. For that reason, please don't open PRs that are large in scope, touch more than a couple of files etc. In other words, bug fixes are fine, but feature PRs will likely not be merged.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

@vercel
Copy link

vercel bot commented May 26, 2023

@ngtr6788 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@ngtr6788 ngtr6788 marked this pull request as ready for review May 26, 2023 13:06
@dummdidumm
Copy link
Member

dummdidumm commented May 26, 2023

Thank you! Could add an entry to the changelog and fix the test? Then we're good to go 👍

@ngtr6788
Copy link
Contributor Author

Thank you! Could add an entry to the changelog and fix the test? Then we're good to go 👍

Done!

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit a3f52f9 into sveltejs:version-4 May 26, 2023
5 of 7 checks passed
@ngtr6788 ngtr6788 deleted the animation-component branch May 26, 2023 17:19
@gtm-nayan gtm-nayan mentioned this pull request Jun 17, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants