Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS source maps #178

Closed
probablykasper opened this issue Sep 24, 2021 · 3 comments
Closed

CSS source maps #178

probablykasper opened this issue Sep 24, 2021 · 3 comments
Labels
enhancement New feature or request vite

Comments

@probablykasper
Copy link

Describe the problem

I'm not getting CSS source maps when using vite-plugin-svelte for Sass. I believe Vite supports CSS source maps now (vitejs/vite#649), so I'm guessing it's vite-plugin-svelte that doesn't support it?

Describe the proposed solution

Sass/CSS source map support

Alternatives considered

Giving up

Importance

would make my life easier

@probablykasper probablykasper added enhancement New feature or request triage Awaiting triage by a project member labels Sep 24, 2021
@bluwy
Copy link
Member

bluwy commented Sep 25, 2021

The PR vitejs/vite#4880 that fixes vitejs/vite#649 has been reverted in vitejs/vite#4951 as it causes issues in other toolchains. The actual fix lives at vitejs/vite#4950, until that's merge, CSS sourcemaps will then work.

With that said, vite-plugin-svelte already handles sourcemaps well, so we'd need to wait for upstream.

@bluwy bluwy added vite and removed triage Awaiting triage by a project member labels Sep 25, 2021
@probablykasper
Copy link
Author

Aah, makes sense

@bluwy
Copy link
Member

bluwy commented Sep 25, 2021

Since css sourcemaps is a general issue in Vite, I'm closing this in favour of vitejs/vite#2830.

@bluwy bluwy closed this as completed Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vite
Projects
None yet
Development

No branches or pull requests

2 participants