Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL2 support for inspector #355

Closed
khromov opened this issue May 30, 2022 · 3 comments
Closed

WSL2 support for inspector #355

khromov opened this issue May 30, 2022 · 3 comments
Labels
awaiting submitter enhancement New feature or request

Comments

@khromov
Copy link

khromov commented May 30, 2022

Describe the problem

When using this with Windows 10/11 + WSL2, there are two issues:

  • When clicking on a component, it doesn't open VS Code but rather opens a vim window in the SSH console. It also doesn't respond correctly to keypresses so you can't exit vim. 🙀
  • Neither the default key combo (I assume it'll pick the Linux one since WSL is typically running Ubuntu or Debian) nor manually configuring ctrl-shift seems to work. Only setting showToggleButton: 'always' works.

Describe the proposed solution

Perhaps there is some way for the plugin to understand that it's running in WSL2 + VSCode and send a message to the VS Code process?

Reproduction

  1. Install Windows 10 / 11 + WSL2 (Either manually or via Microsoft Store on Windows 11).
  2. Install the Ubuntu app from Microsoft Store.
  3. Install VSCode guide.
  4. Launch any normal Svelte project with the inspector configured.

Alternatives considered

Importance

nice to have

@khromov khromov added enhancement New feature or request triage Awaiting triage by a project member labels May 30, 2022
@dominikg
Copy link
Member

vite uses launch-editor to open your editor, WSL support is requested here: yyx990803/launch-editor#16

You may be able to set the vscode executable in the EDITOR environment variable as launch-editor supports that too.

Regarding key-combo, i'm a bit confused, ctrl-shift worked when i used it in a virtual machine (i don't have a native windows installation). Please try other combos to see if any of them work. eg ctrl-e.

Note it is not recommended to use printable letters together with holdMode: true

@dominikg
Copy link
Member

dominikg commented Jun 1, 2022

please let us know if EDITOR helps with your issue and if there is a key-combo that works for you.

@dominikg dominikg removed the triage Awaiting triage by a project member label Jun 5, 2022
@dominikg
Copy link
Member

dominikg commented Jun 5, 2022

Going to close this here, please follow the upstream issue for picking a more suitable editor in WSL yyx990803/launch-editor#16

Feedback regarding the keycombo is also still welcome though in my testing ctrl-shift did work fine in my windows vm and given you can configure any other combo of your chosing to work around local collisions there's little more v-p-s could do to improve the situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting submitter enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants