Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape should close svelte inspector #858

Closed
olehmisar opened this issue Feb 18, 2024 · 2 comments
Closed

Escape should close svelte inspector #858

olehmisar opened this issue Feb 18, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@olehmisar
Copy link

Describe the problem

Escape does not close svelte inspector

Describe the proposed solution

Escape should close svelte inspector

Alternatives considered

Importance

would make my life easier
@olehmisar olehmisar added enhancement New feature or request triage Awaiting triage by a project member labels Feb 18, 2024
@dominikg dominikg added the good first issue Good for newcomers label Feb 20, 2024
@dominikg
Copy link
Member

needs a key check for escape here

vite-plugin-svelte/packages/vite-plugin-svelte-inspector/src/runtime/Inspector.svelte

Line 191 in 0c2695d

} else if (is_holding()) {

@dominikg dominikg removed the triage Awaiting triage by a project member label Feb 20, 2024
@ryangclark ryangclark mentioned this issue Apr 4, 2024
Merged
@dominikg
Copy link
Member

dominikg commented May 3, 2024

fixed by #880

@dominikg dominikg closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominikg @olehmisar