-
Notifications
You must be signed in to change notification settings - Fork 248
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(resolve): hands over preserveSymlink processing to EHR (#865)
## Description - removes most preserveSymlink processing in favor of passing the preserveSymlink option to enhanced-resolve (which does this out of the box). - unwraps the swallow-tail in the resolve index & refactors the yarn/ berry `resolveVirtual` things - It's now properly reflected EHR's `symlinks` === `!preserveSymlink` ## Motivation and Context - Simplifies our code - By moving it to enhanced-resolve the properly resolved module name is available earlier in the process. This will make our live easier when we'd ever want to use that e.g. for workspaces (which are nothing but symlinks from node_modules to local folders). ## How Has This Been Tested? - [x] green ci - [x] adapted automatic non-regression test ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Documentation only change - [x] Refactor (non-breaking change which fixes an issue without changing functionality) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
- Loading branch information
Showing
4 changed files
with
40 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters