refactor: replaces 'glob' with 'picomatch' #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverweij
force-pushed
the
refactor/replaces-glob-with-picomatch
branch
from
9f945f9
to
8031c8d
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: glob@10.3.6 |
sverweij
force-pushed
the
refactor/replaces-glob-with-picomatch
branch
from
cfaaf80
to
8fb031a
Compare
This reverts commit 6c06ae9.
this will break on node 16 (uses the 'recursive' flag of readdirSync, which wasn't backported over there)
sverweij
force-pushed
the
refactor/replaces-glob-with-picomatch
branch
from
8fb031a
to
9d38a3c
Compare
|
Code Climate has analyzed commit 9e8121e and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
globwithpicomatchThis PR makes use of the fact that dependency-cruiser just dropped support for node 16 and 19, using nodejs >=18.17 feature -
readdirSync'srecursiveoption.Motivation and Context
See #839; reduces number of external dependencies, which reduces both security risks, maintenance effort and install size.
Not the goal of this exercise, but it also reduces the start-up time and the execution speed of the gatherInitialSources step:
npm test -f "[I] extract/gatherInitialSources"as measured by mochanode ./bin/dependency-cruise.mjs --no-cache -Tnull 'src/**'('real' time)node ./bin/dependency-cruise.mjs --no-cache -Tnull src('real' time)node ./bin/dependency-cruise.mjs --no-cache -Tnull 'src/**'('real' time)How Has This Been Tested?
Types of changes
Checklist
📖
⚖️