Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(extract): rewrites gatherInitialSources reduce with flatMap #842

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Sep 24, 2023

Description, Motivation and Context

  • rewrites a reduce with a flatMap so it's easier to read & maintain

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 馃摉

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • 鈿栵笍

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@codeclimate
Copy link

codeclimate bot commented Sep 24, 2023

Code Climate has analyzed commit 098acb1 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij marked this pull request as ready for review September 24, 2023 20:03
@sverweij sverweij merged commit 48ce9ab into main Sep 24, 2023
7 checks passed
@sverweij sverweij deleted the refactor/replace-reduce-with-flatmap branch September 24, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant