Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaces lodash's clone & cloneDeep with native structuredClone #850

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Oct 7, 2023

Description

  • replaces lodash/cloneDeep with native structuredClone
  • replaces lodash/clone with native structuredClone

Motivation and Context

Ongoing effort to reduce # of 3rd party dependencies (including that of lodash)

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 馃摉

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • 鈿栵笍

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2023

Code Climate has analyzed commit 1a59648 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij changed the title refactor: replaces lodash/cloneDeep with native structuredClone refactor: replaces lodash's clone & cloneDeep with native structuredClone Oct 7, 2023
@sverweij sverweij merged commit a1e5610 into main Oct 7, 2023
7 checks passed
@sverweij sverweij deleted the chore/replace-clonedeep-with-structured-clone branch October 7, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant