Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): links to npmjs/ nodejs.org for npm respectively node core modules #854

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

sverweij
Copy link
Owner

Description

  • for npm modules in the dot reporters link to npmjs.com
  • for node modules link to nodejs.org

Motivation and Context

Fixes #852

How Has This Been Tested?

  • green ci
  • additional automated integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@codeclimate
Copy link

codeclimate bot commented Oct 20, 2023

Code Climate has analyzed commit 3238ab8 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 08dce74 into main Oct 20, 2023
7 checks passed
@sverweij sverweij deleted the feature/different-prefixes-for-node_modules-core branch October 20, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: can i override a node's prefix via criteria ?
1 participant