feat!(extract): makes 'real' depencency type available alongside aliases BREAKING

[sverweij]

Description, Motivation and Context

Before this PR dependency types that came out of an alias (subpath import, webpack alias, tsconfig path) only stated that the dependency was an alias. However, these aliases point to other dependency types - local modules, third party ('npm') modules, nodejs builtin core(!) modules. This is useful information, and actually not listing those is an omission.

After merging this PR dependency-cruiser will start listing the 'actual' dependency type alongside the alias dependency types.

Technically this is a BREAKING CHANGE because rules that triggered on these 'real' dependency types before didn't trigger because they weren't detected.

after

{
  "modules": [
    {
      "source": "bin/depcruise-baseline.mjs",
      "dependencies": [
        {
          "dynamic": false,
          "module": "#cli/assert-node-environment-suitable.mjs",
          "moduleSystem": "es6",
          "exoticallyRequired": false,
          "resolved": "src/cli/assert-node-environment-suitable.mjs",
          "coreModule": false,
          "followable": true,
          "couldNotResolve": false,
          "dependencyTypes": [
            "aliased",
            "aliased-subpath-import",
            "local" // <<---- Now also listed that it's a local dependency
          ],
          "matchesDoNotFollow": false,
          "circular": false,
          "valid": true
        },
// ...

If you have a rule that e.g. forbids the local dependencyType from being used
it before didn't trigger on the above dependency. It now will, however ...

before

{
  "modules": [
    {
      "source": "bin/depcruise-baseline.mjs",
      "dependencies": [
        {
          "dynamic": false,
          "module": "#cli/assert-node-environment-suitable.mjs",
          "moduleSystem": "es6",
          "exoticallyRequired": false,
          "resolved": "src/cli/assert-node-environment-suitable.mjs",
          "coreModule": false,
          "followable": true,
          "couldNotResolve": false,
          "dependencyTypes": [
            "aliased",
            "aliased-subpath-import"
          ],
          "matchesDoNotFollow": false,
          "circular": false,
          "valid": true
        },
// ...

How Has This Been Tested?

• green ci
• additional & adapted automated non-regression tests

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Documentation only change
• Refactor (non-breaking change which fixes an issue without changing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• 📖

  • My change doesn't require a documentation update, or ...
  • it does and I have updated it

• ⚖️

  • The contribution will be subject to The MIT license, and I'm OK with that.
  • The contribution is my own original work.
  • I am ok with the stuff in CONTRIBUTING.md.

[codeclimate]

Code Climate has analyzed commit 0095b42 and detected 0 issues on this pull request.

View more on Code Climate.