feat(extract): makes support for workspaces explicit #864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aliased-workspace
dependency typeMotivation and Context
Imports from workspaces have been well-supported in dependency-cruiser since the stone age. Not by briliant foresight, but because it plugs into the regular node.js module resolution - workspaces are symlinks in node_modules sorta automatically linked to local folders. Dependency-cruiser didn't explicitly name them as separate dependency-types (instead slotting them into dependency type 'local' or 'npm-no-pkg' (when
npm i
wasn't run on the folder yet)). This PR corrects that oversight.This PR also fixes a bug uncovered by @throrin19: workspace imports were erroneously classified as tsconfig aliases (see #863 for details).
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️