refactor(resolve): hands over preserveSymlink processing to EHR

[sverweij]

Description

• removes most preserveSymlink processing in favor of passing the preserveSymlink option to enhanced-resolve (which does this out of the box).
• unwraps the swallow-tail in the resolve index & refactors the yarn/ berry resolveVirtual things
• It's now properly reflected EHR's symlinks === !preserveSymlink

Motivation and Context

• Simplifies our code
• By moving it to enhanced-resolve the properly resolved module name is available earlier in the process. This will make our live easier when we'd ever want to use that e.g. for workspaces (which are nothing but symlinks from node_modules to local folders).

How Has This Been Tested?

• green ci
• adapted automatic non-regression test

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Documentation only change
• Refactor (non-breaking change which fixes an issue without changing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• 📖

  • My change doesn't require a documentation update, or ...
  • it does and I have updated it

• ⚖️

  • The contribution will be subject to The MIT license, and I'm OK with that.
  • The contribution is my own original work.
  • I am ok with the stuff in CONTRIBUTING.md.

[codeclimate]

Code Climate has analyzed commit 0de3b70 and detected 0 issues on this pull request.

View more on Code Climate.