Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reporter/dot): only considers rule severity for coloring invalid modules/ dependencies #869

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Nov 18, 2023

Description, Motivation and Context

  • only color modules & dependencies in one of the severity level colors when there's a severity set on the associated rule

The default dot configuration built into dependency-cruiser made that things that were invalid, but for which the rule was ignored showed up with a red color. This is obviously not helpful (why otherwise ignore the rule).

How Has This Been Tested?

  • green ci
  • adjusted automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Nov 18, 2023

Code Climate has analyzed commit 4772d37 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij changed the title feat(reporter/dot): only colors invalid modules/ dependencies based on rule severity feat(reporter/dot): only considers rule severity for coloring invalid modules/ dependencies Nov 18, 2023
@sverweij sverweij merged commit dfdb385 into main Nov 18, 2023
8 checks passed
@sverweij sverweij deleted the feature/only-color-red-on-severity branch November 18, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant