Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init): adds exception to not-to-dev-dep for type-only dependencies #874

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Nov 24, 2023

Description

  • adds an exception to the not-to-dev-dep for type-only dependencies to ones in @types folders (which are pretty likely to be type only as well, even when not explicitly imported as such)
  • does the same for dependency-cruiser's own configuration

Motivation and Context

Implements the second suggestion from #873

How Has This Been Tested?

  • green ci
  • manually against a TS repo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Nov 24, 2023

Code Climate has analyzed commit a2b78a4 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 8aa2a3d into main Nov 24, 2023
8 checks passed
@sverweij sverweij deleted the feature/add-exception-for-type-only branch November 24, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant