Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wrap-stream-in-html): makes the wrapper easier to maintain #877

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Nov 26, 2023

Description

  • inline the html into javascript
  • move the css to a separate file so styling tweaks are easier to get to

Motivation and Context

  • Editors kept autocorrecting 'header' and 'footer' html with closing and opening tags that made the result invalid html
  • The css is now easier to get to

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 馃摉

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • 鈿栵笍

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Nov 26, 2023

Code Climate has analyzed commit 8988d61 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit c6a33b1 into main Nov 26, 2023
8 checks passed
@sverweij sverweij deleted the refactor/wrap-stream-in-html branch November 26, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant