-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI ignores --svg-namespace-ids false
#763
Comments
Unsure how to proceed here because the changes in v2.0.2 were meant to fix another issue. Feel free to submit a PR with a test case. |
Until this [issue](svg-sprite/svg-sprite#763) can be resolved.
@Kreeg it seems this is also a regression, unsure how ti fix it. If you have any ideas let me know. |
I'll take a look in next week |
That's strange, I can't confirm this on the latest version |
I can't confirm this in 2.0.2. Ids are fine
2.0.1 is the same. |
Can confirm I'm getting the same result as @michaelbragg. I'm using "svg-test": "svg-sprite -s ./public/app/themes/theme/assets/svg/icons/*.svg --svg-namespace-classnames false --svg-namespace-ids false --symbol-sprite icons.svg --symbol-dest ./public/app/themes/theme/assets/svg", It then outputs this: <?xml version="1.0" encoding="utf-8"?><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><symbol viewBox="0 0 55 40" id="public--app--themes--theme--assets--svg--icons--aeo" xmlns="http://www.w3.org/2000/svg"><path d="M32.909 17.594a12.534... Whereas if using <?xml version="1.0" encoding="utf-8"?><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><symbol viewBox="0 0 55 40" id="aeo" xmlns="http://www.w3.org/2000/svg"><path d="M32.909 17.594a12.534... |
@XhmikosR Why are you unsure? Simply revert the change and it would be really nice to care more about semver so it won't break our builds. |
Hi folks, has there been any update on this? I noticed 2.0.3 has been released, but if there's an ETA on this fix that would be appreciated, as we're currently having to fix the version number until it's resolved. Thanks! |
Overview:
Upgrading from
2.0.1
to2.0.2
has broken the--svg-namespace-ids false
command when using the CLI.Our SVG Sprite builds, with 2.0.2, have started to include the full path as a namespace in the sprite file. Whereas 2.0.1 only included the filename as the ID.
On the command-line run
svg-sprite -s --symbol-dest /assets/svg --svg-namespace-classnames false --svg-namespace-ids false --symbol-sprite icons.svg /assets/svg/icons/*.svg
.Original icon
./assets/svg/icons/search.svg
Expected Id value, as of 2.0.1,
id="search"
:Actual Id value, as of 2.0.2,
id="public--app--themes--demo--assets--svg--icons--search"
:Resolving the issue can be achieved by rolling back SVG-Sprite to v2.0.1
The text was updated successfully, but these errors were encountered: