Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masterShapes does not sorted. #830

Open
kamatte-me opened this issue Jul 12, 2023 · 2 comments
Open

masterShapes does not sorted. #830

kamatte-me opened this issue Jul 12, 2023 · 2 comments

Comments

@kamatte-me
Copy link

In v1.5.4, master shapes were sorted and then shape.setNamespace() is executed.
https://github.com/svg-sprite/svg-sprite/blob/v1.5.4/lib/svg-sprite.js#L258-L265

However, in v2.0.0 and later, master shapes executes shape.setNamespace() without sorting.
https://github.com/svg-sprite/svg-sprite/blob/v2.0.2/lib/svg-sprite.js#L262-L279

This causes a difference in the namespace created by _indexNamespace() each time it is compiled. masterShapes should also be sorted.

@XhmikosR
Copy link
Member

Patches are welcome to restore the previous behavior.

@XhmikosR
Copy link
Member

@kamatte-me can you try this branch please? main...xmr/masterShapes

I can't figure out the exact commit this broke, so I'm not 100% sure this is the right fix, any help is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants