Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob - Inflight - Missing Release of Resource after Effective Lifetime #889

Open
Luen opened this issue Mar 5, 2024 · 1 comment
Open

Comments

@Luen
Copy link

Luen commented Mar 5, 2024

Security vulnerability identified by Snyk within the svg-sprite package's dependencies.
The issue is tied to the inflight package, which is a transitive dependency through glob. According to Snyk, the vulnerability is registered as SNYK-JS-INFLIGHT-6095116 and CWE-772: Missing Release of Resource after Effective Lifetime.

Issue Description

The inflight package, which is used to prevent parallel execution of async tasks with the same key, has been reported to have a security vulnerability.

Relevant Context

glob version 9 and onwards have moved away from using callbacks to promises, leading to the removal of inflight from its dependencies due to the API changes. This evolution is discussed in the following node-glob GitHub issues:

Additionally, the inflight package itself has it's own issues:

Suggested Action

Given that glob has evolved past the need for inflight, it may be beneficial for svg-sprite to update its dependencies accordingly to a version of glob that does not rely on inflight V9/V10.

@XhmikosR
Copy link
Member

XhmikosR commented Mar 5, 2024

I personally don't want to update glob due to this: https://packagephobia.com/result?p=glob%407.2.3%2Cglob%4010.2.4.

So, ideally someone should find a small replacement package and submit a PR with test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants