Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convertStyleToAttrs removes color #1040

Closed
JoKalliauer opened this issue Sep 23, 2018 · 6 comments
Closed

convertStyleToAttrs removes color #1040

JoKalliauer opened this issue Sep 23, 2018 · 6 comments

Comments

@JoKalliauer
Copy link

Processing File:2016_Angola_and_DR_Congo_yellow_fever_outbreak.svg with default options removes the color of countries:

svgo -i Bug1040_Input2.svg.txt -o Bug1040_Output2.svg.txt --pretty --indent=1 --enable=convertStyleToAttrs

Input

Bug1040_Input2.svg.txt

bug1040_input2

Output

Bug1040_Output2.svg.txt

bug1040_output2


It seems to be a more complicated bug since editiong the file changes the Processiong of other parts.

Copyright

License: CC0

Author: Mikael Häggström

Details (and Source): https://commons.wikimedia.org/wiki/File:2016_Angola_and_DR_Congo_yellow_fever_outbreak.svg

@TrySound
Copy link
Member

convertStyleToAttrs will be disabled by default in the next release
#1365

@JoKalliauer
Copy link
Author

@TrySound : Does "solved in master" mean, that the bug does not occur with default configuration, but might occur with different settings? Does it mean that features which are disabled by default are marginally maintained?

@TrySound
Copy link
Member

Solved the problem with default configuration, right. I consider this plugin unsafe for now. Though removing it would be breaking change. Maybe it will come back later with more flexible architecture.

@JoKalliauer
Copy link
Author

I make workarounds for LibrsvgBugs, librsvg might be more buggy than svgo, so convertStyleToAttrs is usefull for me, even I know it is buggy.
I prefer having buggy beta-features, even if they are not officially maintained.

Maybe keep buggy features and declare in the Docs that they are buggy and not officially maintained, and hide them e.g. in svgo --show-plugins. Maybe make a terminal-warning-output if enabled.

@TrySound
Copy link
Member

Sure, if the problem will not be resolved I will add warning or something.

@TrySound
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants