Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off husky and lint staged during release #838

Closed
char0n opened this issue Oct 29, 2021 · 1 comment
Closed

Turn off husky and lint staged during release #838

char0n opened this issue Oct 29, 2021 · 1 comment
Assignees
@char0n
Labels
ApiDOM enhancement New feature or request

Comments

@char0n
Copy link
Member

char0n commented Oct 29, 2021 •
edited

Motivation: Husky caused failure in 0.5.0 release. It is not necessary to run husky during release process.

Disabling husky: https://typicode.github.io/husky/#/?id=with-env-variables

Husky runs the lint-staged to disabling husky is enough.
@char0n char0n self-assigned this Oct 29, 2021
@char0n char0n added ApiDOM enhancement New feature or request labels Oct 29, 2021
char0n added a commit that referenced this issue Oct 29, 2021
@char0n
ci(release): disable husky during release
a379b63 
Refs #838
@char0n char0n mentioned this issue Oct 29, 2021
Merged
char0n added a commit that referenced this issue Oct 29, 2021
@char0n
ci(release): disable husky during release
4568932 
Refs #838
@char0n char0n closed this as completed Oct 29, 2021
@frantuma
Copy link
Member

Reason for failure was a regression in lint-staged, solved in latest release (applied in https://github.com/swagger-api/apidom/pull/830/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L78)

lint-staged issue: lint-staged/lint-staged#1032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@char0n @frantuma