Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dots lost when dereferencing files with dots #2092

Open
simonhege opened this issue May 7, 2024 · 2 comments · May be fixed by #2093
Open

dots lost when dereferencing files with dots #2092

simonhege opened this issue May 7, 2024 · 2 comments · May be fixed by #2093

Comments

@simonhege
Copy link

Hello

Following fix for #1865 the name of the schema lost the dots

The name of the schema being of importance in the code generation, I think the swagger-parser should keep the dots as per the referenced file name

This mean that at
https://github.com/swagger-api/swagger-parser/blob/master/modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java#L115
I expect to see #/components/schemas/foo.model
instead of #/components/schemas/foomodel
@simonhege
Copy link
Author

If you agree with this, I'll submit a pull-request for the change.

@simonhege simonhege linked a pull request May 7, 2024 that will close this issue
Open
@simonhege
Copy link
Author

Ping @gracekarina as you did the original fix on #1865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for issue-2092 - dots lost when dereferencing files with dots simonhege/swagger-parser
1 participant
@simonhege