Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsdom): cumulative Jest updates with support for TextEncoder/Text… #8111

Merged
merged 1 commit into from Jul 20, 2022

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Jul 20, 2022

Description

Add a setupFiles to the jest.config.js to shim TextEncoder/TextDecoder from util library.

Note:

As of Jest 28 "jest-environment-jsdom" is no longer shipped by default, make sure to install it separately.

Note: No change required to actual unit tests.

  • fix(jest): setupFiles jest-shim.js for TextEncoder/TextDecoder

  • chore(deps-dev): bump jsdom to 20.0.0

  • chore(deps-dev): add util@0.12.4

  • chore(deps-dev): bump jest to 28.1.3

  • chore(deps-dev): add jest-environment-jsdom@28.1.3 for jest@28

Motivation and Context

After bumping jsdom, resolve ReferenceError: TextEncoder is not defined.

Cause: Recent versions of jsdom and whatwg-url removed node.js polyfills for TextEncoder, TextDecoder, and probably more.

Closes #8068
Closes #8110

How Has This Been Tested?

locally tested

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit b89e885 into swagger-api:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant