Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): responsive ui display #8132

Merged
merged 5 commits into from Aug 1, 2022
Merged

fix(ux): responsive ui display #8132

merged 5 commits into from Aug 1, 2022

Conversation

yzhe819
Copy link
Contributor

@yzhe819 yzhe819 commented Jul 30, 2022

Description

Fixed link display on small screens
Also fixed the display issue of input element

Motivation and Context

Fixes #6647 #7338

How Has This Been Tested?

Only update the relevant CSS

Screenshots (if appropriate):

The display issue:
2022-07-31 11 29 43

After fixed:
2022-07-31 11 27 21

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@yzhe819 yzhe819 changed the title fix: responsive operation fix(ux): responsive ui display Jul 30, 2022
@yzhe819
Copy link
Contributor Author

yzhe819 commented Jul 31, 2022

I also tried to fix display issues with input elements. Related to #7338

Here is the result.

screenshot of issue

2022-07-31 12 18 25

Fixed one

2022-07-31 12 15 15

@yzhe819
Copy link
Contributor Author

yzhe819 commented Jul 31, 2022

Hey @tim-lai! This pr is ready to be merged. Feel free to take a look.

@tim-lai tim-lai self-assigned this Aug 1, 2022
@tim-lai tim-lai merged commit c36f240 into swagger-api:master Aug 1, 2022
@tim-lai
Copy link
Contributor

tim-lai commented Aug 1, 2022

@yzhe819 Thanks for the PR! It looks good and is now merged. Thanks for the contribution!

@media (max-width: 640px) {
small
{
flex: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The operation in SwaggerUIBundle is not responsive
3 participants