Improve accessibility for Authorization buttons #8998
Assignees
Comments
vmware-jaret
added a commit
to vmware-jaret/swagger-ui
that referenced
this issue
Jul 5, 2023
- Introduced the AuthorizeButton component that entails the apply authorization and remove authorization functionality, as well as a close button. - Unit tests provided for different states. - AuthorizeButton is able to be used for both form submit and onClick function behavior.
vmware-jaret
added a commit
to vmware-jaret/swagger-ui
that referenced
this issue
Jul 5, 2023
- Introduced the AuthorizeButton component that entails the apply authorization and remove authorization functionality, as well as a close button. - Unit tests provided for different states. - AuthorizeButton is able to be used for both form submit and onClick function behavior.
17 tasks
|
@char0n This is the first issue and PR I do for this repository. Is according to you the above format correct and complete? And most importantly do you think the content make sense? |
|
Hi @vmware-jaret, Yeah, the issue format is just fine, thanks! |
vmware-jaret
added a commit
to vmware-jaret/swagger-ui
that referenced
this issue
Sep 6, 2023
- Introduced the AuthorizeButton component that entails the apply authorization and remove authorization functionality, as well as a close button. - Unit tests provided for different states. - AuthorizeButton is able to be used for both form submit and onClick function behavior.
vmware-jaret
added a commit
to vmware-jaret/swagger-ui
that referenced
this issue
Sep 6, 2023
- Reverted the AuthorizationButton as <label /> is not needed and `aria-label` seems to be better fit for screen readers (see as well https://www.w3.org/WAI/WCAG21/Techniques/html/H44 that <label /> is not usable for <button /> or <input type="submit" /> HTML elements). - Validation test for that aria-label is available for OAuth2 authorization and non-oauth2 authorization buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Content & configuration
The
AuthorizeandLogoutbuttons do not provide additional descriptions that are used for improving accessibility, e.g. by screen readers.Is your feature request related to a problem?
N.A.: not an existing filed problem.
Describe the solution you'd like
Based upon Web Accessibility Guidelines v2.0 (https://www.w3.org/TR/WCAG20/) adding a hidden label would be sufficient to provide addition descriptions without changing the UI itself.
Describe alternatives you've considered
See https://www.w3.org/WAI/WCAG21/Techniques/html/H44 for the alternatives besides a hidden label (such as roles).
Additional context
The text was updated successfully, but these errors were encountered: