Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search for definitions from dependent packages first #1666

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Sep 6, 2023

Describe the PR
If a type is an alias type from a dependent package and they share the same short package name and type name, the dependent type will be hidden. So this PR will search for type definitions from dependent packages first.

Relation issue
#1662

Signed-off-by: sdghchj <sdghchj@qq.com>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e9d0aa5) 83.56% compared to head (be22bb5) 83.56%.

❗ Current head be22bb5 differs from pull request most recent head bb3889f. Consider uploading reports for the commit bb3889f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1666   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          19       19           
  Lines        3820     3821    +1     
=======================================
+ Hits         3192     3193    +1     
  Misses        533      533           
  Partials       95       95           
Files Changed Coverage Δ
packages.go 89.15% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdghchj sdghchj requested a review from ubogdan November 16, 2023 07:16
@ubogdan
Copy link
Contributor

ubogdan commented Nov 16, 2023

Not sure about the change impact. You should write to cover this change. Approved.

@sdghchj sdghchj merged commit 6cdaaf5 into master Nov 24, 2023
10 checks passed
@sdghchj sdghchj deleted the fix-issue-1662 branch November 24, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants