Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod to example/celler #838

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

akojo
Copy link
Contributor

@akojo akojo commented Nov 23, 2020

Describe the PR
Since example/celler now depends on modules that main go.mod doesn't, running go mod tidy adds unnecessary dependencies to main go.mod. Fix by adding go.mod to example/celler

Relation issue
Related to e.g. #826 and #563

Additional context
Fixes an issue created by #800

Since example/celler depends on modules that main go.mod doesn't, `go
mod tidy` gets confused. Fix by adding example/celler/go.mod
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #838 (c975eae) into master (3d083d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #838   +/-   ##
=======================================
  Coverage   84.88%   84.88%           
=======================================
  Files           8        8           
  Lines        1654     1654           
=======================================
  Hits         1404     1404           
  Misses        145      145           
  Partials      105      105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d083d3...c975eae. Read the comment docs.

@sdghchj sdghchj merged commit ee29e2b into swaggo:master Nov 23, 2020
@akojo akojo deleted the fix/add-go-mod-to-example-celler branch November 23, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants