You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you to all of y'all who maintain this package! I've been playing around with it and it's awesome.
I noticed that the WNBA players and teams are not in the static data file. I'm working on something that requires this data.
How is the data in this file generated? Is there a script somewhere in this repository that generates this? I'm happy to open a pull request to add the WNBA players and and teams, but wanted to check to see if there's a standard way the static data is generated.
Thanks!
The text was updated successfully, but these errors were encountered:
If we want to add players and teams to the static data file, I think adopting a {variable}_wnba format would work. This way we'd maintain the players for the nba and use players_wnba for the wnba.
Thoughts? Happy to work on this over the next week, or you're more than welcome to submit a PR. I'd prefer the latter as time is a little tight on my end. Either works though. :-)
First of all, thank you to all of y'all who maintain this package! I've been playing around with it and it's awesome.
I noticed that the WNBA players and teams are not in the static data file. I'm working on something that requires this data.
How is the data in this file generated? Is there a script somewhere in this repository that generates this? I'm happy to open a pull request to add the WNBA players and and teams, but wanted to check to see if there's a standard way the static data is generated.
Thanks!
The text was updated successfully, but these errors were encountered: