Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(register): always resolve full file path for tsconfig and add paths if available #646

Merged
merged 5 commits into from Apr 5, 2022

Conversation

dmregister
Copy link
Contributor

Addresses #626

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dmregister
Copy link
Contributor Author

@Brooooooklyn I'm not sure how these snapshots work. I added the snapshot file on the last commit and it failed as it was not used. Once I deleted it, now it's failing cause it's missing. Any idea how to resolve this? I do not get the error locally.

@dmregister
Copy link
Contributor Author

@Brooooooklyn let me know if this PR needs anything else or if I need to split this up into 2 PR's

  1. for the paths updates
  2. fully resolve tsConfig path

@Brooooooklyn Brooooooklyn merged commit 3062413 into swc-project:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants