From 01edb4fff44a9fd6424a9a5f75afb0165b0bad85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Donny/=EA=B0=95=EB=8F=99=EC=9C=A4?= Date: Tue, 25 Oct 2022 14:12:30 +0900 Subject: [PATCH] test(es/minifier): Organize terser tests (#6247) --- crates/swc_ecma_minifier/tests/TODO.txt | 4 ---- crates/swc_ecma_minifier/tests/passing.txt | 4 ++++ .../collapse_vars_assignment/output.js | 16 +++++++--------- .../collapse_vars/collapse_vars_unary/output.js | 3 +-- .../compress/collapse_vars/var_defs/output.js | 8 +++----- .../collapse_vars/var_side_effects_2/output.js | 7 ++++--- 6 files changed, 19 insertions(+), 23 deletions(-) diff --git a/crates/swc_ecma_minifier/tests/TODO.txt b/crates/swc_ecma_minifier/tests/TODO.txt index b74e66ff4f1b..f6ffef9d3522 100644 --- a/crates/swc_ecma_minifier/tests/TODO.txt +++ b/crates/swc_ecma_minifier/tests/TODO.txt @@ -21,7 +21,6 @@ collapse_vars/chained_1/input.js collapse_vars/chained_2/input.js collapse_vars/chained_3/input.js collapse_vars/collapse_vars_arguments/input.js -collapse_vars/collapse_vars_assignment/input.js collapse_vars/collapse_vars_constants/input.js collapse_vars/collapse_vars_do_while/input.js collapse_vars/collapse_vars_do_while_drop_assign/input.js @@ -34,7 +33,6 @@ collapse_vars/collapse_vars_short_circuit/input.js collapse_vars/collapse_vars_short_circuited_conditions/input.js collapse_vars/collapse_vars_side_effects_1/input.js collapse_vars/collapse_vars_switch/input.js -collapse_vars/collapse_vars_unary/input.js collapse_vars/cond_branch_1/input.js collapse_vars/cond_branch_2/input.js collapse_vars/double_def_1/input.js @@ -72,8 +70,6 @@ collapse_vars/switch_case_1/input.js collapse_vars/toplevel_single_reference/input.js collapse_vars/undeclared/input.js collapse_vars/unused_orig/input.js -collapse_vars/var_defs/input.js -collapse_vars/var_side_effects_2/input.js conditionals/equality_conditionals_false/input.js conditionals/ifs_5/input.js conditionals/ifs_6/input.js diff --git a/crates/swc_ecma_minifier/tests/passing.txt b/crates/swc_ecma_minifier/tests/passing.txt index 1f706df8570a..5ca97f61859e 100644 --- a/crates/swc_ecma_minifier/tests/passing.txt +++ b/crates/swc_ecma_minifier/tests/passing.txt @@ -146,6 +146,7 @@ collapse_vars/collapse_rhs_undefined/input.js collapse_vars/collapse_rhs_var/input.js collapse_vars/collapse_rhs_vardef/input.js collapse_vars/collapse_vars_array/input.js +collapse_vars/collapse_vars_assignment/input.js collapse_vars/collapse_vars_closures/input.js collapse_vars/collapse_vars_eval_and_with/input.js collapse_vars/collapse_vars_issue_721/input.js @@ -157,6 +158,7 @@ collapse_vars/collapse_vars_seq/input.js collapse_vars/collapse_vars_side_effects_2/input.js collapse_vars/collapse_vars_throw/input.js collapse_vars/collapse_vars_try/input.js +collapse_vars/collapse_vars_unary/input.js collapse_vars/collapse_vars_unary_2/input.js collapse_vars/collapse_vars_while/input.js collapse_vars/compound_assignment/input.js @@ -246,7 +248,9 @@ collapse_vars/side_effects_property/input.js collapse_vars/switch_case_2/input.js collapse_vars/switch_case_3/input.js collapse_vars/unsafe_builtin/input.js +collapse_vars/var_defs/input.js collapse_vars/var_side_effects_1/input.js +collapse_vars/var_side_effects_2/input.js collapse_vars/var_side_effects_3/input.js comments/comment_moved_between_return_and_value/input.js comments/preserve_comments_by_default/input.js diff --git a/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_assignment/output.js b/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_assignment/output.js index 7f410715598d..a817f5a6b700 100644 --- a/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_assignment/output.js +++ b/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_assignment/output.js @@ -2,27 +2,25 @@ function log(x) { return console.log(x), x; } function f0(c) { - var a = 3 / c; - return (a = a); + return 3 / c; } function f1(c) { return 1 - 3 / c; } function f2(c) { - return log((c = 3 / c - 7)); + return log(c = 3 / c - 7); } function f3(c) { - return log((c |= 3 / c - 7)); + var a = 3 / c; + return log(c |= a - 7); } function f4(c) { - var b = 2; - return log((b += 3 / c)); + return log(2 + 3 / c); } function f5(c) { - var b = 2; - return log((b += 3 / c)); + return log(2 + 3 / c); } function f6(c) { var b = g(); - return log((b += 3 / c)); + return log(b += 3 / c); } diff --git a/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_unary/output.js b/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_unary/output.js index d7d5b462694c..927a4900db1c 100644 --- a/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_unary/output.js +++ b/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/collapse_vars_unary/output.js @@ -1,6 +1,5 @@ function f0(o, p) { - var x = o[p]; - return delete x; + return o[p], !0; } function f1(n) { return n > +!!n; diff --git a/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_defs/output.js b/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_defs/output.js index 959670d8f8eb..6f8f6a90e55c 100644 --- a/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_defs/output.js +++ b/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_defs/output.js @@ -1,7 +1,5 @@ -var f1 = function (x, y) { - var r = x + y, - a = r * r - r, - b = 7; - console.log(a + b); +var f1 = function(x, y) { + var r = x + y; + console.log(r * r - r + 7); }; f1("1", 0); diff --git a/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_side_effects_2/output.js b/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_side_effects_2/output.js index 9d14db2fe214..22cfd3d787af 100644 --- a/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_side_effects_2/output.js +++ b/crates/swc_ecma_minifier/tests/terser/compress/collapse_vars/var_side_effects_2/output.js @@ -1,6 +1,7 @@ var print = console.log.bind(console); function foo(x) { - var twice = 2 * x.y; - print("Foo:", twice); + print("Foo:", 2 * x.y); } -foo({ y: 10 }); +foo({ + y: 10 +});