Skip to content

Commit 05d185d

Browse files
authoredNov 16, 2022
fix(es/modules): Fix jsc.paths (#6454)
**Related issue:** - Closes #6446.
1 parent ba9f47d commit 05d185d

File tree

10 files changed

+26
-24
lines changed

10 files changed

+26
-24
lines changed
 

‎crates/swc/tests/fixture/deno/paths/cjs-001/output/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
Object.defineProperty(exports, "__esModule", {
33
value: true
44
});
5-
require("./src/dep.ts");
6-
require("./src2/dep-2.ts");
5+
require("./src/dep");
6+
require("./src2/dep-2");
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
import styles from "./foo.ts/index.js";
1+
import styles from "./foo.ts/index";
22
console.log(styles);

‎crates/swc/tests/fixture/deno/paths/issue-2126/output/src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
Object.defineProperty(exports, "__esModule", {
33
value: true
44
});
5-
const _a = require("../packages/a/src/index.ts");
5+
const _a = require("../packages/a/src/index");
66
console.log(`${(0, _a.displayA)()}`);

‎crates/swc/tests/fixture/deno/paths/issue-2724/output/src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ Object.defineProperty(exports, "__esModule", {
44
});
55
const _interopRequireWildcard = require("@swc/helpers/lib/_interop_require_wildcard.js").default;
66
(async function() {
7-
const { displayA } = await Promise.resolve().then(()=>/*#__PURE__*/ _interopRequireWildcard(require("../packages/a/src/index.ts")));
7+
const { displayA } = await Promise.resolve().then(()=>/*#__PURE__*/ _interopRequireWildcard(require("../packages/a/src/index")));
88
console.log(displayA());
99
})();

‎crates/swc/tests/fixture/deno/paths/issue-2844/output/src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Object.defineProperty(exports, "__esModule", {
33
value: true
44
});
5-
require("./core/module/moduleFile.ts");
5+
require("./core/module/moduleFile");
66
require("./core/utils");
77
require("./core/utilFile");
88
require("./utils");
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
import { sum } from "./modules/01-moduleA/utils.ts";
1+
import { sum } from "./modules/01-moduleA/utils";
22
export { multiply } from "./modules/03-moduleB/utils";
33
console.log(sum(1, 2));

‎crates/swc/tests/fixture/issues-2xxx/2050/output/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ Object.defineProperty(exports, "__esModule", {
33
value: true
44
});
55
const _interopRequireDefault = require("@swc/helpers/lib/_interop_require_default.js").default;
6-
const _a = /*#__PURE__*/ _interopRequireDefault(require("./subfolder/A.ts"));
6+
const _a = /*#__PURE__*/ _interopRequireDefault(require("./subfolder/A"));
77
console.log(_a.default);

‎crates/swc_ecma_transforms_module/src/path.rs

+2
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ where
129129
if use_orig {
130130
p.set_extension(orig_ext);
131131
}
132+
} else {
133+
p.set_extension("");
132134
}
133135

134136
p.display().to_string().into()

‎crates/swc_ecma_transforms_module/tests/fixture-manual/issue-4730/output/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { displayB } from "../packages/b/src/index.ts";
1+
import { displayB } from "../packages/b/src/index";
22
async function display() {
3-
const displayA = await import("../packages/a/src/index.ts").then((c)=>c.displayA);
3+
const displayA = await import("../packages/a/src/index").then((c)=>c.displayA);
44
console.log(displayA());
55
console.log(displayB());
66
}

‎node-swc/__tests__/transform/issue_4730_test.mjs

+14-14
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,18 @@ it("should work", async () => {
3232
},
3333
});
3434
expect(code).toMatchInlineSnapshot(`
35-
"\\"use strict\\";
36-
Object.defineProperty(exports, \\"__esModule\\", {
37-
value: true
38-
});
39-
const _interopRequireWildcard = require(\\"@swc/helpers/lib/_interop_require_wildcard.js\\").default;
40-
const _b = require(\\"../packages/b/src/index.ts\\");
41-
async function display() {
42-
const displayA = await Promise.resolve().then(()=>/*#__PURE__*/ _interopRequireWildcard(require(\\"../packages/a/src/index.ts\\"))).then((c)=>c.displayA);
43-
console.log(displayA());
44-
console.log((0, _b.displayB)());
45-
}
46-
display();
47-
"
48-
`);
35+
"\\"use strict\\";
36+
Object.defineProperty(exports, \\"__esModule\\", {
37+
value: true
38+
});
39+
const _interopRequireWildcard = require(\\"@swc/helpers/lib/_interop_require_wildcard.js\\").default;
40+
const _b = require(\\"../packages/b/src/index\\");
41+
async function display() {
42+
const displayA = await Promise.resolve().then(()=>/*#__PURE__*/ _interopRequireWildcard(require(\\"../packages/a/src/index\\"))).then((c)=>c.displayA);
43+
console.log(displayA());
44+
console.log((0, _b.displayB)());
45+
}
46+
display();
47+
"
48+
`);
4949
});

1 commit comments

Comments
 (1)

github-actions[bot] commented on Nov 16, 2022

@github-actions[bot]

Benchmark

Benchmark suite Current: 05d185d Previous: 6388920 Ratio
es/full/bugs-1 349632 ns/iter (± 29760) 344232 ns/iter (± 20153) 1.02
es/full/minify/libraries/antd 1957165331 ns/iter (± 53635805) 1870017561 ns/iter (± 53797770) 1.05
es/full/minify/libraries/d3 433230902 ns/iter (± 17642077) 419934434 ns/iter (± 14523502) 1.03
es/full/minify/libraries/echarts 1671474473 ns/iter (± 98476853) 1588121067 ns/iter (± 93895552) 1.05
es/full/minify/libraries/jquery 104882915 ns/iter (± 3030188) 110251465 ns/iter (± 7453291) 0.95
es/full/minify/libraries/lodash 147869608 ns/iter (± 24038492) 126503063 ns/iter (± 12762936) 1.17
es/full/minify/libraries/moment 68619452 ns/iter (± 3432784) 60735024 ns/iter (± 1532977) 1.13
es/full/minify/libraries/react 22669381 ns/iter (± 3486552) 20708172 ns/iter (± 322676) 1.09
es/full/minify/libraries/terser 369145753 ns/iter (± 39937234) 321355080 ns/iter (± 16845243) 1.15
es/full/minify/libraries/three 715356507 ns/iter (± 82567204) 564867714 ns/iter (± 17924549) 1.27
es/full/minify/libraries/typescript 4283352428 ns/iter (± 226778311) 3584339278 ns/iter (± 118889990) 1.20
es/full/minify/libraries/victory 1017507676 ns/iter (± 69442282) 872678416 ns/iter (± 47295398) 1.17
es/full/minify/libraries/vue 217195615 ns/iter (± 7995448) 178966369 ns/iter (± 16255938) 1.21
es/full/codegen/es3 39145 ns/iter (± 7077) 34200 ns/iter (± 2200) 1.14
es/full/codegen/es5 37019 ns/iter (± 7245) 34074 ns/iter (± 840) 1.09
es/full/codegen/es2015 36482 ns/iter (± 4972) 34126 ns/iter (± 1534) 1.07
es/full/codegen/es2016 36237 ns/iter (± 4597) 34873 ns/iter (± 1778) 1.04
es/full/codegen/es2017 36842 ns/iter (± 4208) 34514 ns/iter (± 2488) 1.07
es/full/codegen/es2018 43374 ns/iter (± 7329) 34407 ns/iter (± 2145) 1.26
es/full/codegen/es2019 40675 ns/iter (± 7412) 34657 ns/iter (± 1562) 1.17
es/full/codegen/es2020 35644 ns/iter (± 6538) 34543 ns/iter (± 3634) 1.03
es/full/all/es3 233796880 ns/iter (± 23717192) 207515867 ns/iter (± 21111045) 1.13
es/full/all/es5 199044625 ns/iter (± 14093987) 199288045 ns/iter (± 20306594) 1.00
es/full/all/es2015 172620647 ns/iter (± 16790762) 155166491 ns/iter (± 13875040) 1.11
es/full/all/es2016 159275145 ns/iter (± 18333985) 155754607 ns/iter (± 13486061) 1.02
es/full/all/es2017 162641875 ns/iter (± 17706312) 158548077 ns/iter (± 14597397) 1.03
es/full/all/es2018 161547619 ns/iter (± 17546494) 159638772 ns/iter (± 16745968) 1.01
es/full/all/es2019 161714485 ns/iter (± 12642274) 154337469 ns/iter (± 18614991) 1.05
es/full/all/es2020 157365213 ns/iter (± 15601094) 148226789 ns/iter (± 18017006) 1.06
es/full/parser 800604 ns/iter (± 177378) 744271 ns/iter (± 64880) 1.08
es/full/base/fixer 29917 ns/iter (± 3643) 27685 ns/iter (± 3536) 1.08
es/full/base/resolver_and_hygiene 102767 ns/iter (± 12439) 96451 ns/iter (± 11987) 1.07
serialization of ast node 237 ns/iter (± 37) 217 ns/iter (± 24) 1.09
serialization of serde 261 ns/iter (± 37) 232 ns/iter (± 15) 1.13

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.