fix(es/module): Don't resolve as node_modules from TscResolver (#…

…7866)

**Related issue:**

 - Closes #7863

crates/swc/src/config/mod.rs

@@ -1951,7 +1951,7 @@ fn build_resolver(base_url: PathBuf, paths: CompiledPaths) -> Box<SwcImportResol
 
     let r = {
         let r = TsConfigResolver::new(
-            NodeModulesResolver::new(Default::default(), Default::default(), true),
+            NodeModulesResolver::without_node_modules(Default::default(), Default::default(), true),
             base_url.clone(),
             paths.clone(),
         );

crates/swc/src/lib.rs

@@ -193,7 +193,7 @@ pub mod resolver {
         preserve_symlinks: bool,
     ) -> CachingResolver<TsConfigResolver<NodeModulesResolver>> {
         let r = TsConfigResolver::new(
-            NodeModulesResolver::new(target_env, alias, preserve_symlinks),
+            NodeModulesResolver::without_node_modules(target_env, alias, preserve_symlinks),
             base_url,
             paths,
         );

crates/swc/tests/fixture/issues-7xxx/7863/1/input/.swcrc

@@ -0,0 +1,15 @@
+{
+    "jsc": {
+        "parser": {
+            "syntax": "typescript",
+            "tsx": true
+        },
+        "baseUrl": ".",
+        "paths": {
+            "~/*": [
+                "./src/*"
+            ]
+        },
+        "externalHelpers": true
+    }
+}

crates/swc/tests/fixture/issues-7xxx/7863/1/input/1.js

@@ -0,0 +1,7 @@
+import test from '~/util/test';
+
+class X {
+
+}
+
+console.log(test, X);

crates/swc/tests/fixture/issues-7xxx/7863/1/output/1.js

@@ -0,0 +1,7 @@
+import { _ as _class_call_check } from "@swc/helpers/_/_class_call_check";
+import test from "./src/util/test";
+var X = function X() {
+    "use strict";
+    _class_call_check(this, X);
+};
+console.log(test, X);

crates/swc_ecma_loader/src/resolvers/node.rs

@@ -103,6 +103,7 @@ pub struct NodeModulesResolver {
     alias: AHashMap<String, String>,
     // if true do not resolve symlink
     preserve_symlinks: bool,
+    ignore_node_modules: bool,
 }
 
 static EXTENSIONS: &[&str] = &["ts", "tsx", "js", "jsx", "json", "node"];
@@ -118,6 +119,21 @@ impl NodeModulesResolver {
             target_env,
             alias,
             preserve_symlinks,
+            ignore_node_modules: false,
+        }
+    }
+
+    /// Create a node modules resolver which does not care about `node_modules`
+    pub fn without_node_modules(
+        target_env: TargetEnv,
+        alias: AHashMap<String, String>,
+        preserve_symlinks: bool,
+    ) -> Self {
+        Self {
+            target_env,
+            alias,
+            preserve_symlinks,
+            ignore_node_modules: true,
         }
     }
 
@@ -369,6 +385,10 @@ impl NodeModulesResolver {
         base_dir: &Path,
         target: &str,
     ) -> Result<Option<PathBuf>, Error> {
+        if self.ignore_node_modules {
+            return Ok(None);
+        }
+
         let absolute_path = to_absolute_path(base_dir)?;
         let mut path = Some(&*absolute_path);
         while let Some(dir) = path {

crates/swc_ecma_loader/src/resolvers/tsc.rs

@@ -119,6 +119,20 @@ where
                     "Resolved `{}` as `{}` from `{}`",
                     module_specifier, resolved, base
                 );
+
+                if let FileName::Real(target) = &resolved {
+                    // If node_modules is in path, we should return module specifier.
+                    if target.components().any(|c| {
+                        if let Component::Normal(v) = c {
+                            v == "node_modules"
+                        } else {
+                            false
+                        }
+                    }) {
+                        return Ok(FileName::Real(module_specifier.into()));
+                    }
+                }
+
                 Ok(resolved)
             }
 

node-swc/__tests__/transform/issue_4730_test.mjs

@@ -37,7 +37,7 @@ it("should work", async () => {
         Object.defineProperty(exports, \\"__esModule\\", {
             value: true
         });
-        const _interop_require_wildcard = require(\\"node_modules/@swc/helpers/esm/_interop_require_wildcard\\");
+        const _interop_require_wildcard = require(\\"@swc/helpers/_/_interop_require_wildcard\\");
         const _b = require(\\"../packages/b/src\\");
         async function display() {
             const displayA = await Promise.resolve().then(()=>/*#__PURE__*/ _interop_require_wildcard._(require(\\"../packages/a/src\\"))).then((c)=>c.displayA);