fix(es/resolver): Change order for switch cases (#6317)

**Related issue:** - Closes #6310.
swc-project · Nov 2, 2022 · 2737aea · 2737aea · github-actions · Nov 2, 2022
1 parent fffc5f2
commit 2737aea
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/.../swc/tests/exec/issues-6xxx/.6311/exec.js → ...s/swc/tests/exec/issues-6xxx/6311/exec.js b/.../swc/tests/exec/issues-6xxx/.6311/exec.js → ...s/swc/tests/exec/issues-6xxx/6311/exec.js
diff --git a/crates/swc_ecma_transforms_base/src/resolver/mod.rs b/crates/swc_ecma_transforms_base/src/resolver/mod.rs
@@ -1112,6 +1112,12 @@ impl<'a> VisitMut for Resolver<'a> {
         });
     }
 
+    fn visit_mut_switch_case(&mut self, n: &mut SwitchCase) {
+        n.cons.visit_mut_with(self);
+
+        n.test.visit_mut_with(self);
+    }
+
     fn visit_mut_ts_as_expr(&mut self, n: &mut TsAsExpr) {
         if self.config.handle_types {
             n.type_ann.visit_mut_with(self);

diff --git a/crates/swc_ecma_transforms_base/tests/resolver/issues/6310/input.js b/crates/swc_ecma_transforms_base/tests/resolver/issues/6310/input.js
@@ -0,0 +1 @@
+switch (0) { case x: function x() { } }
diff --git a/crates/swc_ecma_transforms_base/tests/resolver/issues/6310/output.js b/crates/swc_ecma_transforms_base/tests/resolver/issues/6310/output.js
@@ -0,0 +1,4 @@
+switch(0){
+    case x__1:
+        function x__1() {}
+}
Benchmark suite	Current: `2737aea`	Previous: `e34c25e`	Ratio
`es/full/bugs-1`	`353682` ns/iter (`± 23519`)	`366521` ns/iter (`± 32501`)	`0.96`
`es/full/minify/libraries/antd`	`1939757282` ns/iter (`± 50021895`)	`1954466534` ns/iter (`± 43523773`)	`0.99`
`es/full/minify/libraries/d3`	`419624659` ns/iter (`± 23822985`)	`455549624` ns/iter (`± 38743280`)	`0.92`
`es/full/minify/libraries/echarts`	`1592733200` ns/iter (`± 88535513`)	`1713781129` ns/iter (`± 95023533`)	`0.93`
`es/full/minify/libraries/jquery`	`103697231` ns/iter (`± 6628479`)	`106065578` ns/iter (`± 6166821`)	`0.98`
`es/full/minify/libraries/lodash`	`122071652` ns/iter (`± 5889791`)	`143199691` ns/iter (`± 24811843`)	`0.85`
`es/full/minify/libraries/moment`	`62895002` ns/iter (`± 2511622`)	`64300761` ns/iter (`± 4490976`)	`0.98`
`es/full/minify/libraries/react`	`21570184` ns/iter (`± 8901686`)	`21787184` ns/iter (`± 969348`)	`0.99`
`es/full/minify/libraries/terser`	`311011952` ns/iter (`± 14934588`)	`332798757` ns/iter (`± 34261794`)	`0.93`
`es/full/minify/libraries/three`	`563732952` ns/iter (`± 6877651`)	`592007046` ns/iter (`± 144895518`)	`0.95`
`es/full/minify/libraries/typescript`	`3689396279` ns/iter (`± 336874729`)	`3923219982` ns/iter (`± 278840018`)	`0.94`
`es/full/minify/libraries/victory`	`912363674` ns/iter (`± 75254368`)	`958819906` ns/iter (`± 102452178`)	`0.95`
`es/full/minify/libraries/vue`	`191608548` ns/iter (`± 7041524`)	`198729804` ns/iter (`± 15533892`)	`0.96`
`es/full/codegen/es3`	`34951` ns/iter (`± 1407`)	`37213` ns/iter (`± 5097`)	`0.94`
`es/full/codegen/es5`	`34669` ns/iter (`± 1726`)	`47987` ns/iter (`± 11497`)	`0.72`
`es/full/codegen/es2015`	`34764` ns/iter (`± 1271`)	`38453` ns/iter (`± 6049`)	`0.90`
`es/full/codegen/es2016`	`34737` ns/iter (`± 1158`)	`35859` ns/iter (`± 5632`)	`0.97`
`es/full/codegen/es2017`	`34649` ns/iter (`± 1196`)	`39893` ns/iter (`± 6391`)	`0.87`
`es/full/codegen/es2018`	`34600` ns/iter (`± 1431`)	`36664` ns/iter (`± 5596`)	`0.94`
`es/full/codegen/es2019`	`34995` ns/iter (`± 2708`)	`42159` ns/iter (`± 7404`)	`0.83`
`es/full/codegen/es2020`	`35117` ns/iter (`± 2651`)	`38688` ns/iter (`± 5437`)	`0.91`
`es/full/all/es3`	`241016104` ns/iter (`± 71777957`)	`218309029` ns/iter (`± 25205889`)	`1.10`
`es/full/all/es5`	`230549496` ns/iter (`± 25229261`)	`222890509` ns/iter (`± 25952827`)	`1.03`
`es/full/all/es2015`	`182910275` ns/iter (`± 25055488`)	`181236059` ns/iter (`± 20910298`)	`1.01`
`es/full/all/es2016`	`178276558` ns/iter (`± 20386501`)	`176584553` ns/iter (`± 19102039`)	`1.01`
`es/full/all/es2017`	`176756431` ns/iter (`± 19396437`)	`182724886` ns/iter (`± 33442858`)	`0.97`
`es/full/all/es2018`	`176246874` ns/iter (`± 23315036`)	`186314996` ns/iter (`± 28588169`)	`0.95`
`es/full/all/es2019`	`175271554` ns/iter (`± 23613916`)	`189905465` ns/iter (`± 19854746`)	`0.92`
`es/full/all/es2020`	`169450303` ns/iter (`± 22312734`)	`177082083` ns/iter (`± 32242714`)	`0.96`
`es/full/parser`	`807970` ns/iter (`± 134583`)	`912711` ns/iter (`± 117531`)	`0.89`
`es/full/base/fixer`	`27568` ns/iter (`± 999`)	`32579` ns/iter (`± 6175`)	`0.85`
`es/full/base/resolver_and_hygiene`	`97884` ns/iter (`± 10085`)	`102282` ns/iter (`± 20043`)	`0.96`
`serialization of ast node`	`220` ns/iter (`± 8`)	`243` ns/iter (`± 52`)	`0.91`
`serialization of serde`	`224` ns/iter (`± 17`)	`239` ns/iter (`± 48`)	`0.94`