build: Update rustc to nightly-2024-07-21 (#9319)

Author: kdy1

.changeset/small-lobsters-happen.md

@@ -0,0 +1,30 @@
+---
+binding_macros: patch
+dbg-swc: patch
+swc: patch
+swc_bundler: patch
+swc_common: patch
+swc_core: patch
+swc_css_codegen: patch
+swc_css_compat: patch
+swc_css_minifier: patch
+swc_ecma_ast: patch
+swc_ecma_codegen: patch
+swc_ecma_codegen_macros: patch
+swc_ecma_lints: patch
+swc_ecma_minifier: patch
+swc_ecma_transforms_base: patch
+swc_ecma_transforms_module: patch
+swc_ecma_transforms_testing: patch
+swc_ecma_transforms_typescript: patch
+swc_ecma_usage_analyzer: patch
+swc_fast_graph: patch
+swc_html_codegen: patch
+swc_html_minifier: patch
+swc_html_parser: patch
+swc_macros_common: patch
+swc_visit: patch
+testing: patch
+---
+
+build: Update `rustc` to `nightly-2024-07-21`

Cargo.lock

@@ -74,7 +74,7 @@ impl CheckSizeCommand {
             println!(
                 "{}: {} bytes (swc) vs {} bytes (terser)",
                 file.path
-                    .strip_prefix(&self.workspace.join("inputs"))
+                    .strip_prefix(self.workspace.join("inputs"))
                     .unwrap()
                     .display(),
                 file.swc,
@@ -92,7 +92,7 @@ impl CheckSizeCommand {
                 format!(
                     "{}: Diff: {} bytes; {} bytes (swc) vs {} bytes (terser)",
                     f.path
-                        .strip_prefix(&self.workspace.join("inputs"))
+                        .strip_prefix(self.workspace.join("inputs"))
                         .unwrap()
                         .display(),
                     f.swc as i32 - f.terser as i32,

crates/binding_macros/build.rs

@@ -62,7 +62,7 @@ fn files_group(c: &mut Criterion) {
     group.sample_size(10);
 
     let mut bench_file = |name: &str| {
-        group.bench_function(&format!("es/full/minify/libraries/{name}"), |b| {
+        group.bench_function(format!("es/full/minify/libraries/{name}"), |b| {
             bench_minify(b, &format!("{}.js", name));
         });
     };

crates/dbg-swc/src/es/minifier/next/check_size.rs

@@ -15,9 +15,6 @@ mod computed_key;
 mod merge;
 mod plan;
 
-#[derive(Debug, Default)]
-struct State {}
-
 impl<L, R> Bundler<'_, L, R>
 where
     L: Load,

crates/swc/benches/minify.rs

@@ -1,5 +1,3 @@
-#![cfg_attr(not(feature = "serde-impl"), allow(unused))]
-
 use ast_node::ast_node;
 use codspeed_criterion_compat::{black_box, criterion_group, criterion_main, Criterion};
 use serde::{Deserialize, Serialize};
@@ -65,32 +63,5 @@ fn bench_serde(c: &mut Criterion) {
     });
 }
 
-fn bench_ast_node(c: &mut Criterion) {
-    #[cfg(feature = "serde-impl")]
-    c.bench_function("serialization of ast node", |b| {
-        let src = AstNode::String(Str {
-            span: DUMMY_SP,
-            value: String::from("perf-diff"),
-        });
-
-        b.iter(|| black_box(serde_json::to_string(&src).unwrap()));
-    });
-    #[cfg(feature = "serde-impl")]
-    c.bench_function("deserialization of ast node", |b| {
-        let src = serde_json::to_string(&AstNode::String(Str {
-            span: DUMMY_SP,
-            value: String::from("perf-diff"),
-        }))
-        .unwrap();
-        println!("{}", src);
-
-        b.iter(|| {
-            let t: AstNode = serde_json::from_str(&src).unwrap();
-
-            black_box(t);
-        });
-    });
-}
-
-criterion_group!(benches, bench_ast_node, bench_serde);
+criterion_group!(benches, bench_serde);
 criterion_main!(benches);

crates/swc_bundler/src/bundler/chunk/mod.rs

@@ -390,4 +390,5 @@ swc_plugin_runner = { optional = true, version = "0.111.0", path = "../swc_plugi
 vergen = { workspace = true, features = ["cargo"] }
 
 [dev-dependencies]
-anyhow = { workspace = true }
+anyhow  = { workspace = true }
+testing = { version = "0.38.0", path = "../testing" }

crates/swc_common/benches/serde.rs

@@ -9,7 +9,7 @@ use vergen::EmitBuilder;
 
 // Validate conflict between host / plugin features
 #[cfg(all(
-    feature = "plugin_transform",
+    feature = "ecma_plugin_transform",
     any(
         feature = "plugin_transform_host_native",
         feature = "plugin_transform_host_js"
@@ -21,15 +21,6 @@ compile_error!(
      run plugin, use 'plugin_transform_host_*' instead."
 );
 
-#[cfg(all(feature = "__plugin_transform", feature = "common_concurrent"))]
-compile_error!("plugin transform cannot enable concurrent mode.");
-
-#[cfg(all(feature = "transforms", feature = "transforms_concurrent"))]
-compile_error!(
-    "'transforms' and 'transforms_concurrent' features are mutually exclusive. Please choose only \
-     one feature."
-);
-
 fn main() {
     // Creates a static compile time constants for the version of swc_core.
     let pkg_version = env::var("CARGO_PKG_VERSION").unwrap();

crates/swc_core/Cargo.toml

@@ -32,7 +32,7 @@ pub extern crate swc_ecma_quote_macros;
 )]
 pub mod plugin;
 
-#[cfg(feature = "preset_env")]
+#[cfg(feature = "ecma_preset_env")]
 #[cfg_attr(docsrs, doc(cfg(feature = "preset_env")))]
 pub mod preset_env {
     pub use preset_env_base::*;

crates/swc_core/build.rs

@@ -1,13 +1,13 @@
-#[cfg(feature = "quote")]
-use swc_core::{ast::Ident, common::DUMMY_SP, quote, quote_expr, utils::private_ident};
+#[cfg(feature = "ecma_quote")]
+use swc_core::{common::DUMMY_SP, ecma::ast::Ident, ecma::utils::private_ident, quote, quote_expr};
 
-#[cfg(feature = "quote")]
+#[cfg(feature = "ecma_quote")]
 #[test]
 fn quote_expr_call_1() {
     let _expr = quote_expr!("call(arg1, typeof arg2, arg3)");
 }
 
-#[cfg(feature = "quote")]
+#[cfg(feature = "ecma_quote")]
 #[test]
 fn quote_expr_var_cloned() {
     testing::run_test2(false, |_cm, _handler| {
@@ -20,31 +20,31 @@ fn quote_expr_var_cloned() {
     .unwrap();
 }
 
-#[cfg(feature = "quote")]
+#[cfg(feature = "ecma_quote")]
 #[test]
 fn quote_example() {
     let _stmt = quote!(
         "const $name = 4;" as Stmt,
-        name = Ident::new("ref".into(), DUMMY_SP)
+        name = Ident::new("ref".into(), DUMMY_SP, Default::default())
     );
 }
 
-#[cfg(feature = "quote")]
+#[cfg(feature = "ecma_quote")]
 #[test]
 fn quote_var_type_expr() {
     let _stmt = quote!(
         "const $name = $val;" as Stmt,
-        name = Ident::new("ref".into(), DUMMY_SP),
+        name = Ident::new("ref".into(), DUMMY_SP, Default::default()),
         val: Expr = 4.into(),
     );
 }
 
-#[cfg(feature = "quote")]
+#[cfg(feature = "ecma_quote")]
 #[test]
 fn quote_var_type_pat() {
     let _stmt = quote!(
         "const $name = $val;" as Stmt,
-        name: Pat = Ident::new("ref".into(), DUMMY_SP).into(),
-        val: Ident = Ident::new("val".into(), DUMMY_SP),
+        name: Pat = Ident::new("ref".into(), DUMMY_SP, Default::default()).into(),
+        val: Ident = Ident::new("val".into(), DUMMY_SP, Default::default()),
     );
 }

crates/swc_core/src/lib.rs

@@ -2792,7 +2792,7 @@ fn serialize_dimension_unit(value: &str) -> Cow<'_, str> {
     // Fast-path
     let need_escape =
         (value.len() >= 2 && value.as_bytes()[0] == b'e' && value.as_bytes()[1].is_ascii_digit())
-            || value.contains(|c| c == char::REPLACEMENT_CHARACTER);
+            || value.contains(char::REPLACEMENT_CHARACTER);
 
     if !need_escape {
         return Cow::Borrowed(value);

crates/swc_core/tests/quote.rs

@@ -255,7 +255,7 @@ impl CustomMediaHandler {
                             Some((query.modifier.clone(), query.media_type.clone()));
                     }
 
-                    for condition in &query.condition {
+                    if let Some(condition) = &query.condition {
                         match &**condition {
                             MediaConditionType::All(media_condition) => {
                                 if new_media_condition.conditions.is_empty() {

crates/swc_css_codegen/src/lib.rs

@@ -489,5 +489,5 @@ impl VisitMut for Compressor {
 }
 
 fn contains_only_ascii_characters(string: &str) -> bool {
-    string.chars().all(|c: char| c.is_ascii())
+    string.is_ascii()
 }

crates/swc_css_compat/src/compiler/custom_media.rs

@@ -22,7 +22,7 @@ pub struct Class {
 
     pub ctxt: SyntaxContext,
 
-    #[cfg_attr(c, serde(default))]
+    #[cfg_attr(feature = "serde-impl", serde(default))]
     pub decorators: Vec<Decorator>,
 
     #[cfg_attr(feature = "serde-impl", serde(default))]

crates/swc_css_minifier/src/compressor/mod.rs

@@ -3908,7 +3908,7 @@ fn get_template_element_from_raw(s: &str, ascii_only: bool) -> String {
 }
 
 fn get_ascii_only_ident(sym: &str, may_need_quote: bool, target: EsVersion) -> Cow<str> {
-    if sym.chars().all(|c| c.is_ascii()) {
+    if sym.is_ascii() {
         return Cow::Borrowed(sym);
     }
 

crates/swc_ecma_ast/src/class.rs

@@ -12,23 +12,6 @@ pub(crate) struct InjectSelf {
     pub parser: Option<Ident>,
 }
 
-#[cfg(procmacro2_semver_exempt)]
-fn get_joined_span(t: &dyn ToTokens) -> Span {
-    let tts: TokenStream = t.dump().into();
-    let (mut first, mut last) = (None, None);
-    for tt in tts {
-        match first {
-            None => first = Some(tt.span()),
-            _ => {}
-        }
-
-        last = Some(tt.span());
-    }
-    let cs = Span::call_site();
-    first.unwrap_or(cs).join(last.unwrap_or(cs)).unwrap_or(cs)
-}
-
-#[cfg(not(procmacro2_semver_exempt))]
 fn get_joined_span(t: &dyn ToTokens) -> Span {
     let tts: TokenStream = t.into_token_stream();
     let mut first = None;

crates/swc_ecma_codegen/src/lib.rs

@@ -420,11 +420,8 @@ fn emit_error(name: &str, span: Span, prev_span: Span) {
                 span,
                 &format!("the name `{}` is defined multiple times", name),
             )
-            .span_label(
-                prev_span,
-                &format!("previous definition of `{}` here", name),
-            )
-            .span_label(span, &format!("`{}` redefined here", name))
+            .span_label(prev_span, format!("previous definition of `{}` here", name))
+            .span_label(span, format!("`{}` redefined here", name))
             .emit();
     });
 }

crates/swc_ecma_codegen_macros/src/fold.rs

@@ -25,7 +25,7 @@ fn error(first: &BindingIdent, second: &BindingIdent) {
                 ),
             )
             .span_label(first.span, "previous definition here".to_string())
-            .span_label(second.span, &"used as parameter more than once".to_string())
+            .span_label(second.span, "used as parameter more than once".to_string())
             .emit();
     });
 }

crates/swc_ecma_lints/src/rules/duplicate_bindings.rs

@@ -23,7 +23,7 @@ pub fn bench_files(c: &mut Criterion) {
     let mut bench_file = |name: &str| {
         let src = read_to_string(format!("benches/full/{}.js", name)).unwrap();
 
-        group.bench_function(&format!("es/minifier/libs/{}", name), |b| {
+        group.bench_function(format!("es/minifier/libs/{}", name), |b| {
             b.iter(|| {
                 // We benchmark full time, including time for creating cm, handler
                 let allocator = Allocator::default();

crates/swc_ecma_lints/src/rules/no_dupe_args.rs

@@ -13,11 +13,8 @@ impl Pure<'_> {
         if !self.options.props {
             return None;
         }
-        if let Some(obj) = obj {
-            match obj {
-                Expr::Array(..) | Expr::Await(..) | Expr::Yield(..) | Expr::Lit(..) => return None,
-                _ => {}
-            }
+        if let Some(Expr::Array(..) | Expr::Await(..) | Expr::Yield(..) | Expr::Lit(..)) = obj {
+            return None;
         }
 
         match &*c.expr {

crates/swc_ecma_minifier/benches/full.rs

@@ -9,6 +9,7 @@ use crate::HEAVY_TASK_PARALLELS;
 /// Optimizer invoked before invoking compressor.
 ///
 /// - Remove parens.
+///
 /// TODO: remove completely after #8333
 pub(crate) fn precompress_optimizer<'a>() -> impl 'a + VisitMut {
     PrecompressOptimizer {}

crates/swc_ecma_minifier/src/compress/pure/properties.rs

@@ -60,12 +60,12 @@ const LOG: bool = false && cfg!(debug_assertions);
 /// 3. Defined `a` with syntax context of the block statement.
 ///
 /// 4. Found usage of `a`, and determines that it's reference to `a` in the
-/// block. So the reference to `a` will have same syntax context as `a` in the
-/// block.
+///    block. So the reference to `a` will have same syntax context as `a` in
+///    the block.
 ///
-/// 5. Found usage of `a` (last line), and determines that it's a
-/// reference to top-level `a`, and change syntax context of `a` on last line to
-/// top-level syntax context.
+/// 5. Found usage of `a` (last line), and determines that it's a reference to
+///    top-level `a`, and change syntax context of `a` on last line to top-level
+///    syntax context.
 ///
 ///
 /// # Parameters

crates/swc_ecma_minifier/src/pass/precompress.rs

@@ -30,3 +30,9 @@ impl Parallel for ExampleFold {
 
 #[parallel]
 impl Fold for ExampleFold {}
+
+#[test]
+fn test() {
+    let _ = ExampleFold;
+    let _ = ExampleVisitMut;
+}

crates/swc_ecma_transforms_base/src/resolver/mod.rs

@@ -42,3 +42,10 @@ impl ParExplode for ExampleFold {
 
 #[parallel(explode)]
 impl Fold for ExampleFold {}
+
+#[test]
+fn test_1() {
+    let _ = ExampleFold;
+
+    let _ = ExampleVisitMut;
+}

crates/swc_ecma_transforms_base/tests/par.rs

@@ -232,15 +232,6 @@ pub(super) fn use_strict() -> Stmt {
     Lit::Str(quote_str!("use strict")).into_stmt()
 }
 
-/// Private `_exports` ident.
-pub(super) struct Exports(#[allow(dead_code)] pub Ident);
-
-impl Default for Exports {
-    fn default() -> Self {
-        Exports(private_ident!("_exports"))
-    }
-}
-
 pub(crate) fn object_define_enumerable(
     target: ExprOrSpread,
     prop_name: ExprOrSpread,

crates/swc_ecma_transforms_base/tests/par_explode.rs

@@ -659,7 +659,7 @@ fn exec_with_node_test_runner(src: &str) -> Result<(), ()> {
     };
 
     let output = base_cmd
-        .arg(&format!("{}", path.display()))
+        .arg(format!("{}", path.display()))
         .arg("--color")
         .current_dir(root)
         .output()

crates/swc_ecma_transforms_module/src/util.rs

@@ -42,8 +42,9 @@ pub struct TsxConfig {
 
 #[derive(Default, Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)]
 pub enum TsImportExportAssignConfig {
-    /// - Rewrite `import foo = require("foo")` to `var foo = require("foo")`
-    /// - Rewrite `export =` to `module.exports = `
+    ///  - Rewrite `import foo = require("foo")` to `var foo = require("foo")`
+    ///  - Rewrite `export =` to `module.exports = `
+    ///
     /// Note: This option is deprecated as all CJS/AMD/UMD can handle it
     /// themselves.
     #[default]

crates/swc_ecma_transforms_testing/src/lib.rs

@@ -18,8 +18,9 @@ bench = false
 
 [features]
 # This enables global concurrent mode
-concurrent = ["swc_common/concurrent", "indexmap/rayon"]
-trace-ast  = []
+concurrent    = ["swc_common/concurrent", "indexmap/rayon"]
+trace-ast     = []
+tracing-spans = []
 
 [dependencies]
 indexmap   = { workspace = true }

crates/swc_ecma_transforms_typescript/src/config.rs

@@ -47,13 +47,13 @@ pub type FastDiGraphMap<N, E> = FastGraphMap<N, E, Directed>;
 ///
 /// - Associated data `N` for nodes and `E` for edges, called *weights*.
 /// - The node weight `N` must implement `Copy` and will be used as node
-/// identifier, duplicated into several places in the data structure.
-/// It must be suitable as a hash table key (implementing `Eq + Hash`).
-/// The node type must also implement `Ord` so that the implementation can
-/// order the pair (`a`, `b`) for an edge connecting any two nodes `a` and `b`.
+///   identifier, duplicated into several places in the data structure. It must
+///   be suitable as a hash table key (implementing `Eq + Hash`). The node type
+///   must also implement `Ord` so that the implementation can order the pair
+///   (`a`, `b`) for an edge connecting any two nodes `a` and `b`.
 /// - `E` can be of arbitrary type.
 /// - Edge type `Ty` that determines whether the graph edges are directed or
-/// undirected.
+///   undirected.
 ///
 /// You can use the type aliases `UnGraphMap` and `DiGraphMap` for convenience.
 ///
@@ -418,7 +418,7 @@ where
     ///
     /// 1. Note that node and edge indices in the `Graph` have nothing in common
     ///    with the `GraphMap`s node weights `N`. The node weights `N` are used
-    /// as    node weights in the resulting `Graph`, too.
+    ///    as node weights in the resulting `Graph`, too.
     /// 2. Note that the index type is user-chosen.
     ///
     /// Computes in **O(|V| + |E|)** time (average).

crates/swc_ecma_usage_analyzer/Cargo.toml

@@ -620,8 +620,9 @@ where
                         None => true,
                         _ => false,
                     },
-                    // 	The closing tag can be omitted if it is immediately followed by a <rb>, <rtc>
-                    // or <rt> element opening tag or by its parent closing tag.
+                    // 	The closing tag can be omitted if it is immediately followed by a <rb>,
+                    // <rtc> or <rt> element opening tag or by its parent
+                    // closing tag.
                     "rtc" => match next {
                         Some(Child::Element(Element {
                             namespace,

crates/swc_ecma_usage_analyzer/src/analyzer/mod.rs

@@ -2108,7 +2108,7 @@ impl Minifier<'_> {
 
     fn minify_sizes(&self, value: &str) -> Option<String> {
         let values = value
-            .rsplitn(2, |c| matches!(c, '\t' | '\n' | '\x0C' | '\r' | ' '))
+            .rsplitn(2, ['\t', '\n', '\x0C', '\r', ' '])
             .collect::<Vec<&str>>();
 
         if values.len() != 2 {

crates/swc_fast_graph/src/digraph.rs

@@ -63,7 +63,7 @@ fn html5lib_test_tokenizer(input: PathBuf) {
     let filename = input.to_str().expect("failed to parse path");
     let contents = fs::read_to_string(filename).expect("Something went wrong reading the file");
     let obj: Value = serde_json::from_str(&contents).expect("json parse error");
-    let tests = match obj.get(&"tests".to_string()) {
+    let tests = match obj.get("tests".to_string()) {
         Some(Value::Array(tests)) => tests,
         _ => return,
     };

crates/swc_html_codegen/src/lib.rs

@@ -2,8 +2,6 @@
 
 extern crate proc_macro;
 
-#[cfg(procmacro2_semver_exempt)]
-use pmutil::SpanExt;
 use proc_macro2::{Span, TokenStream};
 use quote::ToTokens;
 use syn::{punctuated::Pair, *};
@@ -17,18 +15,10 @@ pub fn call_site() -> Span {
     Span::call_site()
 }
 
-/// `Span::def_site().located_at(Span::call_site())`
-#[cfg(not(procmacro2_semver_exempt))]
 pub fn def_site() -> Span {
     call_site()
 }
 
-/// `Span::def_site().located_at(Span::call_site())`
-#[cfg(procmacro2_semver_exempt)]
-pub fn def_site() -> Span {
-    Span::def_site().located_at(Span::call_site())
-}
-
 /// `attr` - tokens inside `#[]`. e.g. `derive(EqIgnoreSpan)`, ast_node
 pub fn print(attr: &'static str, tokens: proc_macro2::TokenStream) -> proc_macro::TokenStream {
     use std::env;

crates/swc_html_minifier/src/lib.rs

@@ -18,7 +18,7 @@
 //! # `Fold`
 //!
 //! > WARNING: `Fold` is slow, and it's recommended to use VisitMut if you are
-//! experienced.
+//! > experienced.
 //!
 //!
 //! `Fold` takes ownership of value, which means you have to return the new

crates/swc_html_parser/tests/html5lib_tests.rs

@@ -35,7 +35,7 @@ pub struct Diff {
 ///
 /// - The `CARGO_MANIFEST_DIR` directory is replaced with `$DIR`.
 /// - All backslashes (\) within same line as `$DIR` are converted to forward
-/// slashes (/) (for Windows) - All CR LF newlines are converted to LF
+///   slashes (/) (for Windows) - All CR LF newlines are converted to LF
 ///
 /// - `normalize-stdout` is not implemented (yet?).
 #[derive(Clone, Ord, PartialOrd, PartialEq, Eq, Default, Hash)]

crates/swc_macros_common/src/lib.rs

@@ -1 +1 @@
-nightly-2024-04-16
+nightly-2024-07-21