Skip to content

Commit 30a4e52

Browse files
authoredApr 15, 2023
fix(es/helpers): Do not duplicate property names (#7266)
**Related issue:** - Closes #7264.
1 parent cfc53fe commit 30a4e52

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed
 

‎packages/swc-helpers/scripts/build.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,12 @@ modules.forEach((p) => {
6767
});
6868

6969
indexCJS.push(
70-
`module.exports = {`,
71-
"/* @Annotate start: the CommonJS named exports for ESM import in node */",
70+
`0 && (module.exports = {`,
71+
"/* @Annotate_start: the CommonJS named exports for ESM import in node */",
7272
...cjs_module_lexer,
73-
"/* @Annotate end */",
73+
"/* @Annotate_end */",
74+
`});`,
75+
`module.exports = {`,
7476
...cjs_export_list,
7577
`};`,
7678
);

1 commit comments

Comments
 (1)

github-actions[bot] commented on Apr 15, 2023

@github-actions[bot]

Benchmark

Benchmark suite Current: 30a4e52 Previous: 219a738 Ratio
es/full/bugs-1 318734 ns/iter (± 10711) 304403 ns/iter (± 13604) 1.05
es/full/minify/libraries/antd 1557678996 ns/iter (± 14502795) 1715397201 ns/iter (± 52660990) 0.91
es/full/minify/libraries/d3 302375678 ns/iter (± 6104096) 303205229 ns/iter (± 11401382) 1.00
es/full/minify/libraries/echarts 1216967762 ns/iter (± 16864761) 1253251574 ns/iter (± 23722406) 0.97
es/full/minify/libraries/jquery 90410940 ns/iter (± 845417) 92085659 ns/iter (± 2915833) 0.98
es/full/minify/libraries/lodash 105897590 ns/iter (± 739005) 108115859 ns/iter (± 2785229) 0.98
es/full/minify/libraries/moment 52384515 ns/iter (± 624900) 53494670 ns/iter (± 600044) 0.98
es/full/minify/libraries/react 19025904 ns/iter (± 125508) 19246595 ns/iter (± 309687) 0.99
es/full/minify/libraries/terser 245306612 ns/iter (± 6251135) 248582338 ns/iter (± 2888778) 0.99
es/full/minify/libraries/three 432628477 ns/iter (± 5673225) 452888437 ns/iter (± 10798276) 0.96
es/full/minify/libraries/typescript 2901933540 ns/iter (± 30722016) 3148207308 ns/iter (± 41975054) 0.92
es/full/minify/libraries/victory 660289677 ns/iter (± 13331898) 702215914 ns/iter (± 12606552) 0.94
es/full/minify/libraries/vue 128950923 ns/iter (± 861482) 131447906 ns/iter (± 2481055) 0.98
es/full/codegen/es3 28539 ns/iter (± 65) 28509 ns/iter (± 58) 1.00
es/full/codegen/es5 28650 ns/iter (± 58) 28580 ns/iter (± 60) 1.00
es/full/codegen/es2015 28621 ns/iter (± 50) 28680 ns/iter (± 90) 1.00
es/full/codegen/es2016 28682 ns/iter (± 44) 28645 ns/iter (± 57) 1.00
es/full/codegen/es2017 28663 ns/iter (± 61) 28635 ns/iter (± 79) 1.00
es/full/codegen/es2018 28631 ns/iter (± 44) 28564 ns/iter (± 40) 1.00
es/full/codegen/es2019 28621 ns/iter (± 50) 28594 ns/iter (± 58) 1.00
es/full/codegen/es2020 28618 ns/iter (± 55) 28613 ns/iter (± 51) 1.00
es/full/all/es3 180761677 ns/iter (± 2272422) 183518087 ns/iter (± 5591848) 0.98
es/full/all/es5 171092554 ns/iter (± 2571707) 177489629 ns/iter (± 3702949) 0.96
es/full/all/es2015 133355852 ns/iter (± 1971466) 136458754 ns/iter (± 3441632) 0.98
es/full/all/es2016 132049608 ns/iter (± 824507) 134983857 ns/iter (± 3034810) 0.98
es/full/all/es2017 130428010 ns/iter (± 2153821) 133221278 ns/iter (± 885721) 0.98
es/full/all/es2018 125051035 ns/iter (± 542832) 131971157 ns/iter (± 4371243) 0.95
es/full/all/es2019 123666756 ns/iter (± 2040530) 127114369 ns/iter (± 4513031) 0.97
es/full/all/es2020 117145636 ns/iter (± 760332) 120027050 ns/iter (± 2615648) 0.98
es/full/parser 514313 ns/iter (± 7651) 516625 ns/iter (± 9934) 1.00
es/full/base/fixer 22632 ns/iter (± 22) 22573 ns/iter (± 28) 1.00
es/full/base/resolver_and_hygiene 84151 ns/iter (± 56) 84348 ns/iter (± 140) 1.00
serialization of serde 123 ns/iter (± 0) 122 ns/iter (± 0) 1.01
css/minify/libraries/bootstrap 27825423 ns/iter (± 377793) 27449725 ns/iter (± 179998) 1.01
css/visitor/compare/clone 2134440 ns/iter (± 7399) 2116103 ns/iter (± 27169) 1.01
css/visitor/compare/visit_mut_span 2313673 ns/iter (± 7062) 2325107 ns/iter (± 3573) 1.00
css/visitor/compare/visit_mut_span_panic 2397123 ns/iter (± 2377) 2363610 ns/iter (± 4777) 1.01
css/visitor/compare/fold_span 3091878 ns/iter (± 11645) 3125298 ns/iter (± 16595) 0.99
css/visitor/compare/fold_span_panic 3256315 ns/iter (± 17017) 3280943 ns/iter (± 16277) 0.99
css/lexer/bootstrap_5_1_3 5121025 ns/iter (± 3989) 5134322 ns/iter (± 12649) 1.00
css/lexer/foundation_6_7_4 4313635 ns/iter (± 26534) 4414890 ns/iter (± 2107) 0.98
css/lexer/tailwind_3_1_1 821406 ns/iter (± 421) 837224 ns/iter (± 211) 0.98
css/parser/bootstrap_5_1_3 21058037 ns/iter (± 98552) 21308638 ns/iter (± 178557) 0.99
css/parser/foundation_6_7_4 16865273 ns/iter (± 81420) 16870170 ns/iter (± 98322) 1.00
css/parser/tailwind_3_1_1 3241238 ns/iter (± 2887) 3252479 ns/iter (± 5640) 1.00
es/codegen/colors 326057 ns/iter (± 185041) 326413 ns/iter (± 184990) 1.00
es/codegen/large 1250754 ns/iter (± 648901) 1113776 ns/iter (± 569241) 1.12
es/codegen/with-parser/colors 46802 ns/iter (± 128) 47471 ns/iter (± 434) 0.99
es/codegen/with-parser/large 511040 ns/iter (± 1877) 510434 ns/iter (± 1846) 1.00
es/minify/libraries/antd 1375369934 ns/iter (± 34420213) 1470634416 ns/iter (± 32323302) 0.94
es/minify/libraries/d3 261171172 ns/iter (± 2564561) 260442750 ns/iter (± 7399988) 1.00
es/minify/libraries/echarts 1049744831 ns/iter (± 12039235) 1127737087 ns/iter (± 22720789) 0.93
es/minify/libraries/jquery 78953245 ns/iter (± 573800) 81534027 ns/iter (± 1236927) 0.97
es/minify/libraries/lodash 94911306 ns/iter (± 992860) 97212907 ns/iter (± 4660848) 0.98
es/minify/libraries/moment 45686394 ns/iter (± 429475) 47007755 ns/iter (± 851896) 0.97
es/minify/libraries/react 17026472 ns/iter (± 167423) 17209424 ns/iter (± 543406) 0.99
es/minify/libraries/terser 211898577 ns/iter (± 3542230) 213087624 ns/iter (± 3736852) 0.99
es/minify/libraries/three 361903532 ns/iter (± 6855693) 383325972 ns/iter (± 7495348) 0.94
es/minify/libraries/typescript 2505324500 ns/iter (± 16311497) 2663447715 ns/iter (± 32842749) 0.94
es/minify/libraries/victory 548092099 ns/iter (± 9856627) 605799574 ns/iter (± 20455318) 0.90
es/minify/libraries/vue 115719599 ns/iter (± 1360357) 121162511 ns/iter (± 5768101) 0.96
es/visitor/compare/clone 2363737 ns/iter (± 26786) 2357856 ns/iter (± 6927) 1.00
es/visitor/compare/visit_mut_span 2733583 ns/iter (± 4717) 2759521 ns/iter (± 35648) 0.99
es/visitor/compare/visit_mut_span_panic 2776607 ns/iter (± 4679) 2806750 ns/iter (± 13344) 0.99
es/visitor/compare/fold_span 3868948 ns/iter (± 13796) 3875346 ns/iter (± 18961) 1.00
es/visitor/compare/fold_span_panic 3969442 ns/iter (± 14571) 3996697 ns/iter (± 7122) 0.99
es/lexer/colors 13155 ns/iter (± 7) 13103 ns/iter (± 53) 1.00
es/lexer/angular 6404382 ns/iter (± 7841) 6367540 ns/iter (± 2206) 1.01
es/lexer/backbone 790845 ns/iter (± 226) 787696 ns/iter (± 575) 1.00
es/lexer/jquery 4411521 ns/iter (± 1772) 4397574 ns/iter (± 1979) 1.00
es/lexer/jquery mobile 6888728 ns/iter (± 9910) 6873729 ns/iter (± 1774) 1.00
es/lexer/mootools 3462608 ns/iter (± 864) 3462725 ns/iter (± 2218) 1.00
es/lexer/underscore 650436 ns/iter (± 375) 650337 ns/iter (± 608) 1.00
es/lexer/three 20862894 ns/iter (± 27381) 20808541 ns/iter (± 13563) 1.00
es/lexer/yui 3858744 ns/iter (± 560) 3852800 ns/iter (± 2109) 1.00
es/parser/colors 29514 ns/iter (± 75) 29314 ns/iter (± 67) 1.01
es/parser/angular 15270362 ns/iter (± 228051) 15394396 ns/iter (± 236542) 0.99
es/parser/backbone 2172542 ns/iter (± 9974) 2175014 ns/iter (± 17469) 1.00
es/parser/jquery 11809512 ns/iter (± 124137) 11911283 ns/iter (± 157510) 0.99
es/parser/jquery mobile 18854186 ns/iter (± 284677) 18772172 ns/iter (± 302477) 1.00
es/parser/mootools 9016286 ns/iter (± 33742) 8951062 ns/iter (± 28050) 1.01
es/parser/underscore 1838948 ns/iter (± 11731) 1834395 ns/iter (± 13496) 1.00
es/parser/three 54301996 ns/iter (± 287996) 55150067 ns/iter (± 507064) 0.98
es/parser/yui 9130057 ns/iter (± 65478) 9170221 ns/iter (± 75467) 1.00
es/preset-env/usage/builtin_type 140456 ns/iter (± 34226) 142581 ns/iter (± 34594) 0.99
es/preset-env/usage/property 20302 ns/iter (± 76) 20334 ns/iter (± 78) 1.00
es/resolver/typescript 110749035 ns/iter (± 1604661) 121745395 ns/iter (± 2445803) 0.91
es/fixer/typescript 77111119 ns/iter (± 648678) 87968382 ns/iter (± 1053889) 0.88
es/hygiene/typescript 167138605 ns/iter (± 2249656) 189680981 ns/iter (± 2234691) 0.88
es/resolver_with_hygiene/typescript 304429997 ns/iter (± 2930902) 333395480 ns/iter (± 6456515) 0.91
es/visitor/base-perf/module_clone 81370 ns/iter (± 510) 80440 ns/iter (± 383) 1.01
es/visitor/base-perf/fold_empty 90894 ns/iter (± 373) 90538 ns/iter (± 479) 1.00
es/visitor/base-perf/fold_noop_impl_all 91238 ns/iter (± 444) 91203 ns/iter (± 208) 1.00
es/visitor/base-perf/fold_noop_impl_vec 91464 ns/iter (± 970) 90989 ns/iter (± 393) 1.01
es/visitor/base-perf/boxing_boxed_clone 58 ns/iter (± 0) 56 ns/iter (± 0) 1.04
es/visitor/base-perf/boxing_unboxed_clone 42 ns/iter (± 0) 41 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_boxed 102 ns/iter (± 0) 102 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed 79 ns/iter (± 0) 79 ns/iter (± 0) 1
es/visitor/base-perf/visit_contains_this 3559 ns/iter (± 55) 3522 ns/iter (± 99) 1.01
es/base/parallel/resolver/typescript 6347514521 ns/iter (± 545344832) 6251617113 ns/iter (± 483526036) 1.02
es/base/parallel/hygiene/typescript 2014202135 ns/iter (± 38000782) 2215962388 ns/iter (± 25535503) 0.91
misc/visitors/time-complexity/time 5 102 ns/iter (± 0) 102 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 315 ns/iter (± 0) 317 ns/iter (± 6) 0.99
misc/visitors/time-complexity/time 15 642 ns/iter (± 7) 643 ns/iter (± 0) 1.00
misc/visitors/time-complexity/time 20 1198 ns/iter (± 0) 1198 ns/iter (± 1) 1
misc/visitors/time-complexity/time 40 6613 ns/iter (± 64) 6700 ns/iter (± 104) 0.99
misc/visitors/time-complexity/time 60 16869 ns/iter (± 55) 16905 ns/iter (± 36) 1.00
es/full-target/es2016 254075 ns/iter (± 428) 253128 ns/iter (± 1759) 1.00
es/full-target/es2017 246031 ns/iter (± 581) 246766 ns/iter (± 288) 1.00
es/full-target/es2018 235525 ns/iter (± 404) 235879 ns/iter (± 414) 1.00
es2020_nullish_coalescing 92871 ns/iter (± 392) 93704 ns/iter (± 365) 0.99
es2020_optional_chaining 124066 ns/iter (± 216) 124742 ns/iter (± 236) 0.99
es2022_class_properties 149503 ns/iter (± 311) 149281 ns/iter (± 380) 1.00
es2018_object_rest_spread 96398 ns/iter (± 197) 96440 ns/iter (± 264) 1.00
es2019_optional_catch_binding 85554 ns/iter (± 270) 85869 ns/iter (± 206) 1.00
es2017_async_to_generator 86113 ns/iter (± 231) 86467 ns/iter (± 250) 1.00
es2016_exponentiation 90297 ns/iter (± 316) 90561 ns/iter (± 207) 1.00
es2015_arrow 94906 ns/iter (± 175) 94423 ns/iter (± 235) 1.01
es2015_block_scoped_fn 92186 ns/iter (± 333) 92480 ns/iter (± 197) 1.00
es2015_block_scoping 169736 ns/iter (± 174) 169984 ns/iter (± 334) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.