fix(es/minifier): Fix removal of array pattern bindings (#8730)

**Related issue:**

 - Closes #8670

Author: kdy1

crates/swc_ecma_minifier/src/compress/optimize/unused.rs

@@ -345,25 +345,22 @@ impl Optimizer<'_> {
             }
 
             Pat::Array(arr) => {
-                for (idx, elem) in arr.elems.iter_mut().enumerate() {
-                    match elem {
+                for (idx, arr_elem) in arr.elems.iter_mut().enumerate() {
+                    match arr_elem {
                         Some(p) => {
-                            if p.is_ident() {
-                                continue;
-                            }
-
                             let elem = init
                                 .as_mut()
                                 .and_then(|expr| self.access_numeric_property(expr, idx));
 
                             self.take_pat_if_unused(p, elem, is_var_decl);
+
+                            if p.is_invalid() {
+                                *arr_elem = None;
+                            }
                         }
                         None => {}
                     }
                 }
-
-                arr.elems
-                    .retain(|elem| !matches!(elem, Some(Pat::Invalid(..))))
             }
 
             Pat::Object(obj) => {

crates/swc_ecma_minifier/tests/TODO.txt

@@ -184,7 +184,6 @@ harmony/issue_2874_2/input.js
 harmony/module_enabled/input.js
 harmony/module_mangle_scope/input.js
 harmony/regression_cannot_use_of/input.js
-hoist_props/contains_this_3/input.js
 hoist_props/hoist_function_with_call/input.js
 if_return/if_return_same_value/input.js
 if_return/if_var_return/input.js

crates/swc_ecma_minifier/tests/fixture/issues/8670/config.json

@@ -0,0 +1,5 @@
+{
+    "defaults": true,
+    "pure_getters": true,
+    "toplevel": true
+}

crates/swc_ecma_minifier/tests/fixture/issues/8670/input.js

@@ -0,0 +1,2 @@
+const [a, b, c, d, e] = [1, 2, 3, 4, 5]
+console.log(c)

crates/swc_ecma_minifier/tests/fixture/issues/8670/output.js

@@ -0,0 +1,8 @@
+const [, , c, , ] = [
+    1,
+    2,
+    3,
+    4,
+    5
+];
+console.log(c);

crates/swc_ecma_minifier/tests/passing.txt

@@ -739,6 +739,7 @@ hoist/hoist_no_destructurings/input.js
 hoist/hoist_vars/input.js
 hoist_props/contains_this_1/input.js
 hoist_props/contains_this_2/input.js
+hoist_props/contains_this_3/input.js
 hoist_props/direct_access_1/input.js
 hoist_props/direct_access_2/input.js
 hoist_props/direct_access_3/input.js

crates/swc_ecma_minifier/tests/terser/compress/destructuring/unused_destructuring_declaration_complex_1/output.js

@@ -1,2 +1,10 @@
-const [, w, , x, { z: z }] = [1, 2, 3, 4, { z: 5 }];
+const [, , , x, { z: z }] = [
+    1,
+    2,
+    3,
+    4,
+    {
+        z: 5
+    }
+];
 console.log(x, z);