Skip to content

Commit 38dfb91

Browse files
magic-akarimagic-akari
authoredApr 20, 2023
fix(es/helpers): Remove unnecessary parameters in helper_expr! macro (#7296)
**Description:** We have moved to snake_case, so the last parameter of helper_expr is unnecessary.
·
v1.11.13swc_core@v0.106.1
1 parent af8e158 commit 38dfb91

File tree

77 files changed

+870
-415
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

77 files changed

+870
-415
lines changed
 

‎crates/swc_ecma_transforms/tests/fixture/legacy-metadata/constructor/param/output.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
class Foo {
22
constructor(p: string, readonly p2: string){}
33
}
4-
Foo = __decorate([
5-
__param(0, dec1()),
6-
__param(1, dec2()),
7-
__metadata("design:type", Function),
8-
__metadata("design:paramtypes", [
4+
Foo = _ts_decorate([
5+
_ts_param(0, dec1()),
6+
_ts_param(1, dec2()),
7+
_ts_metadata("design:type", Function),
8+
_ts_metadata("design:paramtypes", [
99
String,
1010
String
1111
])

‎crates/swc_ecma_transforms/tests/fixture/legacy-metadata/issues/1160/1/output.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ enum MyEnum {
55
class Xpto {
66
value: MyEnum;
77
}
8-
__decorate([
8+
_ts_decorate([
99
Decorator(),
10-
__metadata("design:type", String)
10+
_ts_metadata("design:type", String)
1111
], Xpto.prototype, "value", void 0);
1212
function Decorator() {
1313
return function(...args) {};

1 commit comments

Comments
 (1)

github-actions[bot] commented on Apr 20, 2023

@github-actions[bot]
github-actions[bot]
on Apr 20, 2023

Benchmark

Benchmark suite Current: 38dfb91 Previous: 9c279b8 Ratio
es/full/bugs-1 298279 ns/iter (± 9991) 301372 ns/iter (± 7669) 0.99
es/full/minify/libraries/antd 1534083898 ns/iter (± 20446537) 1504896574 ns/iter (± 16025877) 1.02
es/full/minify/libraries/d3 289060609 ns/iter (± 10202538) 285858633 ns/iter (± 3232302) 1.01
es/full/minify/libraries/echarts 1165437835 ns/iter (± 8170371) 1152585236 ns/iter (± 4969001) 1.01
es/full/minify/libraries/jquery 88320589 ns/iter (± 564086) 88890276 ns/iter (± 560419) 0.99
es/full/minify/libraries/lodash 103822733 ns/iter (± 1661689) 103507649 ns/iter (± 1045614) 1.00
es/full/minify/libraries/moment 51198616 ns/iter (± 194662) 51206855 ns/iter (± 391063) 1.00
es/full/minify/libraries/react 18709241 ns/iter (± 99244) 18767607 ns/iter (± 102185) 1.00
es/full/minify/libraries/terser 235141899 ns/iter (± 1245353) 235463647 ns/iter (± 2008085) 1.00
es/full/minify/libraries/three 412244127 ns/iter (± 6883682) 414066352 ns/iter (± 4195046) 1.00
es/full/minify/libraries/typescript 2976749544 ns/iter (± 25324039) 2843474241 ns/iter (± 11196852) 1.05
es/full/minify/libraries/victory 623606744 ns/iter (± 7912537) 637755500 ns/iter (± 12337827) 0.98
es/full/minify/libraries/vue 127361115 ns/iter (± 1025080) 126622399 ns/iter (± 811512) 1.01
es/full/codegen/es3 28594 ns/iter (± 91) 28449 ns/iter (± 158) 1.01
es/full/codegen/es5 28661 ns/iter (± 54) 28607 ns/iter (± 52) 1.00
es/full/codegen/es2015 28747 ns/iter (± 53) 28469 ns/iter (± 89) 1.01
es/full/codegen/es2016 28909 ns/iter (± 73) 28386 ns/iter (± 91) 1.02
es/full/codegen/es2017 28732 ns/iter (± 61) 28537 ns/iter (± 122) 1.01
es/full/codegen/es2018 28698 ns/iter (± 38) 28492 ns/iter (± 75) 1.01
es/full/codegen/es2019 28670 ns/iter (± 70) 28465 ns/iter (± 62) 1.01
es/full/codegen/es2020 28758 ns/iter (± 56) 28348 ns/iter (± 96) 1.01
es/full/all/es3 178683643 ns/iter (± 3422031) 181748029 ns/iter (± 3709162) 0.98
es/full/all/es5 172722538 ns/iter (± 3181931) 174780137 ns/iter (± 1142007) 0.99
es/full/all/es2015 133888125 ns/iter (± 2413088) 136043919 ns/iter (± 1989460) 0.98
es/full/all/es2016 131542078 ns/iter (± 2244203) 132893912 ns/iter (± 1940780) 0.99
es/full/all/es2017 128411347 ns/iter (± 2537422) 131980746 ns/iter (± 1726767) 0.97
es/full/all/es2018 123284759 ns/iter (± 1768432) 125411374 ns/iter (± 1707918) 0.98
es/full/all/es2019 123102931 ns/iter (± 1196529) 123985315 ns/iter (± 1309122) 0.99
es/full/all/es2020 117315507 ns/iter (± 716057) 118012828 ns/iter (± 668535) 0.99
es/full/parser 514035 ns/iter (± 7365) 512936 ns/iter (± 7329) 1.00
es/full/base/fixer 22652 ns/iter (± 38) 22437 ns/iter (± 68) 1.01
es/full/base/resolver_and_hygiene 84829 ns/iter (± 117) 90004 ns/iter (± 907) 0.94
serialization of serde 121 ns/iter (± 0) 121 ns/iter (± 0) 1
css/minify/libraries/bootstrap 27483456 ns/iter (± 174856) 27475765 ns/iter (± 154403) 1.00
css/visitor/compare/clone 2080626 ns/iter (± 20615) 2092262 ns/iter (± 4654) 0.99
css/visitor/compare/visit_mut_span 2284422 ns/iter (± 6036) 2253541 ns/iter (± 14192) 1.01
css/visitor/compare/visit_mut_span_panic 2327553 ns/iter (± 3261) 2340322 ns/iter (± 6580) 0.99
css/visitor/compare/fold_span 3064957 ns/iter (± 8315) 3072295 ns/iter (± 10649) 1.00
css/visitor/compare/fold_span_panic 3218484 ns/iter (± 13690) 3199423 ns/iter (± 22373) 1.01
css/lexer/bootstrap_5_1_3 5246767 ns/iter (± 47363) 5177687 ns/iter (± 42924) 1.01
css/lexer/foundation_6_7_4 4406064 ns/iter (± 1513) 4329455 ns/iter (± 10812) 1.02
css/lexer/tailwind_3_1_1 837266 ns/iter (± 129) 818789 ns/iter (± 2729) 1.02
css/parser/bootstrap_5_1_3 20770941 ns/iter (± 22791) 20723836 ns/iter (± 86670) 1.00
css/parser/foundation_6_7_4 16617985 ns/iter (± 19433) 16511370 ns/iter (± 60321) 1.01
css/parser/tailwind_3_1_1 3210361 ns/iter (± 2829) 3200146 ns/iter (± 13993) 1.00
es/codegen/colors 703631 ns/iter (± 411170) 703767 ns/iter (± 411382) 1.00
es/codegen/large 2638776 ns/iter (± 1602308) 2634887 ns/iter (± 1594830) 1.00
es/codegen/with-parser/colors 46711 ns/iter (± 427) 47169 ns/iter (± 323) 0.99
es/codegen/with-parser/large 504372 ns/iter (± 843) 508113 ns/iter (± 1385) 0.99
es/minify/libraries/antd 1298772633 ns/iter (± 10969841) 1314861374 ns/iter (± 15740217) 0.99
es/minify/libraries/d3 242341486 ns/iter (± 2356921) 248632970 ns/iter (± 2908502) 0.97
es/minify/libraries/echarts 1003473459 ns/iter (± 18434252) 1026988010 ns/iter (± 10512951) 0.98
es/minify/libraries/jquery 77193297 ns/iter (± 455007) 78007890 ns/iter (± 518425) 0.99
es/minify/libraries/lodash 92582252 ns/iter (± 681698) 92549467 ns/iter (± 1538291) 1.00
es/minify/libraries/moment 44834038 ns/iter (± 224801) 45059891 ns/iter (± 296262) 0.99
es/minify/libraries/react 16724326 ns/iter (± 88713) 16678661 ns/iter (± 56867) 1.00
es/minify/libraries/terser 200056620 ns/iter (± 1156055) 201611004 ns/iter (± 1742844) 0.99
es/minify/libraries/three 339398099 ns/iter (± 2446002) 340446688 ns/iter (± 2364810) 1.00
es/minify/libraries/typescript 2579827482 ns/iter (± 44118684) 2427057714 ns/iter (± 9354601) 1.06
es/minify/libraries/victory 519655114 ns/iter (± 7025543) 513214267 ns/iter (± 9662357) 1.01
es/minify/libraries/vue 112685354 ns/iter (± 1965751) 112606061 ns/iter (± 998314) 1.00
es/visitor/compare/clone 2319355 ns/iter (± 17660) 2310983 ns/iter (± 7716) 1.00
es/visitor/compare/visit_mut_span 2687335 ns/iter (± 20206) 2690630 ns/iter (± 9378) 1.00
es/visitor/compare/visit_mut_span_panic 2725976 ns/iter (± 3018) 2725577 ns/iter (± 8834) 1.00
es/visitor/compare/fold_span 3817770 ns/iter (± 9278) 3798679 ns/iter (± 13643) 1.01
es/visitor/compare/fold_span_panic 3947598 ns/iter (± 6428) 3920975 ns/iter (± 8806) 1.01
es/lexer/colors 13125 ns/iter (± 36) 13230 ns/iter (± 129) 0.99
es/lexer/angular 6384677 ns/iter (± 1578) 6375625 ns/iter (± 18691) 1.00
es/lexer/backbone 789769 ns/iter (± 801) 787492 ns/iter (± 1341) 1.00
es/lexer/jquery 4420996 ns/iter (± 1260) 4420906 ns/iter (± 25042) 1.00
es/lexer/jquery mobile 6903710 ns/iter (± 2345) 6888008 ns/iter (± 13231) 1.00
es/lexer/mootools 3460913 ns/iter (± 1490) 3460667 ns/iter (± 8521) 1.00
es/lexer/underscore 653008 ns/iter (± 233) 653096 ns/iter (± 1372) 1.00
es/lexer/three 20916073 ns/iter (± 8258) 20921094 ns/iter (± 28457) 1.00
es/lexer/yui 3864179 ns/iter (± 1306) 3861913 ns/iter (± 10363) 1.00
es/parser/colors 28841 ns/iter (± 57) 29062 ns/iter (± 73) 0.99
es/parser/angular 14805227 ns/iter (± 118836) 14714089 ns/iter (± 104600) 1.01
es/parser/backbone 2158205 ns/iter (± 16838) 2168893 ns/iter (± 13242) 1.00
es/parser/jquery 11693772 ns/iter (± 83573) 11687592 ns/iter (± 95002) 1.00
es/parser/jquery mobile 18107379 ns/iter (± 125204) 18109002 ns/iter (± 166221) 1.00
es/parser/mootools 8924342 ns/iter (± 50143) 8899806 ns/iter (± 76731) 1.00
es/parser/underscore 1819754 ns/iter (± 12111) 1816797 ns/iter (± 11704) 1.00
es/parser/three 50752844 ns/iter (± 689251) 51634594 ns/iter (± 579936) 0.98
es/parser/yui 8989576 ns/iter (± 56515) 8972028 ns/iter (± 62935) 1.00
es/preset-env/usage/builtin_type 142343 ns/iter (± 35483) 141349 ns/iter (± 34594) 1.01
es/preset-env/usage/property 19951 ns/iter (± 91) 20095 ns/iter (± 76) 0.99
es/resolver/typescript 113583033 ns/iter (± 2137335) 109761118 ns/iter (± 1431020) 1.03
es/fixer/typescript 84433074 ns/iter (± 1136315) 78414146 ns/iter (± 618334) 1.08
es/hygiene/typescript 177013307 ns/iter (± 1162324) 165292234 ns/iter (± 706896) 1.07
es/resolver_with_hygiene/typescript 310487959 ns/iter (± 1168800) 294035709 ns/iter (± 3035082) 1.06
es/visitor/base-perf/module_clone 82150 ns/iter (± 578) 82291 ns/iter (± 534) 1.00
es/visitor/base-perf/fold_empty 91817 ns/iter (± 330) 91205 ns/iter (± 541) 1.01
es/visitor/base-perf/fold_noop_impl_all 91907 ns/iter (± 724) 91687 ns/iter (± 606) 1.00
es/visitor/base-perf/fold_noop_impl_vec 92367 ns/iter (± 441) 91887 ns/iter (± 425) 1.01
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 41 ns/iter (± 0) 41 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 103 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed 78 ns/iter (± 0) 78 ns/iter (± 0) 1
es/visitor/base-perf/visit_contains_this 3509 ns/iter (± 88) 3432 ns/iter (± 49) 1.02
es/base/parallel/resolver/typescript 6263251270 ns/iter (± 599749969) 6040209710 ns/iter (± 404916248) 1.04
es/base/parallel/hygiene/typescript 2138183003 ns/iter (± 21282347) 1986749997 ns/iter (± 15462771) 1.08
misc/visitors/time-complexity/time 5 102 ns/iter (± 0) 102 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 336 ns/iter (± 1) 338 ns/iter (± 6) 0.99
misc/visitors/time-complexity/time 15 656 ns/iter (± 4) 656 ns/iter (± 0) 1
misc/visitors/time-complexity/time 20 1219 ns/iter (± 1) 1219 ns/iter (± 0) 1
misc/visitors/time-complexity/time 40 6197 ns/iter (± 3) 5993 ns/iter (± 36) 1.03
misc/visitors/time-complexity/time 60 15560 ns/iter (± 19) 13312 ns/iter (± 36) 1.17
es/full-target/es2016 253764 ns/iter (± 1409) 253062 ns/iter (± 913) 1.00
es/full-target/es2017 246937 ns/iter (± 347) 246724 ns/iter (± 575) 1.00
es/full-target/es2018 235779 ns/iter (± 329) 235758 ns/iter (± 530) 1.00
es2020_nullish_coalescing 92871 ns/iter (± 365) 93086 ns/iter (± 496) 1.00
es2020_optional_chaining 124211 ns/iter (± 383) 125515 ns/iter (± 255) 0.99
es2022_class_properties 148386 ns/iter (± 327) 149775 ns/iter (± 474) 0.99
es2018_object_rest_spread 95842 ns/iter (± 261) 95821 ns/iter (± 223) 1.00
es2019_optional_catch_binding 85468 ns/iter (± 228) 85873 ns/iter (± 392) 1.00
es2017_async_to_generator 85755 ns/iter (± 234) 86255 ns/iter (± 124) 0.99
es2016_exponentiation 89954 ns/iter (± 205) 90263 ns/iter (± 179) 1.00
es2015_arrow 93914 ns/iter (± 192) 94368 ns/iter (± 228) 1.00
es2015_block_scoped_fn 91978 ns/iter (± 139) 92696 ns/iter (± 188) 0.99
es2015_block_scoping 169542 ns/iter (± 210) 169877 ns/iter (± 350) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.