Skip to content

Commit 3935d02

Browse files
authoredMay 30, 2023
fix(es/codegen): Emit ; for TsImportEqualsDecl (#7464)
1 parent 81a413b commit 3935d02

File tree

5 files changed

+10
-4
lines changed

5 files changed

+10
-4
lines changed
 

‎crates/swc_ecma_codegen/src/typescript.rs

+1
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,7 @@ where
295295
formatting_space!();
296296

297297
emit!(n.module_ref);
298+
formatting_semi!();
298299
}
299300

300301
#[emitter]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
import Test1 = MyNamespace.Test1;
2+
import Test2 = Test1;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
import Test1 = MyNamespace.Test1;
2+
import Test2 = Test1;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import Test1=MyNamespace.Test1;import Test2=Test1;

‎crates/swc_ecma_transforms_base/tests/ts-resolver/internalModules/codeGeneration/importStatements/output.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ module A__2 {
55
export var Origin__3 = new Point__3(0, 0);
66
}
77
module B__2 {
8-
import a__5 = A__2
8+
import a__5 = A__2;
99
}
1010
module C__2 {
11-
import a__6 = A__2
11+
import a__6 = A__2;
1212
var m__6: typeof a__6;
1313
var p__6: a__6.Point;
1414
var p__6 = {
@@ -17,11 +17,11 @@ module C__2 {
1717
};
1818
}
1919
module D__2 {
20-
import a__7 = A__2
20+
import a__7 = A__2;
2121
var p__7 = new a__7.Point(1, 1);
2222
}
2323
module E__2 {
24-
import a__8 = A__2
24+
import a__8 = A__2;
2525
export function xDist__8(x__9: a__8.Point) {
2626
return a__8.Origin.x - x__9.x;
2727
}

1 commit comments

Comments
 (1)

github-actions[bot] commented on May 30, 2023

@github-actions[bot]

Benchmark

Benchmark suite Current: 3935d02 Previous: 1868d36 Ratio
es/full/bugs-1 292006 ns/iter (± 16286) 315582 ns/iter (± 16686) 0.93
es/full/minify/libraries/antd 1526431888 ns/iter (± 36320634) 1513792805 ns/iter (± 14698328) 1.01
es/full/minify/libraries/d3 300234393 ns/iter (± 8298659) 297033745 ns/iter (± 5808591) 1.01
es/full/minify/libraries/echarts 1193520862 ns/iter (± 17778490) 1193170749 ns/iter (± 14666148) 1.00
es/full/minify/libraries/jquery 91642802 ns/iter (± 1386713) 91158843 ns/iter (± 1087618) 1.01
es/full/minify/libraries/lodash 106531794 ns/iter (± 755832) 105635477 ns/iter (± 1043736) 1.01
es/full/minify/libraries/moment 52911851 ns/iter (± 632620) 52200137 ns/iter (± 670732) 1.01
es/full/minify/libraries/react 19607274 ns/iter (± 1205445) 19315017 ns/iter (± 192629) 1.02
es/full/minify/libraries/terser 244276644 ns/iter (± 3486351) 239176590 ns/iter (± 1739454) 1.02
es/full/minify/libraries/three 427069518 ns/iter (± 8626008) 424683381 ns/iter (± 9196246) 1.01
es/full/minify/libraries/typescript 2951006785 ns/iter (± 11382460) 2887945353 ns/iter (± 29420438) 1.02
es/full/minify/libraries/victory 632161684 ns/iter (± 8598797) 641337085 ns/iter (± 14885664) 0.99
es/full/minify/libraries/vue 134591358 ns/iter (± 1527270) 130319038 ns/iter (± 1413043) 1.03
es/full/codegen/es3 34269 ns/iter (± 64) 33628 ns/iter (± 46) 1.02
es/full/codegen/es5 34308 ns/iter (± 74) 33652 ns/iter (± 117) 1.02
es/full/codegen/es2015 34151 ns/iter (± 111) 33585 ns/iter (± 146) 1.02
es/full/codegen/es2016 34157 ns/iter (± 118) 33419 ns/iter (± 143) 1.02
es/full/codegen/es2017 34143 ns/iter (± 83) 33535 ns/iter (± 107) 1.02
es/full/codegen/es2018 34221 ns/iter (± 100) 33477 ns/iter (± 119) 1.02
es/full/codegen/es2019 34188 ns/iter (± 79) 33551 ns/iter (± 137) 1.02
es/full/codegen/es2020 34141 ns/iter (± 55) 33503 ns/iter (± 91) 1.02
es/full/all/es3 181813040 ns/iter (± 3915646) 180801514 ns/iter (± 4127544) 1.01
es/full/all/es5 176601549 ns/iter (± 2961663) 173055413 ns/iter (± 1728994) 1.02
es/full/all/es2015 140079217 ns/iter (± 2837070) 135499173 ns/iter (± 1927177) 1.03
es/full/all/es2016 140551044 ns/iter (± 3014137) 134556997 ns/iter (± 3422735) 1.04
es/full/all/es2017 139284844 ns/iter (± 928172) 131508870 ns/iter (± 1883401) 1.06
es/full/all/es2018 134786025 ns/iter (± 2228785) 125206931 ns/iter (± 1986022) 1.08
es/full/all/es2019 129618913 ns/iter (± 2829477) 124828538 ns/iter (± 1569038) 1.04
es/full/all/es2020 120836876 ns/iter (± 1591102) 117871096 ns/iter (± 1150897) 1.03
es/full/parser 520250 ns/iter (± 6427) 515853 ns/iter (± 7893) 1.01
es/full/base/fixer 22518 ns/iter (± 83) 22352 ns/iter (± 105) 1.01
es/full/base/resolver_and_hygiene 85149 ns/iter (± 371) 86145 ns/iter (± 333) 0.99
serialization of serde 120 ns/iter (± 0) 121 ns/iter (± 0) 0.99
css/minify/libraries/bootstrap 26769161 ns/iter (± 103537) 27131570 ns/iter (± 141344) 0.99
css/visitor/compare/clone 2107453 ns/iter (± 32745) 2107250 ns/iter (± 4207) 1.00
css/visitor/compare/visit_mut_span 2286975 ns/iter (± 8084) 2297176 ns/iter (± 19622) 1.00
css/visitor/compare/visit_mut_span_panic 2362380 ns/iter (± 7757) 2327402 ns/iter (± 7565) 1.02
css/visitor/compare/fold_span 3100353 ns/iter (± 10917) 3044518 ns/iter (± 13259) 1.02
css/visitor/compare/fold_span_panic 3251871 ns/iter (± 20292) 3194469 ns/iter (± 20131) 1.02
css/lexer/bootstrap_5_1_3 5196515 ns/iter (± 15259) 5182534 ns/iter (± 20593) 1.00
css/lexer/foundation_6_7_4 4380970 ns/iter (± 18089) 4346634 ns/iter (± 17398) 1.01
css/lexer/tailwind_3_1_1 832301 ns/iter (± 3215) 825995 ns/iter (± 2833) 1.01
css/parser/bootstrap_5_1_3 21065690 ns/iter (± 69704) 21279242 ns/iter (± 141502) 0.99
css/parser/foundation_6_7_4 16746059 ns/iter (± 70893) 16966570 ns/iter (± 110011) 0.99
css/parser/tailwind_3_1_1 3226743 ns/iter (± 10519) 3245718 ns/iter (± 13769) 0.99
es/codegen/colors 745437 ns/iter (± 404031) 730626 ns/iter (± 392000) 1.02
es/codegen/large 3101997 ns/iter (± 1636565) 3111292 ns/iter (± 1643976) 1.00
es/codegen/with-parser/colors 48428 ns/iter (± 409) 48421 ns/iter (± 441) 1.00
es/codegen/with-parser/large 506004 ns/iter (± 2996) 508063 ns/iter (± 2200) 1.00
es/minify/libraries/antd 1346768345 ns/iter (± 44258052) 1336669905 ns/iter (± 21986847) 1.01
es/minify/libraries/d3 252583615 ns/iter (± 5230853) 254524417 ns/iter (± 2379393) 0.99
es/minify/libraries/echarts 1014977308 ns/iter (± 8997890) 1030180870 ns/iter (± 17445257) 0.99
es/minify/libraries/jquery 79992094 ns/iter (± 994755) 80205113 ns/iter (± 939503) 1.00
es/minify/libraries/lodash 96359814 ns/iter (± 900727) 96242016 ns/iter (± 1222678) 1.00
es/minify/libraries/moment 46881868 ns/iter (± 444644) 46641199 ns/iter (± 542205) 1.01
es/minify/libraries/react 17472613 ns/iter (± 268699) 17440862 ns/iter (± 113640) 1.00
es/minify/libraries/terser 209702931 ns/iter (± 2720003) 212729576 ns/iter (± 2178836) 0.99
es/minify/libraries/three 364654905 ns/iter (± 6422808) 367566103 ns/iter (± 7196697) 0.99
es/minify/libraries/typescript 2526189429 ns/iter (± 26732532) 2523112853 ns/iter (± 18337154) 1.00
es/minify/libraries/victory 537579077 ns/iter (± 11212312) 549536372 ns/iter (± 10908189) 0.98
es/minify/libraries/vue 118811187 ns/iter (± 1481103) 118591892 ns/iter (± 2127197) 1.00
es/visitor/compare/clone 2325077 ns/iter (± 11388) 2328085 ns/iter (± 17944) 1.00
es/visitor/compare/visit_mut_span 2691693 ns/iter (± 11785) 2705803 ns/iter (± 4829) 0.99
es/visitor/compare/visit_mut_span_panic 2720126 ns/iter (± 16475) 2732510 ns/iter (± 8330) 1.00
es/visitor/compare/fold_span 3786595 ns/iter (± 10767) 3803103 ns/iter (± 8002) 1.00
es/visitor/compare/fold_span_panic 3909745 ns/iter (± 15211) 3944602 ns/iter (± 8136) 0.99
es/lexer/colors 13168 ns/iter (± 45) 13307 ns/iter (± 31) 0.99
es/lexer/angular 6448402 ns/iter (± 33101) 6455216 ns/iter (± 177681) 1.00
es/lexer/backbone 798390 ns/iter (± 2993) 797474 ns/iter (± 835) 1.00
es/lexer/jquery 4491147 ns/iter (± 12850) 4490440 ns/iter (± 3510) 1.00
es/lexer/jquery mobile 6974104 ns/iter (± 21149) 6981448 ns/iter (± 5507) 1.00
es/lexer/mootools 3504011 ns/iter (± 22121) 3507922 ns/iter (± 6116) 1.00
es/lexer/underscore 656625 ns/iter (± 3240) 658049 ns/iter (± 907) 1.00
es/lexer/three 21068614 ns/iter (± 61628) 21099596 ns/iter (± 17873) 1.00
es/lexer/yui 3907942 ns/iter (± 12801) 3895110 ns/iter (± 4432) 1.00
es/parser/colors 28868 ns/iter (± 140) 28950 ns/iter (± 74) 1.00
es/parser/angular 15059237 ns/iter (± 85438) 15056340 ns/iter (± 90325) 1.00
es/parser/backbone 2186285 ns/iter (± 14846) 2176506 ns/iter (± 13295) 1.00
es/parser/jquery 11870705 ns/iter (± 145958) 11788996 ns/iter (± 153095) 1.01
es/parser/jquery mobile 18366607 ns/iter (± 165599) 18183781 ns/iter (± 142651) 1.01
es/parser/mootools 9032501 ns/iter (± 39387) 8997574 ns/iter (± 51835) 1.00
es/parser/underscore 1836924 ns/iter (± 8203) 1827953 ns/iter (± 15183) 1.00
es/parser/three 52462012 ns/iter (± 496318) 52507399 ns/iter (± 575439) 1.00
es/parser/yui 9154053 ns/iter (± 59083) 9102474 ns/iter (± 35151) 1.01
es/preset-env/usage/builtin_type 138313 ns/iter (± 34323) 138766 ns/iter (± 35078) 1.00
es/preset-env/usage/property 19956 ns/iter (± 108) 19988 ns/iter (± 129) 1.00
es/resolver/typescript 111552776 ns/iter (± 2489895) 112432589 ns/iter (± 1144377) 0.99
es/fixer/typescript 79015395 ns/iter (± 503425) 76863556 ns/iter (± 334036) 1.03
es/hygiene/typescript 164217715 ns/iter (± 875918) 168554263 ns/iter (± 2461470) 0.97
es/resolver_with_hygiene/typescript 296993695 ns/iter (± 2894820) 298609063 ns/iter (± 4787551) 0.99
es/visitor/base-perf/module_clone 81004 ns/iter (± 525) 81924 ns/iter (± 534) 0.99
es/visitor/base-perf/fold_empty 89944 ns/iter (± 526) 90857 ns/iter (± 375) 0.99
es/visitor/base-perf/fold_noop_impl_all 90434 ns/iter (± 765) 91109 ns/iter (± 867) 0.99
es/visitor/base-perf/fold_noop_impl_vec 91722 ns/iter (± 383) 91880 ns/iter (± 391) 1.00
es/visitor/base-perf/boxing_boxed_clone 59 ns/iter (± 0) 58 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_unboxed_clone 41 ns/iter (± 0) 40 ns/iter (± 0) 1.02
es/visitor/base-perf/boxing_boxed 103 ns/iter (± 0) 104 ns/iter (± 0) 0.99
es/visitor/base-perf/boxing_unboxed 78 ns/iter (± 0) 78 ns/iter (± 0) 1
es/visitor/base-perf/visit_contains_this 3516 ns/iter (± 41) 3434 ns/iter (± 78) 1.02
es/base/parallel/resolver/typescript 6589995015 ns/iter (± 564268415) 6415523598 ns/iter (± 432793552) 1.03
es/base/parallel/hygiene/typescript 1978825559 ns/iter (± 33928737) 1976875777 ns/iter (± 17711956) 1.00
misc/visitors/time-complexity/time 5 104 ns/iter (± 0) 104 ns/iter (± 0) 1
misc/visitors/time-complexity/time 10 333 ns/iter (± 5) 343 ns/iter (± 7) 0.97
misc/visitors/time-complexity/time 15 635 ns/iter (± 1) 638 ns/iter (± 2) 1.00
misc/visitors/time-complexity/time 20 1183 ns/iter (± 4) 1196 ns/iter (± 20) 0.99
misc/visitors/time-complexity/time 40 6719 ns/iter (± 111) 6734 ns/iter (± 39) 1.00
misc/visitors/time-complexity/time 60 16940 ns/iter (± 86) 16823 ns/iter (± 45) 1.01
es/full-target/es2016 252581 ns/iter (± 829) 252297 ns/iter (± 874) 1.00
es/full-target/es2017 244202 ns/iter (± 1454) 245156 ns/iter (± 588) 1.00
es/full-target/es2018 233475 ns/iter (± 784) 234466 ns/iter (± 862) 1.00
es2020_nullish_coalescing 92890 ns/iter (± 328) 93086 ns/iter (± 408) 1.00
es2020_optional_chaining 124123 ns/iter (± 766) 124622 ns/iter (± 335) 1.00
es2022_class_properties 148269 ns/iter (± 1481) 148805 ns/iter (± 299) 1.00
es2018_object_rest_spread 95742 ns/iter (± 548) 95779 ns/iter (± 237) 1.00
es2019_optional_catch_binding 84457 ns/iter (± 392) 84933 ns/iter (± 189) 0.99
es2017_async_to_generator 84874 ns/iter (± 282) 85801 ns/iter (± 255) 0.99
es2016_exponentiation 89684 ns/iter (± 939) 90139 ns/iter (± 243) 0.99
es2015_arrow 92925 ns/iter (± 436) 94267 ns/iter (± 297) 0.99
es2015_block_scoped_fn 91233 ns/iter (± 504) 92035 ns/iter (± 406) 0.99
es2015_block_scoping 168395 ns/iter (± 327) 169176 ns/iter (± 414) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.