Skip to content

Commit

Permalink
fix(common): Remove &mut from build_source_map_from (#6276)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jridgewell
jridgewell committed Oct 28, 2022
1 parent 111fb3a commit 47d7fca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions crates/swc/src/lib.rs
View file
Expand Up @@ -495,7 +495,7 @@ impl Compiler {

self.cm
.build_source_map_with_config(
&mut src_map_buf,
&src_map_buf,
orig,
SwcSourceMapConfig {
source_file_name,
Expand All @@ -520,7 +520,7 @@ impl Compiler {

self.cm
.build_source_map_with_config(
&mut src_map_buf,
&src_map_buf,
orig,
SwcSourceMapConfig {
source_file_name,
Expand Down
6 changes: 3 additions & 3 deletions crates/swc_common/src/source_map.rs
View file
Expand Up @@ -1139,7 +1139,7 @@ impl SourceMap {
///
#[cfg(feature = "sourcemap")]
#[cfg_attr(docsrs, doc(cfg(feature = "sourcemap")))]
pub fn build_source_map(&self, mappings: &mut Vec<(BytePos, LineCol)>) -> sourcemap::SourceMap {
pub fn build_source_map(&self, mappings: &[(BytePos, LineCol)]) -> sourcemap::SourceMap {
self.build_source_map_from(mappings, None)
}

Expand All @@ -1148,7 +1148,7 @@ impl SourceMap {
#[cfg_attr(docsrs, doc(cfg(feature = "sourcemap")))]
pub fn build_source_map_from(
&self,
mappings: &mut Vec<(BytePos, LineCol)>,
mappings: &[(BytePos, LineCol)],
orig: Option<&sourcemap::SourceMap>,
) -> sourcemap::SourceMap {
self.build_source_map_with_config(mappings, orig, DefaultSourceMapGenConfig)
Expand All @@ -1159,7 +1159,7 @@ impl SourceMap {
#[cfg_attr(docsrs, doc(cfg(feature = "sourcemap")))]
pub fn build_source_map_with_config(
&self,
mappings: &mut Vec<(BytePos, LineCol)>,
mappings: &[(BytePos, LineCol)],
orig: Option<&sourcemap::SourceMap>,
config: impl SourceMapGenConfig,
) -> sourcemap::SourceMap {
Expand Down

1 comment on commit 47d7fca

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 47d7fca Previous: cd1319d Ratio
es/full/bugs-1 422834 ns/iter (± 9314) 346200 ns/iter (± 42083) 1.22
es/full/minify/libraries/antd 2117587486 ns/iter (± 30025778) 1805642149 ns/iter (± 30935257) 1.17
es/full/minify/libraries/d3 436897321 ns/iter (± 6701703) 401356799 ns/iter (± 14852244) 1.09
es/full/minify/libraries/echarts 1803085905 ns/iter (± 26670189) 1526700370 ns/iter (± 232311206) 1.18
es/full/minify/libraries/jquery 117054659 ns/iter (± 2857828) 98047893 ns/iter (± 4075327) 1.19
es/full/minify/libraries/lodash 139036877 ns/iter (± 5653043) 120489251 ns/iter (± 3540810) 1.15
es/full/minify/libraries/moment 70168163 ns/iter (± 762921) 60304291 ns/iter (± 2730455) 1.16
es/full/minify/libraries/react 23961908 ns/iter (± 751109) 21684238 ns/iter (± 9976723) 1.11
es/full/minify/libraries/terser 327957864 ns/iter (± 7714803) 312157021 ns/iter (± 14167185) 1.05
es/full/minify/libraries/three 595485634 ns/iter (± 5443993) 562702087 ns/iter (± 20070923) 1.06
es/full/minify/libraries/typescript 3966903053 ns/iter (± 31507120) 3478694322 ns/iter (± 50013726) 1.14
es/full/minify/libraries/victory 902347064 ns/iter (± 26898522) 841698884 ns/iter (± 77937733) 1.07
es/full/minify/libraries/vue 175757596 ns/iter (± 4183269) 182475692 ns/iter (± 17918984) 0.96
es/full/codegen/es3 40484 ns/iter (± 1027) 35569 ns/iter (± 2763) 1.14
es/full/codegen/es5 40774 ns/iter (± 751) 35032 ns/iter (± 3067) 1.16
es/full/codegen/es2015 40773 ns/iter (± 1179) 34868 ns/iter (± 1322) 1.17
es/full/codegen/es2016 40764 ns/iter (± 840) 34937 ns/iter (± 1299) 1.17
es/full/codegen/es2017 40748 ns/iter (± 1260) 35118 ns/iter (± 2004) 1.16
es/full/codegen/es2018 40827 ns/iter (± 538) 35078 ns/iter (± 1872) 1.16
es/full/codegen/es2019 40790 ns/iter (± 931) 34867 ns/iter (± 2519) 1.17
es/full/codegen/es2020 40752 ns/iter (± 1072) 34951 ns/iter (± 3281) 1.17
es/full/all/es3 233077522 ns/iter (± 3281389) 232302316 ns/iter (± 19226786) 1.00
es/full/all/es5 219348161 ns/iter (± 4784940) 221754321 ns/iter (± 14723222) 0.99
es/full/all/es2015 177308360 ns/iter (± 2885609) 173135312 ns/iter (± 13768694) 1.02
es/full/all/es2016 175525647 ns/iter (± 4946368) 172025194 ns/iter (± 16974698) 1.02
es/full/all/es2017 176016690 ns/iter (± 4007006) 172960025 ns/iter (± 17061056) 1.02
es/full/all/es2018 174026883 ns/iter (± 2865738) 168162532 ns/iter (± 13130233) 1.03
es/full/all/es2019 173266700 ns/iter (± 5250737) 170274546 ns/iter (± 14900735) 1.02
es/full/all/es2020 167528772 ns/iter (± 5349121) 139988613 ns/iter (± 10123428) 1.20
es/full/parser 871919 ns/iter (± 21553) 757005 ns/iter (± 42197) 1.15
es/full/base/fixer 32100 ns/iter (± 632) 26957 ns/iter (± 2119) 1.19
es/full/base/resolver_and_hygiene 114006 ns/iter (± 4104) 93758 ns/iter (± 7819) 1.22
serialization of ast node 257 ns/iter (± 2) 223 ns/iter (± 29) 1.15
serialization of serde 259 ns/iter (± 10) 222 ns/iter (± 42) 1.17

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.