Skip to content

Commit 56bdacc

Browse files
authoredApr 10, 2023
feat(plugin/runner): Update wasmer to v3 (#7197)
**Description:** This PR reattempts #5456. Most of the changes are for the breaking changes of wasmer@3, as well as enabling rkyv's strict mode (#6922). This could not be seperated since wasmer@3 enables strict mode by default without a way to turn it off. There are a couple of changes worth noting: - Disabling in-memory module lookup: https://github.com/swc-project/swc/pull/7197/files#diff-3bda5def6ce2b7553c3b3a5ad241c0bdb7021e67b7de1e594df4cd5a54d403b3R154-R159 - Disabling plugin_runner in bindings_wasm: https://github.com/swc-project/swc/pull/7197/files#diff-dc3ded556a1fd709a129acd588e5eda651b842c6acc3f5340d40088a1f927facR310-R312 - Skipping plugin compat test: https://github.com/swc-project/swc/pull/7197/files#diff-531197dfcefba05faca53f0cf442ecc2dc6b59d5ead01979f5ffb912aa36249aR64-R66
1 parent e116fed commit 56bdacc

File tree

42 files changed

+2267
-1246
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+2267
-1246
lines changed
 

‎.github/workflows/CI.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ jobs:
232232
os: ubuntu-latest
233233
runner: ubuntu-latest
234234
check: |
235-
cargo hack check --feature-powerset --no-dev-deps --exclude-features debug --exclude-features plugin --exclude-features plugin_transform_schema_v1 --exclude-features plugin_transform_schema_vtest --exclude-features plugin-bytecheck
235+
cargo hack check --feature-powerset --no-dev-deps --exclude-features debug --exclude-features plugin --exclude-features plugin_transform_schema_v1 --exclude-features plugin_transform_schema_vtest --exclude-features plugin-bytecheck --exclude-features plugin_transform_host_js --exclude-features plugin_transform_host_native
236236
- crate: swc
237237
os: windows-latest
238238
runner: windows-latest

‎Cargo.lock

+1,060-364
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2 commit comments

Comments
 (2)

github-actions[bot] commented on Apr 10, 2023

@github-actions[bot]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 56bdacc Previous: e241201 Ratio
es/codegen/colors 693754 ns/iter (± 405049) 329525 ns/iter (± 186069) 2.11
es/codegen/large 2645885 ns/iter (± 1634029) 1252650 ns/iter (± 653667) 2.11

This comment was automatically generated by workflow using github-action-benchmark.

CC: @kdy1

github-actions[bot] commented on Apr 10, 2023

@github-actions[bot]

Benchmark

Benchmark suite Current: 56bdacc Previous: e241201 Ratio
es/full/bugs-1 311023 ns/iter (± 8972) 295107 ns/iter (± 9946) 1.05
es/full/minify/libraries/antd 1750067838 ns/iter (± 22267637) 1649223070 ns/iter (± 11915988) 1.06
es/full/minify/libraries/d3 325870684 ns/iter (± 2590853) 307763110 ns/iter (± 6575333) 1.06
es/full/minify/libraries/echarts 1338243757 ns/iter (± 19921351) 1246615507 ns/iter (± 8172888) 1.07
es/full/minify/libraries/jquery 95023365 ns/iter (± 1334582) 90529077 ns/iter (± 639674) 1.05
es/full/minify/libraries/lodash 109861637 ns/iter (± 1086289) 105221260 ns/iter (± 642443) 1.04
es/full/minify/libraries/moment 53802427 ns/iter (± 1063102) 51934984 ns/iter (± 559452) 1.04
es/full/minify/libraries/react 19666630 ns/iter (± 265729) 18905566 ns/iter (± 107184) 1.04
es/full/minify/libraries/terser 277719898 ns/iter (± 6525924) 247870358 ns/iter (± 3258659) 1.12
es/full/minify/libraries/three 498820534 ns/iter (± 7119137) 441230156 ns/iter (± 6485807) 1.13
es/full/minify/libraries/typescript 3250263206 ns/iter (± 24959199) 3072410090 ns/iter (± 23163494) 1.06
es/full/minify/libraries/victory 763577255 ns/iter (± 15969611) 687539762 ns/iter (± 13532918) 1.11
es/full/minify/libraries/vue 140971120 ns/iter (± 1938994) 130496452 ns/iter (± 1026917) 1.08
es/full/codegen/es3 29673 ns/iter (± 148) 28613 ns/iter (± 53) 1.04
es/full/codegen/es5 29835 ns/iter (± 72) 28749 ns/iter (± 360) 1.04
es/full/codegen/es2015 29794 ns/iter (± 135) 28661 ns/iter (± 93) 1.04
es/full/codegen/es2016 29819 ns/iter (± 123) 28635 ns/iter (± 84) 1.04
es/full/codegen/es2017 29868 ns/iter (± 132) 28590 ns/iter (± 82) 1.04
es/full/codegen/es2018 29699 ns/iter (± 195) 28607 ns/iter (± 72) 1.04
es/full/codegen/es2019 29783 ns/iter (± 142) 28599 ns/iter (± 64) 1.04
es/full/codegen/es2020 29847 ns/iter (± 135) 28592 ns/iter (± 62) 1.04
es/full/all/es3 188612410 ns/iter (± 2882692) 181797807 ns/iter (± 2676385) 1.04
es/full/all/es5 177604613 ns/iter (± 1739069) 169182372 ns/iter (± 1687254) 1.05
es/full/all/es2015 140768850 ns/iter (± 3202764) 133587826 ns/iter (± 1532827) 1.05
es/full/all/es2016 137048629 ns/iter (± 2254024) 130833549 ns/iter (± 2246676) 1.05
es/full/all/es2017 135597428 ns/iter (± 2473329) 129113536 ns/iter (± 2213784) 1.05
es/full/all/es2018 132803169 ns/iter (± 2582648) 125716218 ns/iter (± 1043317) 1.06
es/full/all/es2019 131367118 ns/iter (± 1979207) 122901907 ns/iter (± 843796) 1.07
es/full/all/es2020 121061507 ns/iter (± 1012591) 117150363 ns/iter (± 777790) 1.03
es/full/parser 525904 ns/iter (± 10684) 519229 ns/iter (± 6877) 1.01
es/full/base/fixer 23192 ns/iter (± 55) 22410 ns/iter (± 29) 1.03
es/full/base/resolver_and_hygiene 85344 ns/iter (± 193) 87665 ns/iter (± 305) 0.97
serialization of serde 126 ns/iter (± 1) 126 ns/iter (± 0) 1
css/minify/libraries/bootstrap 29034612 ns/iter (± 294964) 27541333 ns/iter (± 114262) 1.05
css/visitor/compare/clone 2142228 ns/iter (± 16879) 2107950 ns/iter (± 4340) 1.02
css/visitor/compare/visit_mut_span 2344539 ns/iter (± 10131) 2280234 ns/iter (± 7290) 1.03
css/visitor/compare/visit_mut_span_panic 2403419 ns/iter (± 9164) 2335318 ns/iter (± 4931) 1.03
css/visitor/compare/fold_span 3129780 ns/iter (± 21287) 3035657 ns/iter (± 7625) 1.03
css/visitor/compare/fold_span_panic 3321080 ns/iter (± 18159) 3239181 ns/iter (± 25490) 1.03
css/lexer/bootstrap_5_1_3 5111054 ns/iter (± 34455) 5148208 ns/iter (± 16453) 0.99
css/lexer/foundation_6_7_4 4297680 ns/iter (± 1270) 4325627 ns/iter (± 1316) 0.99
css/lexer/tailwind_3_1_1 816290 ns/iter (± 213) 822697 ns/iter (± 3575) 0.99
css/parser/bootstrap_5_1_3 21834632 ns/iter (± 65169) 21071144 ns/iter (± 134087) 1.04
css/parser/foundation_6_7_4 17256376 ns/iter (± 104176) 16805102 ns/iter (± 36109) 1.03
css/parser/tailwind_3_1_1 3230658 ns/iter (± 2540) 3223228 ns/iter (± 2776) 1.00
es/codegen/colors 693754 ns/iter (± 405049) 329525 ns/iter (± 186069) 2.11
es/codegen/large 2645885 ns/iter (± 1634029) 1252650 ns/iter (± 653667) 2.11
es/codegen/with-parser/colors 46429 ns/iter (± 70) 46433 ns/iter (± 275) 1.00
es/codegen/with-parser/large 506379 ns/iter (± 4132) 502957 ns/iter (± 849) 1.01
es/minify/libraries/antd 1534644412 ns/iter (± 21269453) 1444460253 ns/iter (± 15919574) 1.06
es/minify/libraries/d3 279359646 ns/iter (± 7564675) 264272456 ns/iter (± 5061977) 1.06
es/minify/libraries/echarts 1165155567 ns/iter (± 6986788) 1078958756 ns/iter (± 10690267) 1.08
es/minify/libraries/jquery 82222392 ns/iter (± 1465092) 78553890 ns/iter (± 268625) 1.05
es/minify/libraries/lodash 99103461 ns/iter (± 1211907) 95057918 ns/iter (± 468471) 1.04
es/minify/libraries/moment 47340305 ns/iter (± 594494) 45744879 ns/iter (± 257406) 1.03
es/minify/libraries/react 17755635 ns/iter (± 175066) 16889834 ns/iter (± 94471) 1.05
es/minify/libraries/terser 230285786 ns/iter (± 3483570) 207905289 ns/iter (± 3429471) 1.11
es/minify/libraries/three 394982026 ns/iter (± 5629081) 366967161 ns/iter (± 6017315) 1.08
es/minify/libraries/typescript 2786418845 ns/iter (± 29423473) 2632437810 ns/iter (± 13449431) 1.06
es/minify/libraries/victory 652862420 ns/iter (± 7916122) 571651664 ns/iter (± 7136125) 1.14
es/minify/libraries/vue 123503333 ns/iter (± 1935105) 116235822 ns/iter (± 1003817) 1.06
es/visitor/compare/clone 2386585 ns/iter (± 19366) 2337687 ns/iter (± 9845) 1.02
es/visitor/compare/visit_mut_span 2808106 ns/iter (± 76918) 2672886 ns/iter (± 2405) 1.05
es/visitor/compare/visit_mut_span_panic 2898725 ns/iter (± 109695) 2742349 ns/iter (± 4463) 1.06
es/visitor/compare/fold_span 3975835 ns/iter (± 37726) 3776835 ns/iter (± 7328) 1.05
es/visitor/compare/fold_span_panic 4112511 ns/iter (± 52874) 3938333 ns/iter (± 16985) 1.04
es/lexer/colors 13260 ns/iter (± 18) 12882 ns/iter (± 11) 1.03
es/lexer/angular 6389316 ns/iter (± 3350) 6308946 ns/iter (± 6707) 1.01
es/lexer/backbone 792665 ns/iter (± 670) 776913 ns/iter (± 306) 1.02
es/lexer/jquery 4412682 ns/iter (± 3004) 4375155 ns/iter (± 1926) 1.01
es/lexer/jquery mobile 6907418 ns/iter (± 5307) 6819144 ns/iter (± 3392) 1.01
es/lexer/mootools 3479174 ns/iter (± 4851) 3415910 ns/iter (± 1091) 1.02
es/lexer/underscore 656672 ns/iter (± 144) 641578 ns/iter (± 409) 1.02
es/lexer/three 20965226 ns/iter (± 51693) 20715950 ns/iter (± 11654) 1.01
es/lexer/yui 3870009 ns/iter (± 5188) 3824426 ns/iter (± 2859) 1.01
es/parser/colors 28759 ns/iter (± 34) 28420 ns/iter (± 253) 1.01
es/parser/angular 15351704 ns/iter (± 413509) 14845443 ns/iter (± 136130) 1.03
es/parser/backbone 2177325 ns/iter (± 9886) 2154483 ns/iter (± 9168) 1.01
es/parser/jquery 12127396 ns/iter (± 285847) 11719448 ns/iter (± 137310) 1.03
es/parser/jquery mobile 19973576 ns/iter (± 343361) 18576358 ns/iter (± 409950) 1.08
es/parser/mootools 9053831 ns/iter (± 36854) 8853917 ns/iter (± 27506) 1.02
es/parser/underscore 1826273 ns/iter (± 9707) 1815955 ns/iter (± 7430) 1.01
es/parser/three 56648151 ns/iter (± 267804) 54015487 ns/iter (± 848240) 1.05
es/parser/yui 9208713 ns/iter (± 74591) 9009451 ns/iter (± 64222) 1.02
es/preset-env/usage/builtin_type 142651 ns/iter (± 34144) 144373 ns/iter (± 34533) 0.99
es/preset-env/usage/property 20183 ns/iter (± 66) 20736 ns/iter (± 67) 0.97
es/resolver/typescript 126584833 ns/iter (± 3071739) 120639393 ns/iter (± 2385472) 1.05
es/fixer/typescript 91417129 ns/iter (± 2247851) 86780652 ns/iter (± 772762) 1.05
es/hygiene/typescript 202957600 ns/iter (± 1415394) 185235352 ns/iter (± 1841606) 1.10
es/resolver_with_hygiene/typescript 361092642 ns/iter (± 1472001) 334953899 ns/iter (± 2493177) 1.08
es/visitor/base-perf/module_clone 81082 ns/iter (± 568) 80473 ns/iter (± 389) 1.01
es/visitor/base-perf/fold_empty 90554 ns/iter (± 480) 90031 ns/iter (± 298) 1.01
es/visitor/base-perf/fold_noop_impl_all 91122 ns/iter (± 229) 90120 ns/iter (± 486) 1.01
es/visitor/base-perf/fold_noop_impl_vec 91157 ns/iter (± 227) 90643 ns/iter (± 872) 1.01
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 41 ns/iter (± 0) 41 ns/iter (± 0) 1
es/visitor/base-perf/boxing_boxed 101 ns/iter (± 0) 101 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed 77 ns/iter (± 0) 78 ns/iter (± 0) 0.99
es/visitor/base-perf/visit_contains_this 3538 ns/iter (± 50) 3503 ns/iter (± 66) 1.01
es/base/parallel/resolver/typescript 6285194803 ns/iter (± 564256696) 6222723125 ns/iter (± 533590493) 1.01
es/base/parallel/hygiene/typescript 2192407359 ns/iter (± 12820602) 2210845052 ns/iter (± 15491829) 0.99
misc/visitors/time-complexity/time 5 107 ns/iter (± 0) 103 ns/iter (± 0) 1.04
misc/visitors/time-complexity/time 10 345 ns/iter (± 0) 341 ns/iter (± 1) 1.01
misc/visitors/time-complexity/time 15 675 ns/iter (± 4) 672 ns/iter (± 2) 1.00
misc/visitors/time-complexity/time 20 1237 ns/iter (± 0) 1246 ns/iter (± 15) 0.99
misc/visitors/time-complexity/time 40 6216 ns/iter (± 40) 6912 ns/iter (± 5) 0.90
misc/visitors/time-complexity/time 60 15589 ns/iter (± 10) 17278 ns/iter (± 54) 0.90
es/full-target/es2016 254051 ns/iter (± 533) 252472 ns/iter (± 339) 1.01
es/full-target/es2017 246560 ns/iter (± 419) 245866 ns/iter (± 506) 1.00
es/full-target/es2018 235862 ns/iter (± 266) 235250 ns/iter (± 311) 1.00
es2020_nullish_coalescing 93020 ns/iter (± 571) 93074 ns/iter (± 238) 1.00
es2020_optional_chaining 124420 ns/iter (± 234) 123974 ns/iter (± 249) 1.00
es2022_class_properties 150124 ns/iter (± 343) 147986 ns/iter (± 317) 1.01
es2018_object_rest_spread 96141 ns/iter (± 1111) 95379 ns/iter (± 164) 1.01
es2019_optional_catch_binding 83777 ns/iter (± 173) 85147 ns/iter (± 212) 0.98
es2017_async_to_generator 84100 ns/iter (± 183) 85358 ns/iter (± 239) 0.99
es2016_exponentiation 88367 ns/iter (± 307) 89805 ns/iter (± 245) 0.98
es2015_arrow 92222 ns/iter (± 177) 93717 ns/iter (± 262) 0.98
es2015_block_scoped_fn 90245 ns/iter (± 112) 91593 ns/iter (± 293) 0.99
es2015_block_scoping 166898 ns/iter (± 229) 168208 ns/iter (± 485) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.