fix(css/compat): Remove usage of box_syntax (#7153)

kdy1 · web-flow · commit 6f0bf665c29a · 2023-03-28T16:58:08.000+09:00
diff --git a/crates/swc_css_compat/src/compiler/color_hwb.rs b/crates/swc_css_compat/src/compiler/color_hwb.rs
@@ -131,19 +131,19 @@ impl Compiler {
                             span: Default::default(),
                             raw: None,
                         })),
-                        ComponentValue::Delimiter(box Delimiter {
+                        ComponentValue::Delimiter(Box::new(Delimiter {
                             value: DelimiterValue::Comma,
                             span: Default::default(),
-                        }),
+                        })),
                         ComponentValue::Number(Box::new(Number {
                             value: rgb[1].round(),
                             span: Default::default(),
                             raw: None,
                         })),
-                        ComponentValue::Delimiter(box Delimiter {
+                        ComponentValue::Delimiter(Box::new(Delimiter {
                             value: DelimiterValue::Comma,
                             span: Default::default(),
-                        }),
+                        })),
                         ComponentValue::Number(Box::new(Number {
                             value: rgb[2].round(),
                             span: Default::default(),
@@ -165,33 +165,33 @@ impl Compiler {
                             span: Default::default(),
                             raw: None,
                         })),
-                        ComponentValue::Delimiter(box Delimiter {
+                        ComponentValue::Delimiter(Box::new(Delimiter {
                             value: DelimiterValue::Comma,
                             span: Default::default(),
-                        }),
+                        })),
                         ComponentValue::Number(Box::new(Number {
                             value: rgb[1].round(),
                             span: Default::default(),
                             raw: None,
                         })),
-                        ComponentValue::Delimiter(box Delimiter {
+                        ComponentValue::Delimiter(Box::new(Delimiter {
                             value: DelimiterValue::Comma,
                             span: Default::default(),
-                        }),
+                        })),
                         ComponentValue::Number(Box::new(Number {
                             value: rgb[2].round(),
                             span: Default::default(),
                             raw: None,
                         })),
-                        ComponentValue::Delimiter(box Delimiter {
+                        ComponentValue::Delimiter(Box::new(Delimiter {
                             value: DelimiterValue::Comma,
                             span: Default::default(),
-                        }),
-                        ComponentValue::AlphaValue(box AlphaValue::Number(Number {
+                        })),
+                        ComponentValue::AlphaValue(Box::new(AlphaValue::Number(Number {
                             value: a,
                             span: Default::default(),
                             raw: None,
-                        })),
+                        }))),
                     ],
                     span: Default::default(),
                 });
diff --git a/crates/swc_css_compat/src/lib.rs b/crates/swc_css_compat/src/lib.rs
@@ -1,4 +1,3 @@
-#![feature(box_syntax)]
 #![feature(box_patterns)]
 #![allow(clippy::boxed_local)]
 #![allow(clippy::vec_box)]

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-#![feature(box_syntax)]`
`2`	`1`	`#![feature(box_patterns)]`
`3`	`2`	`#![allow(clippy::boxed_local)]`
`4`	`3`	`#![allow(clippy::vec_box)]`
Benchmark suite	Current: `6f0bf66`	Previous: `05a2815`	Ratio
`es/full/bugs-1`	`306860` ns/iter (`± 12045`)	`286166` ns/iter (`± 15485`)	`1.07`
`es/full/minify/libraries/antd`	`1579380991` ns/iter (`± 37792253`)	`1543084670` ns/iter (`± 18233636`)	`1.02`
`es/full/minify/libraries/d3`	`294309630` ns/iter (`± 4039312`)	`296337470` ns/iter (`± 5455452`)	`0.99`
`es/full/minify/libraries/echarts`	`1219171891` ns/iter (`± 17232034`)	`1223230043` ns/iter (`± 14589295`)	`1.00`
`es/full/minify/libraries/jquery`	`91913618` ns/iter (`± 3368280`)	`91280937` ns/iter (`± 824052`)	`1.01`
`es/full/minify/libraries/lodash`	`106623761` ns/iter (`± 1237239`)	`106991231` ns/iter (`± 1803421`)	`1.00`
`es/full/minify/libraries/moment`	`53561094` ns/iter (`± 535397`)	`53406124` ns/iter (`± 729148`)	`1.00`
`es/full/minify/libraries/react`	`19363024` ns/iter (`± 185878`)	`19099732` ns/iter (`± 202787`)	`1.01`
`es/full/minify/libraries/terser`	`247393888` ns/iter (`± 2223988`)	`248350503` ns/iter (`± 3862224`)	`1.00`
`es/full/minify/libraries/three`	`452150355` ns/iter (`± 6918059`)	`450547656` ns/iter (`± 3810626`)	`1.00`
`es/full/minify/libraries/typescript`	`2976159601` ns/iter (`± 8532060`)	`2952506531` ns/iter (`± 17589907`)	`1.01`
`es/full/minify/libraries/victory`	`657549077` ns/iter (`± 7639722`)	`679908761` ns/iter (`± 22557648`)	`0.97`
`es/full/minify/libraries/vue`	`135357950` ns/iter (`± 2607797`)	`130657592` ns/iter (`± 1956663`)	`1.04`
`es/full/codegen/es3`	`28838` ns/iter (`± 55`)	`28185` ns/iter (`± 175`)	`1.02`
`es/full/codegen/es5`	`28908` ns/iter (`± 47`)	`28232` ns/iter (`± 99`)	`1.02`
`es/full/codegen/es2015`	`28909` ns/iter (`± 58`)	`28211` ns/iter (`± 67`)	`1.02`
`es/full/codegen/es2016`	`28936` ns/iter (`± 48`)	`28232` ns/iter (`± 69`)	`1.02`
`es/full/codegen/es2017`	`28917` ns/iter (`± 46`)	`28295` ns/iter (`± 50`)	`1.02`
`es/full/codegen/es2018`	`28954` ns/iter (`± 71`)	`28192` ns/iter (`± 57`)	`1.03`
`es/full/codegen/es2019`	`28959` ns/iter (`± 57`)	`28229` ns/iter (`± 75`)	`1.03`
`es/full/codegen/es2020`	`28988` ns/iter (`± 49`)	`28245` ns/iter (`± 58`)	`1.03`
`es/full/all/es3`	`186090853` ns/iter (`± 3046361`)	`181033595` ns/iter (`± 2429937`)	`1.03`
`es/full/all/es5`	`179068027` ns/iter (`± 2809848`)	`170024824` ns/iter (`± 2683427`)	`1.05`
`es/full/all/es2015`	`138170857` ns/iter (`± 2639603`)	`135054447` ns/iter (`± 2890752`)	`1.02`
`es/full/all/es2016`	`137156101` ns/iter (`± 2452924`)	`133665622` ns/iter (`± 1884542`)	`1.03`
`es/full/all/es2017`	`136378831` ns/iter (`± 2060629`)	`131329988` ns/iter (`± 2846115`)	`1.04`
`es/full/all/es2018`	`133360480` ns/iter (`± 6449444`)	`128086947` ns/iter (`± 1014312`)	`1.04`
`es/full/all/es2019`	`130363343` ns/iter (`± 1358093`)	`125727742` ns/iter (`± 1614292`)	`1.04`
`es/full/all/es2020`	`120647406` ns/iter (`± 1491423`)	`118660944` ns/iter (`± 804444`)	`1.02`
`es/full/parser`	`535093` ns/iter (`± 7933`)	`529893` ns/iter (`± 9136`)	`1.01`
`es/full/base/fixer`	`22560` ns/iter (`± 55`)	`22346` ns/iter (`± 23`)	`1.01`
`es/full/base/resolver_and_hygiene`	`82754` ns/iter (`± 114`)	`83652` ns/iter (`± 124`)	`0.99`
`serialization of serde`	`130` ns/iter (`± 0`)	`130` ns/iter (`± 0`)	`1`
`css/minify/libraries/bootstrap`	`28313024` ns/iter (`± 92503`)	`28527350` ns/iter (`± 87830`)	`0.99`
`css/visitor/compare/clone`	`2110750` ns/iter (`± 4948`)	`2088044` ns/iter (`± 18958`)	`1.01`
`css/visitor/compare/visit_mut_span`	`2288637` ns/iter (`± 5842`)	`2248870` ns/iter (`± 5201`)	`1.02`
`css/visitor/compare/visit_mut_span_panic`	`2338539` ns/iter (`± 6243`)	`2324306` ns/iter (`± 4042`)	`1.01`
`css/visitor/compare/fold_span`	`3056357` ns/iter (`± 14855`)	`3072586` ns/iter (`± 29319`)	`0.99`
`css/visitor/compare/fold_span_panic`	`3209061` ns/iter (`± 21165`)	`3191617` ns/iter (`± 20953`)	`1.01`
`css/lexer/bootstrap_5_1_3`	`5151686` ns/iter (`± 3903`)	`5159365` ns/iter (`± 18311`)	`1.00`
`css/lexer/foundation_6_7_4`	`4337957` ns/iter (`± 2057`)	`4386063` ns/iter (`± 2657`)	`0.99`
`css/lexer/tailwind_3_1_1`	`826287` ns/iter (`± 730`)	`833038` ns/iter (`± 552`)	`0.99`
`css/parser/bootstrap_5_1_3`	`22222777` ns/iter (`± 213337`)	`21960986` ns/iter (`± 78217`)	`1.01`
`css/parser/foundation_6_7_4`	`17295790` ns/iter (`± 42544`)	`17469137` ns/iter (`± 29803`)	`0.99`
`css/parser/tailwind_3_1_1`	`3317422` ns/iter (`± 2222`)	`3334509` ns/iter (`± 4936`)	`0.99`
`es/codegen/colors`	`327536` ns/iter (`± 184689`)	`327689` ns/iter (`± 184517`)	`1.00`
`es/codegen/large`	`1214903` ns/iter (`± 612987`)	`1216705` ns/iter (`± 614071`)	`1.00`
`es/codegen/with-parser/colors`	`47543` ns/iter (`± 351`)	`47497` ns/iter (`± 337`)	`1.00`
`es/codegen/with-parser/large`	`516747` ns/iter (`± 1823`)	`514271` ns/iter (`± 918`)	`1.00`
`es/minify/libraries/antd`	`1364631432` ns/iter (`± 21115879`)	`1359479667` ns/iter (`± 11280520`)	`1.00`
`es/minify/libraries/d3`	`258615244` ns/iter (`± 3733066`)	`265851221` ns/iter (`± 3370610`)	`0.97`
`es/minify/libraries/echarts`	`1034337038` ns/iter (`± 9884932`)	`1066883398` ns/iter (`± 7216198`)	`0.97`
`es/minify/libraries/jquery`	`79235045` ns/iter (`± 1096146`)	`80453409` ns/iter (`± 869798`)	`0.98`
`es/minify/libraries/lodash`	`95439691` ns/iter (`± 1429508`)	`95718585` ns/iter (`± 2094633`)	`1.00`
`es/minify/libraries/moment`	`45936676` ns/iter (`± 519127`)	`46443692` ns/iter (`± 392193`)	`0.99`
`es/minify/libraries/react`	`17156616` ns/iter (`± 399770`)	`17400288` ns/iter (`± 236821`)	`0.99`
`es/minify/libraries/terser`	`207759079` ns/iter (`± 2029040`)	`224126661` ns/iter (`± 2526292`)	`0.93`
`es/minify/libraries/three`	`362241726` ns/iter (`± 5806377`)	`383293868` ns/iter (`± 6556151`)	`0.95`
`es/minify/libraries/typescript`	`2483046811` ns/iter (`± 16561593`)	`2502044579` ns/iter (`± 11658688`)	`0.99`
`es/minify/libraries/victory`	`568868874` ns/iter (`± 10395795`)	`574791298` ns/iter (`± 12135616`)	`0.99`
`es/minify/libraries/vue`	`117812761` ns/iter (`± 1804128`)	`116773786` ns/iter (`± 2775983`)	`1.01`
`es/visitor/compare/clone`	`2287097` ns/iter (`± 9892`)	`2278690` ns/iter (`± 12423`)	`1.00`
`es/visitor/compare/visit_mut_span`	`2668981` ns/iter (`± 6047`)	`2663724` ns/iter (`± 14370`)	`1.00`
`es/visitor/compare/visit_mut_span_panic`	`2720931` ns/iter (`± 7364`)	`2732186` ns/iter (`± 14752`)	`1.00`
`es/visitor/compare/fold_span`	`3774154` ns/iter (`± 24381`)	`3800752` ns/iter (`± 13652`)	`0.99`
`es/visitor/compare/fold_span_panic`	`3933399` ns/iter (`± 21823`)	`3976919` ns/iter (`± 20207`)	`0.99`
`es/lexer/colors`	`15347` ns/iter (`± 89`)	`15474` ns/iter (`± 13`)	`0.99`
`es/lexer/angular`	`7432025` ns/iter (`± 4193`)	`7502821` ns/iter (`± 5728`)	`0.99`
`es/lexer/backbone`	`956952` ns/iter (`± 461`)	`964795` ns/iter (`± 414`)	`0.99`
`es/lexer/jquery`	`5350062` ns/iter (`± 5270`)	`5404499` ns/iter (`± 1864`)	`0.99`
`es/lexer/jquery mobile`	`8271832` ns/iter (`± 6013`)	`8342515` ns/iter (`± 5922`)	`0.99`
`es/lexer/mootools`	`4221590` ns/iter (`± 1522`)	`4264017` ns/iter (`± 2618`)	`0.99`
`es/lexer/underscore`	`802563` ns/iter (`± 506`)	`807891` ns/iter (`± 334`)	`0.99`
`es/lexer/three`	`25172001` ns/iter (`± 35163`)	`25389681` ns/iter (`± 39511`)	`0.99`
`es/lexer/yui`	`4582419` ns/iter (`± 2524`)	`4613323` ns/iter (`± 1311`)	`0.99`
`es/parser/colors`	`29468` ns/iter (`± 72`)	`29566` ns/iter (`± 42`)	`1.00`
`es/parser/angular`	`15401018` ns/iter (`± 92891`)	`15965980` ns/iter (`± 265989`)	`0.96`
`es/parser/backbone`	`2218175` ns/iter (`± 19411`)	`2196965` ns/iter (`± 10624`)	`1.01`
`es/parser/jquery`	`12193663` ns/iter (`± 134260`)	`12311797` ns/iter (`± 106232`)	`0.99`
`es/parser/jquery mobile`	`19511395` ns/iter (`± 243605`)	`19923757` ns/iter (`± 350753`)	`0.98`
`es/parser/mootools`	`9190166` ns/iter (`± 39453`)	`9197569` ns/iter (`± 38435`)	`1.00`
`es/parser/underscore`	`1874441` ns/iter (`± 10440`)	`1862669` ns/iter (`± 9920`)	`1.01`
`es/parser/three`	`55942321` ns/iter (`± 278120`)	`56261470` ns/iter (`± 284307`)	`0.99`
`es/parser/yui`	`9268997` ns/iter (`± 54734`)	`9378293` ns/iter (`± 102851`)	`0.99`
`es/preset-env/usage/builtin_type`	`143198` ns/iter (`± 34114`)	`140989` ns/iter (`± 33530`)	`1.02`
`es/preset-env/usage/property`	`20697` ns/iter (`± 72`)	`20827` ns/iter (`± 88`)	`0.99`
`es/resolver/typescript`	`117291072` ns/iter (`± 4425172`)	`118238098` ns/iter (`± 2807283`)	`0.99`
`es/fixer/typescript`	`79717655` ns/iter (`± 546509`)	`79606479` ns/iter (`± 1240222`)	`1.00`
`es/hygiene/typescript`	`168479362` ns/iter (`± 1653574`)	`167954784` ns/iter (`± 1230164`)	`1.00`
`es/resolver_with_hygiene/typescript`	`317006465` ns/iter (`± 1900717`)	`319740106` ns/iter (`± 1956497`)	`0.99`
`es/visitor/base-perf/module_clone`	`79500` ns/iter (`± 1629`)	`79571` ns/iter (`± 1405`)	`1.00`
`es/visitor/base-perf/fold_empty`	`88962` ns/iter (`± 1109`)	`88331` ns/iter (`± 1370`)	`1.01`
`es/visitor/base-perf/fold_noop_impl_all`	`90660` ns/iter (`± 1262`)	`90131` ns/iter (`± 1871`)	`1.01`
`es/visitor/base-perf/fold_noop_impl_vec`	`89921` ns/iter (`± 1512`)	`91029` ns/iter (`± 1285`)	`0.99`
`es/visitor/base-perf/boxing_boxed_clone`	`56` ns/iter (`± 0`)	`56` ns/iter (`± 0`)	`1`
`es/visitor/base-perf/boxing_unboxed_clone`	`54` ns/iter (`± 0`)	`53` ns/iter (`± 0`)	`1.02`
`es/visitor/base-perf/boxing_boxed`	`102` ns/iter (`± 0`)	`101` ns/iter (`± 0`)	`1.01`
`es/visitor/base-perf/boxing_unboxed`	`97` ns/iter (`± 0`)	`97` ns/iter (`± 0`)	`1`
`es/visitor/base-perf/visit_contains_this`	`3558` ns/iter (`± 102`)	`3617` ns/iter (`± 48`)	`0.98`
`es/base/parallel/resolver/typescript`	`5943048181` ns/iter (`± 505993951`)	`6736891945` ns/iter (`± 444399279`)	`0.88`
`es/base/parallel/hygiene/typescript`	`1992273137` ns/iter (`± 34182195`)	`1971385546` ns/iter (`± 23498942`)	`1.01`
`misc/visitors/time-complexity/time 5`	`91` ns/iter (`± 0`)	`91` ns/iter (`± 0`)	`1`
`misc/visitors/time-complexity/time 10`	`294` ns/iter (`± 0`)	`290` ns/iter (`± 4`)	`1.01`
`misc/visitors/time-complexity/time 15`	`609` ns/iter (`± 8`)	`638` ns/iter (`± 7`)	`0.95`
`misc/visitors/time-complexity/time 20`	`1141` ns/iter (`± 24`)	`1125` ns/iter (`± 14`)	`1.01`
`misc/visitors/time-complexity/time 40`	`5980` ns/iter (`± 62`)	`5780` ns/iter (`± 44`)	`1.03`
`misc/visitors/time-complexity/time 60`	`15204` ns/iter (`± 17`)	`12859` ns/iter (`± 8`)	`1.18`
`es/full-target/es2016`	`250709` ns/iter (`± 275`)	`251233` ns/iter (`± 1175`)	`1.00`
`es/full-target/es2017`	`243515` ns/iter (`± 384`)	`243531` ns/iter (`± 459`)	`1.00`
`es/full-target/es2018`	`232767` ns/iter (`± 221`)	`232733` ns/iter (`± 466`)	`1.00`
`es2020_nullish_coalescing`	`90961` ns/iter (`± 287`)	`91252` ns/iter (`± 558`)	`1.00`
`es2020_optional_chaining`	`124417` ns/iter (`± 429`)	`124061` ns/iter (`± 268`)	`1.00`
`es2022_class_properties`	`147055` ns/iter (`± 507`)	`148462` ns/iter (`± 332`)	`0.99`
`es2018_object_rest_spread`	`95023` ns/iter (`± 224`)	`95164` ns/iter (`± 132`)	`1.00`
`es2019_optional_catch_binding`	`84220` ns/iter (`± 202`)	`84714` ns/iter (`± 209`)	`0.99`
`es2017_async_to_generator`	`84828` ns/iter (`± 184`)	`85507` ns/iter (`± 157`)	`0.99`
`es2016_exponentiation`	`89002` ns/iter (`± 279`)	`89605` ns/iter (`± 185`)	`0.99`
`es2015_arrow`	`93374` ns/iter (`± 246`)	`94039` ns/iter (`± 289`)	`0.99`
`es2015_block_scoped_fn`	`90812` ns/iter (`± 220`)	`90948` ns/iter (`± 288`)	`1.00`
`es2015_block_scoping`	`168034` ns/iter (`± 299`)	`169621` ns/iter (`± 400`)	`0.99`