refactor(plugin/runner): Fix clippy warnings (#7244)

crates/swc_plugin_runner/src/imported_fn/comments.rs

@@ -113,10 +113,7 @@ where
         .as_ref()
         .expect("Alloc guest memory fn should be available, check initialization");
 
-    return unwrap_comments_storage_or_default(
-        |comments| f(comments, memory, alloc_guest_memory),
-        default,
-    );
+    unwrap_comments_storage_or_default(|comments| f(comments, memory, alloc_guest_memory), default)
 }
 
 /// Common logics for add_*_comment/comments.
@@ -190,7 +187,7 @@ pub fn take_leading_comments_proxy(
         .as_ref()
         .expect("Alloc guest memory fn should be available, check initialization");
 
-    return unwrap_comments_storage_or_default(
+    unwrap_comments_storage_or_default(
         |comments| {
             let leading_comments = comments.take_leading(BytePos(byte_pos));
             if let Some(leading_comments) = leading_comments {
@@ -211,7 +208,7 @@ pub fn take_leading_comments_proxy(
             }
         },
         0,
-    );
+    )
 }
 
 /// Ask to get leading_comments from currently scoped comments held by
@@ -235,7 +232,7 @@ pub fn get_leading_comments_proxy(
         .as_ref()
         .expect("Alloc guest memory fn should be available, check initialization");
 
-    return unwrap_comments_storage_or_default(
+    unwrap_comments_storage_or_default(
         |comments| {
             let leading_comments = comments.get_leading(BytePos(byte_pos));
             if let Some(leading_comments) = leading_comments {
@@ -256,7 +253,7 @@ pub fn get_leading_comments_proxy(
             }
         },
         0,
-    );
+    )
 }
 
 #[tracing::instrument(level = "info", skip_all)]
@@ -314,7 +311,7 @@ pub fn take_trailing_comments_proxy(
         .as_ref()
         .expect("Alloc guest memory fn should be available, check initialization");
 
-    return unwrap_comments_storage_or_default(
+    unwrap_comments_storage_or_default(
         |comments| {
             let trailing_comments = comments.take_trailing(BytePos(byte_pos));
             if let Some(leading_comments) = trailing_comments {
@@ -335,7 +332,7 @@ pub fn take_trailing_comments_proxy(
             }
         },
         0,
-    );
+    )
 }
 
 #[tracing::instrument(level = "info", skip_all)]
@@ -354,7 +351,7 @@ pub fn get_trailing_comments_proxy(
         .as_ref()
         .expect("Alloc guest memory fn should be available, check initialization");
 
-    return unwrap_comments_storage_or_default(
+    unwrap_comments_storage_or_default(
         |comments| {
             let trailing_comments = comments.get_trailing(BytePos(byte_pos));
             if let Some(leading_comments) = trailing_comments {
@@ -375,7 +372,7 @@ pub fn get_trailing_comments_proxy(
             }
         },
         0,
-    );
+    )
 }
 
 #[tracing::instrument(level = "info", skip_all)]

crates/swc_plugin_runner/src/imported_fn/metadata_context.rs

@@ -90,7 +90,7 @@ pub fn get_transform_plugin_config(
             return 1;
         }
     }
-    return 0;
+    0
 }
 
 #[tracing::instrument(level = "info", skip_all)]
@@ -128,7 +128,7 @@ pub fn get_transform_context(
 
         return 1;
     }
-    return 0;
+    0
 }
 
 #[tracing::instrument(level = "info", skip_all)]
@@ -173,7 +173,7 @@ pub fn get_experimental_transform_context(
         return 1;
     }
 
-    return 0;
+    0
 }
 
 #[tracing::instrument(level = "info", skip_all)]

crates/swc_plugin_runner/src/memory_interop.rs

@@ -5,7 +5,7 @@ use wasmer::{Memory, MemoryView, StoreMut, TypedFunction, WasmPtr};
 #[tracing::instrument(level = "info", skip_all)]
 pub fn copy_bytes_into_host(memory: &MemoryView, bytes_ptr: i32, bytes_ptr_len: i32) -> Vec<u8> {
     let ptr: WasmPtr<u8> = WasmPtr::new(bytes_ptr as _);
-    let derefed_ptr = ptr.deref(memory);
+    let _derefed_ptr = ptr.deref(memory);
     let values = ptr.slice(memory, bytes_ptr_len as u32).expect("xxx");
 
     values
@@ -75,7 +75,7 @@ pub fn allocate_return_values_into_guest(
         .expect("Should able to allocate memory in the plugin");
 
     let (allocated_ptr, allocated_ptr_len) =
-        write_into_memory_view(memory, store, serialized_bytes, |s, _| guest_memory_ptr);
+        write_into_memory_view(memory, store, serialized_bytes, |_, _| guest_memory_ptr);
 
     let allocated_bytes = AllocatedBytesPtr(allocated_ptr, allocated_ptr_len);
     // Retuning (allocated_ptr, len) into caller (plugin)

crates/swc_plugin_runner/src/transform_executor.rs

@@ -128,13 +128,12 @@ impl TransformExecutor {
             |s, serialized_len| {
                 self.exported_plugin_alloc
                     .call(s, serialized_len.try_into().expect("booo"))
-                    .expect(
-                        format!(
+                    .unwrap_or_else(|_| {
+                        panic!(
                             "Should able to allocate memory for the size of {}",
                             serialized_len
                         )
-                        .as_str(),
-                    )
+                    })
             },
         );