Skip to content

Commit

Permalink
refactor(es/typescript): Remove unused code (#6830)
Browse files Browse the repository at this point in the history
  • Loading branch information
alex-dixon committed Jan 18, 2023
1 parent 09b3e72 commit 7205543
Showing 1 changed file with 0 additions and 29 deletions.
29 changes: 0 additions & 29 deletions crates/swc_ecma_transforms_typescript/src/strip.rs
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ pub fn strip_with_config(config: Config, top_level_mark: Mark) -> impl Fold + Vi
scope: Default::default(),
is_side_effect_import: Default::default(),
is_type_only_export: Default::default(),
uninitialized_vars: Default::default(),
decl_names: Default::default(),
in_var_pat: Default::default(),
keys: Default::default()
Expand Down Expand Up @@ -233,7 +232,6 @@ where
scope: Default::default(),
is_side_effect_import: Default::default(),
is_type_only_export: Default::default(),
uninitialized_vars: Default::default(),
decl_names: Default::default(),
in_var_pat: Default::default(),
keys: Default::default(),
Expand Down Expand Up @@ -278,7 +276,6 @@ where

is_side_effect_import: bool,
is_type_only_export: bool,
uninitialized_vars: Vec<VarDeclarator>,

ts_enum_lit: TSEnumLit,

Expand Down Expand Up @@ -2092,19 +2089,6 @@ where
self.config.import_export_assign_config,
));

if !self.uninitialized_vars.is_empty() {
prepend_stmt(
&mut module.body,
VarDecl {
span: DUMMY_SP,
kind: VarDeclKind::Var,
decls: take(&mut self.uninitialized_vars),
declare: false,
}
.into(),
);
}

let is_module = module
.body
.iter()
Expand Down Expand Up @@ -2479,19 +2463,6 @@ where
}

n.visit_mut_children_with(self);

if !self.uninitialized_vars.is_empty() {
prepend_stmt(
&mut n.body,
VarDecl {
span: DUMMY_SP,
kind: VarDeclKind::Var,
decls: take(&mut self.uninitialized_vars),
declare: false,
}
.into(),
);
}
}

fn visit_mut_stmt(&mut self, stmt: &mut Stmt) {
Expand Down

1 comment on commit 7205543

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7205543 Previous: 1ef2347 Ratio
es/full/bugs-1 302634 ns/iter (± 8619) 294147 ns/iter (± 9108) 1.03
es/full/minify/libraries/antd 1754528121 ns/iter (± 20609853) 1685756853 ns/iter (± 17166097) 1.04
es/full/minify/libraries/d3 317509454 ns/iter (± 5436491) 299203391 ns/iter (± 7765492) 1.06
es/full/minify/libraries/echarts 1349861197 ns/iter (± 23075484) 1275819878 ns/iter (± 14731728) 1.06
es/full/minify/libraries/jquery 92949255 ns/iter (± 667750) 90091857 ns/iter (± 925803) 1.03
es/full/minify/libraries/lodash 108655873 ns/iter (± 1171897) 106390392 ns/iter (± 638688) 1.02
es/full/minify/libraries/moment 53763340 ns/iter (± 277242) 52683592 ns/iter (± 305728) 1.02
es/full/minify/libraries/react 19270692 ns/iter (± 91515) 18993954 ns/iter (± 140001) 1.01
es/full/minify/libraries/terser 261976546 ns/iter (± 5032591) 248467559 ns/iter (± 3005024) 1.05
es/full/minify/libraries/three 475651033 ns/iter (± 4843971) 463386013 ns/iter (± 10194775) 1.03
es/full/minify/libraries/typescript 3288143634 ns/iter (± 12082398) 3189197047 ns/iter (± 24758828) 1.03
es/full/minify/libraries/victory 728694218 ns/iter (± 12123083) 692575001 ns/iter (± 12695834) 1.05
es/full/minify/libraries/vue 136331664 ns/iter (± 1276179) 130282230 ns/iter (± 852615) 1.05
es/full/codegen/es3 25832 ns/iter (± 57) 26528 ns/iter (± 49) 0.97
es/full/codegen/es5 25964 ns/iter (± 42) 26582 ns/iter (± 405) 0.98
es/full/codegen/es2015 25948 ns/iter (± 50) 26511 ns/iter (± 38) 0.98
es/full/codegen/es2016 25898 ns/iter (± 49) 26543 ns/iter (± 40) 0.98
es/full/codegen/es2017 25967 ns/iter (± 61) 26530 ns/iter (± 58) 0.98
es/full/codegen/es2018 25973 ns/iter (± 67) 26505 ns/iter (± 41) 0.98
es/full/codegen/es2019 25934 ns/iter (± 61) 26497 ns/iter (± 35) 0.98
es/full/codegen/es2020 25909 ns/iter (± 62) 26509 ns/iter (± 38) 0.98
es/full/all/es3 171684783 ns/iter (± 2021376) 170378466 ns/iter (± 2601441) 1.01
es/full/all/es5 163767287 ns/iter (± 1625223) 162817941 ns/iter (± 4065256) 1.01
es/full/all/es2015 125012378 ns/iter (± 947613) 123323726 ns/iter (± 1039873) 1.01
es/full/all/es2016 123165227 ns/iter (± 1599892) 122034751 ns/iter (± 968739) 1.01
es/full/all/es2017 121569292 ns/iter (± 977079) 120525661 ns/iter (± 1460531) 1.01
es/full/all/es2018 120230844 ns/iter (± 992277) 119200812 ns/iter (± 790383) 1.01
es/full/all/es2019 119695917 ns/iter (± 648927) 118595604 ns/iter (± 879787) 1.01
es/full/all/es2020 115082124 ns/iter (± 1073100) 114006068 ns/iter (± 712075) 1.01
es/full/parser 540707 ns/iter (± 7750) 542694 ns/iter (± 8506) 1.00
es/full/base/fixer 21983 ns/iter (± 28) 21543 ns/iter (± 18) 1.02
es/full/base/resolver_and_hygiene 80445 ns/iter (± 99) 80457 ns/iter (± 92) 1.00
serialization of ast node 145 ns/iter (± 0) 145 ns/iter (± 0) 1
serialization of serde 130 ns/iter (± 0) 130 ns/iter (± 0) 1
css/minify/libraries/bootstrap 28177951 ns/iter (± 218528) 27824201 ns/iter (± 119766) 1.01
css/visitor/compare/clone 2065755 ns/iter (± 11081) 2044150 ns/iter (± 17903) 1.01
css/visitor/compare/visit_mut_span 2269054 ns/iter (± 10056) 2234425 ns/iter (± 6948) 1.02
css/visitor/compare/visit_mut_span_panic 2295705 ns/iter (± 6335) 2297791 ns/iter (± 6899) 1.00
css/visitor/compare/fold_span 3027146 ns/iter (± 20067) 3003036 ns/iter (± 23573) 1.01
css/visitor/compare/fold_span_panic 3157622 ns/iter (± 21556) 3171987 ns/iter (± 23393) 1.00
css/lexer/bootstrap_5_1_3 5175245 ns/iter (± 5952) 5215572 ns/iter (± 11500) 0.99
css/lexer/foundation_6_7_4 4357196 ns/iter (± 5811) 4340408 ns/iter (± 1431) 1.00
css/lexer/tailwind_3_1_1 828691 ns/iter (± 679) 826281 ns/iter (± 294) 1.00
css/parser/bootstrap_5_1_3 21778097 ns/iter (± 72964) 21582886 ns/iter (± 35137) 1.01
css/parser/foundation_6_7_4 17325116 ns/iter (± 43512) 17213819 ns/iter (± 21899) 1.01
css/parser/tailwind_3_1_1 3318949 ns/iter (± 8935) 3317890 ns/iter (± 6911) 1.00
es/codegen/colors 330332 ns/iter (± 185627) 328435 ns/iter (± 184957) 1.01
es/codegen/large 1207674 ns/iter (± 610211) 1201575 ns/iter (± 607464) 1.01
es/codegen/with-parser/colors 48584 ns/iter (± 340) 48971 ns/iter (± 400) 0.99
es/codegen/with-parser/large 538624 ns/iter (± 1614) 541469 ns/iter (± 1426) 0.99
es/minify/libraries/antd 1564080477 ns/iter (± 15817706) 1459911224 ns/iter (± 17906020) 1.07
es/minify/libraries/d3 265477364 ns/iter (± 4974840) 249923079 ns/iter (± 2909679) 1.06
es/minify/libraries/echarts 1156348746 ns/iter (± 20610931) 1101738026 ns/iter (± 12386650) 1.05
es/minify/libraries/jquery 80367619 ns/iter (± 1979696) 77924082 ns/iter (± 524440) 1.03
es/minify/libraries/lodash 97211452 ns/iter (± 1147846) 94539305 ns/iter (± 1075780) 1.03
es/minify/libraries/moment 46635963 ns/iter (± 320520) 45625814 ns/iter (± 214896) 1.02
es/minify/libraries/react 17304098 ns/iter (± 138864) 16842991 ns/iter (± 112446) 1.03
es/minify/libraries/terser 219568020 ns/iter (± 2864092) 207917425 ns/iter (± 2377983) 1.06
es/minify/libraries/three 400563343 ns/iter (± 5302651) 358694626 ns/iter (± 4614204) 1.12
es/minify/libraries/typescript 2818357970 ns/iter (± 10428453) 2716010701 ns/iter (± 14974320) 1.04
es/minify/libraries/victory 623439027 ns/iter (± 11808582) 576892666 ns/iter (± 18979961) 1.08
es/minify/libraries/vue 119190579 ns/iter (± 1028200) 115499990 ns/iter (± 1085152) 1.03
es/visitor/compare/clone 2401622 ns/iter (± 21369) 2392897 ns/iter (± 11314) 1.00
es/visitor/compare/visit_mut_span 2836177 ns/iter (± 23919) 2793172 ns/iter (± 8496) 1.02
es/visitor/compare/visit_mut_span_panic 2876571 ns/iter (± 6925) 2820620 ns/iter (± 25022) 1.02
es/visitor/compare/fold_span 3988756 ns/iter (± 8412) 3914690 ns/iter (± 6399) 1.02
es/visitor/compare/fold_span_panic 4142528 ns/iter (± 42542) 4086621 ns/iter (± 14448) 1.01
es/lexer/colors 17256 ns/iter (± 27) 17171 ns/iter (± 17) 1.00
es/lexer/angular 8243000 ns/iter (± 7827) 8260100 ns/iter (± 3683) 1.00
es/lexer/backbone 1079670 ns/iter (± 1028) 1080191 ns/iter (± 699) 1.00
es/lexer/jquery 5975874 ns/iter (± 4806) 5973745 ns/iter (± 5559) 1.00
es/lexer/jquery mobile 9215885 ns/iter (± 14610) 9209990 ns/iter (± 8091) 1.00
es/lexer/mootools 4671164 ns/iter (± 8371) 4681917 ns/iter (± 2395) 1.00
es/lexer/underscore 902164 ns/iter (± 701) 901378 ns/iter (± 761) 1.00
es/lexer/three 27981921 ns/iter (± 29171) 28036354 ns/iter (± 22135) 1.00
es/lexer/yui 5057211 ns/iter (± 3719) 5062084 ns/iter (± 4053) 1.00
es/parser/colors 31103 ns/iter (± 143) 31296 ns/iter (± 151) 0.99
es/parser/angular 15960990 ns/iter (± 99508) 15731065 ns/iter (± 95381) 1.01
es/parser/backbone 2350329 ns/iter (± 11844) 2372044 ns/iter (± 13335) 0.99
es/parser/jquery 12755482 ns/iter (± 79498) 12710972 ns/iter (± 59716) 1.00
es/parser/jquery mobile 20372702 ns/iter (± 154401) 20030391 ns/iter (± 137787) 1.02
es/parser/mootools 9807389 ns/iter (± 18506) 9820403 ns/iter (± 23346) 1.00
es/parser/underscore 2003962 ns/iter (± 11382) 2012531 ns/iter (± 10915) 1.00
es/parser/three 61494059 ns/iter (± 367939) 58669498 ns/iter (± 394708) 1.05
es/parser/yui 9703996 ns/iter (± 54095) 9717081 ns/iter (± 62432) 1.00
es/preset-env/usage/builtin_type 143208 ns/iter (± 33022) 144289 ns/iter (± 33754) 0.99
es/preset-env/usage/property 21389 ns/iter (± 93) 21429 ns/iter (± 90) 1.00
es/resolver/typescript 123923196 ns/iter (± 4503446) 118435692 ns/iter (± 4314722) 1.05
es/fixer/typescript 99521875 ns/iter (± 3141329) 92517360 ns/iter (± 1663746) 1.08
es/hygiene/typescript 205517957 ns/iter (± 1315763) 192501729 ns/iter (± 1450692) 1.07
es/resolver_with_hygiene/typescript 351056834 ns/iter (± 1996718) 336360593 ns/iter (± 1813064) 1.04
es/visitor/base-perf/module_clone 75209 ns/iter (± 1470) 74887 ns/iter (± 954) 1.00
es/visitor/base-perf/fold_empty 85148 ns/iter (± 1548) 84714 ns/iter (± 1669) 1.01
es/visitor/base-perf/fold_noop_impl_all 84891 ns/iter (± 391) 85288 ns/iter (± 1670) 1.00
es/visitor/base-perf/fold_noop_impl_vec 85646 ns/iter (± 1262) 86356 ns/iter (± 2191) 0.99
es/visitor/base-perf/boxing_boxed_clone 56 ns/iter (± 0) 56 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed_clone 59 ns/iter (± 0) 67 ns/iter (± 0) 0.88
es/visitor/base-perf/boxing_boxed 104 ns/iter (± 0) 104 ns/iter (± 0) 1
es/visitor/base-perf/boxing_unboxed 103 ns/iter (± 0) 103 ns/iter (± 0) 1
es/visitor/base-perf/visit_contains_this 3436 ns/iter (± 101) 3425 ns/iter (± 48) 1.00
es/base/parallel/resolver/typescript 5901165347 ns/iter (± 546858764) 5196447857 ns/iter (± 417487796) 1.14
es/base/parallel/hygiene/typescript 2395657128 ns/iter (± 36414499) 2347488433 ns/iter (± 29483592) 1.02
misc/visitors/time-complexity/time 5 93 ns/iter (± 0) 92 ns/iter (± 0) 1.01
misc/visitors/time-complexity/time 10 342 ns/iter (± 0) 333 ns/iter (± 1) 1.03
misc/visitors/time-complexity/time 15 636 ns/iter (± 0) 623 ns/iter (± 0) 1.02
misc/visitors/time-complexity/time 20 1163 ns/iter (± 0) 1161 ns/iter (± 1) 1.00
misc/visitors/time-complexity/time 40 6090 ns/iter (± 30) 6114 ns/iter (± 30) 1.00
misc/visitors/time-complexity/time 60 15700 ns/iter (± 285) 15531 ns/iter (± 43) 1.01
es/full-target/es2016 188489 ns/iter (± 580) 187051 ns/iter (± 1056) 1.01
es/full-target/es2017 183122 ns/iter (± 584) 181647 ns/iter (± 340) 1.01
es/full-target/es2018 172313 ns/iter (± 282) 170926 ns/iter (± 471) 1.01
es2020_nullish_coalescing 67233 ns/iter (± 104) 66429 ns/iter (± 89) 1.01
es2020_optional_chaining 96433 ns/iter (± 284) 95680 ns/iter (± 240) 1.01
es2022_class_properties 94083 ns/iter (± 258) 93043 ns/iter (± 173) 1.01
es2018_object_rest_spread 70979 ns/iter (± 129) 71110 ns/iter (± 78) 1.00
es2019_optional_catch_binding 61310 ns/iter (± 136) 60581 ns/iter (± 130) 1.01
es2017_async_to_generator 61725 ns/iter (± 83) 61511 ns/iter (± 138) 1.00
es2016_exponentiation 64937 ns/iter (± 134) 64683 ns/iter (± 100) 1.00
es2015_arrow 69863 ns/iter (± 240) 69223 ns/iter (± 136) 1.01
es2015_block_scoped_fn 66145 ns/iter (± 140) 65923 ns/iter (± 118) 1.00
es2015_block_scoping 153742 ns/iter (± 8913) 155796 ns/iter (± 7595) 0.99
es2015_classes 116983 ns/iter (± 468) 116218 ns/iter (± 456) 1.01
es2015_computed_props 61347 ns/iter (± 110) 60497 ns/iter (± 117) 1.01
es2015_destructuring 116500 ns/iter (± 137) 115905 ns/iter (± 263) 1.01
es2015_duplicate_keys 63941 ns/iter (± 99) 63080 ns/iter (± 125) 1.01
es2015_parameters 78420 ns/iter (± 245) 78871 ns/iter (± 90) 0.99
es2015_fn_name 65404 ns/iter (± 540) 66231 ns/iter (± 426) 0.99
es2015_for_of 63086 ns/iter (± 118) 63805 ns/iter (± 89) 0.99
es2015_instanceof 62021 ns/iter (± 136) 62742 ns/iter (± 71) 0.99
es2015_shorthand_property 59811 ns/iter (± 78) 60362 ns/iter (± 166) 0.99
es2015_spread 59959 ns/iter (± 119) 60578 ns/iter (± 108) 0.99
es2015_sticky_regex 61104 ns/iter (± 156) 61972 ns/iter (± 56) 0.99
es2015_typeof_symbol 61041 ns/iter (± 68) 61956 ns/iter (± 55) 0.99
es/transform/baseline/base 51089 ns/iter (± 78) 51371 ns/iter (± 64) 0.99
es/transform/baseline/common_reserved_word 61633 ns/iter (± 99) 62327 ns/iter (± 72) 0.99
es/transform/baseline/common_typescript 166067 ns/iter (± 227) 145273 ns/iter (± 2731) 1.14
es/target/es3 166280 ns/iter (± 284) 168418 ns/iter (± 341) 0.99
es/target/es2015 601338 ns/iter (± 834) 627719 ns/iter (± 2075) 0.96
es/target/es2016 63799 ns/iter (± 75) 64804 ns/iter (± 137) 0.98
es/target/es2017 60618 ns/iter (± 98) 61682 ns/iter (± 51) 0.98
es/target/es2018 79348 ns/iter (± 116) 81184 ns/iter (± 103) 0.98
es/target/es2020 128964 ns/iter (± 203) 131677 ns/iter (± 305) 0.98
babelify-only 676955 ns/iter (± 1315) 674858 ns/iter (± 1361) 1.00
parse_and_babelify_angular 46564210 ns/iter (± 901781) 44712439 ns/iter (± 682772) 1.04
parse_and_babelify_backbone 5510762 ns/iter (± 48300) 5433564 ns/iter (± 41687) 1.01
parse_and_babelify_jquery 33248887 ns/iter (± 386200) 32441392 ns/iter (± 302958) 1.02
parse_and_babelify_jquery_mobile 56710953 ns/iter (± 809178) 56169657 ns/iter (± 1132160) 1.01
parse_and_babelify_mootools 34998815 ns/iter (± 687549) 33731389 ns/iter (± 569546) 1.04
parse_and_babelify_underscore 4376321 ns/iter (± 17560) 4412309 ns/iter (± 34265) 0.99
parse_and_babelify_yui 34638031 ns/iter (± 872522) 34313585 ns/iter (± 1024656) 1.01
html/minify/document/css_spec 42715190 ns/iter (± 347109) 42332780 ns/iter (± 346295) 1.01
html/minify/document/github 17669451 ns/iter (± 96094) 17496939 ns/iter (± 100667) 1.01
html/minify/document/stackoverflow 15749019 ns/iter (± 55175) 15751213 ns/iter (± 40912) 1.00
html/minify/document_fragment/css_spec 41114566 ns/iter (± 333235) 41059562 ns/iter (± 270140) 1.00
html/minify/document_fragment/github 16950737 ns/iter (± 51305) 16920942 ns/iter (± 48152) 1.00
html/minify/document_fragment/stackoverflow 15400279 ns/iter (± 93899) 15195525 ns/iter (± 65221) 1.01
html/document/visitor/compare/clone 340936 ns/iter (± 1986) 343258 ns/iter (± 2248) 0.99
html/document/visitor/compare/visit_mut_span 367018 ns/iter (± 2152) 365275 ns/iter (± 1882) 1.00
html/document/visitor/compare/visit_mut_span_panic 376662 ns/iter (± 1551) 380852 ns/iter (± 2297) 0.99
html/document/visitor/compare/fold_span 407205 ns/iter (± 2440) 401425 ns/iter (± 1674) 1.01
html/document/visitor/compare/fold_span_panic 460949 ns/iter (± 2343) 465645 ns/iter (± 3087) 0.99
html/document_fragment/visitor/compare/clone 345647 ns/iter (± 1828) 339420 ns/iter (± 1753) 1.02
html/document_fragment/visitor/compare/visit_mut_span 366156 ns/iter (± 1719) 364289 ns/iter (± 1885) 1.01
html/document_fragment/visitor/compare/visit_mut_span_panic 381774 ns/iter (± 2245) 379838 ns/iter (± 1224) 1.01
html/document_fragment/visitor/compare/fold_span 410284 ns/iter (± 1907) 406755 ns/iter (± 1585) 1.01
html/document_fragment/visitor/compare/fold_span_panic 460944 ns/iter (± 2151) 461954 ns/iter (± 1641) 1.00
html/lexer/css_2021_spec 15648082 ns/iter (± 16491) 15568560 ns/iter (± 14879) 1.01
html/lexer/github_com_17_05_2022 6043261 ns/iter (± 8689) 6032293 ns/iter (± 2822) 1.00
html/lexer/stackoverflow_com_17_05_2022 5647912 ns/iter (± 4161) 5641815 ns/iter (± 4402) 1.00
html/parser/parser_document/css_2021_spec 25698606 ns/iter (± 152043) 26341040 ns/iter (± 476742) 0.98
html/parser/parser_document/github_com_17_05_2022 8806054 ns/iter (± 11876) 8757864 ns/iter (± 13578) 1.01
html/parser/parser_document/stackoverflow_com_17_05_2022 7755110 ns/iter (± 4269) 7700601 ns/iter (± 2835) 1.01
html/parser/parser_document_fragment/css_2021_spec 26339904 ns/iter (± 275850) 25530783 ns/iter (± 121532) 1.03
html/parser/parser_document_fragment/github_com_17_05_2022 8832667 ns/iter (± 15592) 8782525 ns/iter (± 3984) 1.01
html/parser/parser_document_fragment/stackoverflow_com_17_05_2022 7790507 ns/iter (± 4385) 7736381 ns/iter (± 7954) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.