Skip to content

Commit 786cf3a

Browse files
authoredMay 24, 2023
fix(es): Init filesystem cache only if plugin exists (#7436)
1 parent 552bc0b commit 786cf3a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed
 

‎crates/swc/src/config/mod.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -666,16 +666,16 @@ impl Options {
666666
{
667667
use swc_ecma_loader::resolve::Resolve;
668668

669-
// Currently swc enables filesystemcache by default on Embedded runtime plugin
670-
// target.
671-
init_plugin_module_cache_once(true, &experimental.cache_root);
672-
673669
let plugin_resolver = CachingResolver::new(
674670
40,
675671
NodeModulesResolver::new(TargetEnv::Node, Default::default(), true),
676672
);
677673

678674
if let Some(plugins) = &experimental.plugins {
675+
// Currently swc enables filesystemcache by default on Embedded runtime plugin
676+
// target.
677+
init_plugin_module_cache_once(true, &experimental.cache_root);
678+
679679
// Populate cache to the plugin modules if not loaded
680680
for plugin_config in plugins.iter() {
681681
let plugin_name = &plugin_config.0;

1 commit comments

Comments
 (1)

github-actions[bot] commented on May 24, 2023

@github-actions[bot]

Benchmark

Benchmark suite Current: 786cf3a Previous: 2071f89 Ratio
es/full/bugs-1 250846 ns/iter (± 2422) 315759 ns/iter (± 9613) 0.79
es/full/minify/libraries/antd 1202656009 ns/iter (± 7943686) 1683686558 ns/iter (± 23275611) 0.71
es/full/minify/libraries/d3 239989340 ns/iter (± 4280540) 320171734 ns/iter (± 9168150) 0.75
es/full/minify/libraries/echarts 959195840 ns/iter (± 5505870) 1307617391 ns/iter (± 16839712) 0.73
es/full/minify/libraries/jquery 76773137 ns/iter (± 121343) 93119074 ns/iter (± 603062) 0.82
es/full/minify/libraries/lodash 87033231 ns/iter (± 103509) 110120966 ns/iter (± 906560) 0.79
es/full/minify/libraries/moment 44806836 ns/iter (± 134693) 54672760 ns/iter (± 902572) 0.82
es/full/minify/libraries/react 16253759 ns/iter (± 40599) 19933533 ns/iter (± 169490) 0.82
es/full/minify/libraries/terser 198014270 ns/iter (± 1716715) 259027695 ns/iter (± 2025825) 0.76
es/full/minify/libraries/three 339558001 ns/iter (± 2910219) 464528351 ns/iter (± 4842638) 0.73
es/full/minify/libraries/typescript 2411538188 ns/iter (± 16154114) 3222657468 ns/iter (± 19421328) 0.75
es/full/minify/libraries/victory 509649946 ns/iter (± 5917456) 710237270 ns/iter (± 13947326) 0.72
es/full/minify/libraries/vue 109660660 ns/iter (± 222158) 136945586 ns/iter (± 1539285) 0.80
es/full/codegen/es3 30794 ns/iter (± 109) 34486 ns/iter (± 192) 0.89
es/full/codegen/es5 30783 ns/iter (± 82) 34547 ns/iter (± 136) 0.89
es/full/codegen/es2015 30843 ns/iter (± 52) 34502 ns/iter (± 183) 0.89
es/full/codegen/es2016 30785 ns/iter (± 67) 34577 ns/iter (± 215) 0.89
es/full/codegen/es2017 30827 ns/iter (± 52) 34612 ns/iter (± 169) 0.89
es/full/codegen/es2018 30945 ns/iter (± 79) 34368 ns/iter (± 179) 0.90
es/full/codegen/es2019 30844 ns/iter (± 51) 34435 ns/iter (± 186) 0.90
es/full/codegen/es2020 30828 ns/iter (± 57) 34479 ns/iter (± 173) 0.89
es/full/all/es3 154605716 ns/iter (± 643229) 186121728 ns/iter (± 2644429) 0.83
es/full/all/es5 147727665 ns/iter (± 659314) 175747136 ns/iter (± 3135430) 0.84
es/full/all/es2015 109771849 ns/iter (± 543422) 140007063 ns/iter (± 3652538) 0.78
es/full/all/es2016 108869193 ns/iter (± 611139) 137815002 ns/iter (± 2045807) 0.79
es/full/all/es2017 108010891 ns/iter (± 696024) 138403315 ns/iter (± 3447731) 0.78
es/full/all/es2018 106233034 ns/iter (± 773007) 133655017 ns/iter (± 1653631) 0.79
es/full/all/es2019 105231433 ns/iter (± 326297) 131728210 ns/iter (± 1716599) 0.80
es/full/all/es2020 100622939 ns/iter (± 544251) 120659213 ns/iter (± 1254159) 0.83
es/full/parser 448273 ns/iter (± 4721) 526103 ns/iter (± 8949) 0.85
es/full/base/fixer 17450 ns/iter (± 150) 22651 ns/iter (± 19) 0.77
es/full/base/resolver_and_hygiene 77263 ns/iter (± 155) 85447 ns/iter (± 610) 0.90
serialization of serde 113 ns/iter (± 0) 124 ns/iter (± 0) 0.91
css/minify/libraries/bootstrap 23390977 ns/iter (± 27477) 27306237 ns/iter (± 125894) 0.86
css/visitor/compare/clone 1644454 ns/iter (± 1759) 2145679 ns/iter (± 5740) 0.77
css/visitor/compare/visit_mut_span 1778606 ns/iter (± 3722) 2320207 ns/iter (± 3589) 0.77
css/visitor/compare/visit_mut_span_panic 1854888 ns/iter (± 4072) 2365513 ns/iter (± 3486) 0.78
css/visitor/compare/fold_span 2548043 ns/iter (± 11549) 3078595 ns/iter (± 20558) 0.83
css/visitor/compare/fold_span_panic 2735810 ns/iter (± 8882) 3289446 ns/iter (± 17194) 0.83
css/lexer/bootstrap_5_1_3 4537073 ns/iter (± 2354) 5192484 ns/iter (± 9795) 0.87
css/lexer/foundation_6_7_4 3794958 ns/iter (± 3100) 4374118 ns/iter (± 3908) 0.87
css/lexer/tailwind_3_1_1 720612 ns/iter (± 783) 830875 ns/iter (± 309) 0.87
css/parser/bootstrap_5_1_3 18027063 ns/iter (± 21727) 21138431 ns/iter (± 106943) 0.85
css/parser/foundation_6_7_4 14416797 ns/iter (± 18651) 16900045 ns/iter (± 46007) 0.85
css/parser/tailwind_3_1_1 2785228 ns/iter (± 2949) 3246632 ns/iter (± 3508) 0.86
es/codegen/colors 731581 ns/iter (± 400747) 735816 ns/iter (± 394952) 0.99
es/codegen/large 2971698 ns/iter (± 1579031) 3199927 ns/iter (± 1671465) 0.93
es/codegen/with-parser/colors 41492 ns/iter (± 496) 48777 ns/iter (± 346) 0.85
es/codegen/with-parser/large 464781 ns/iter (± 778) 515855 ns/iter (± 1468) 0.90
es/minify/libraries/antd 1041272773 ns/iter (± 9691657) 1484653180 ns/iter (± 9622051) 0.70
es/minify/libraries/d3 212123331 ns/iter (± 1388214) 268767255 ns/iter (± 3374599) 0.79
es/minify/libraries/echarts 834684106 ns/iter (± 3803333) 1140796557 ns/iter (± 16739244) 0.73
es/minify/libraries/jquery 68269901 ns/iter (± 95367) 82613258 ns/iter (± 838878) 0.83
es/minify/libraries/lodash 79013564 ns/iter (± 198356) 99033139 ns/iter (± 1181248) 0.80
es/minify/libraries/moment 39922420 ns/iter (± 48107) 47899011 ns/iter (± 292637) 0.83
es/minify/libraries/react 14691820 ns/iter (± 37131) 17713314 ns/iter (± 169285) 0.83
es/minify/libraries/terser 174125595 ns/iter (± 540408) 223784841 ns/iter (± 2854755) 0.78
es/minify/libraries/three 291327871 ns/iter (± 1807553) 391691080 ns/iter (± 4445014) 0.74
es/minify/libraries/typescript 2081917776 ns/iter (± 9380976) 2725231295 ns/iter (± 14319138) 0.76
es/minify/libraries/victory 430598528 ns/iter (± 4264622) 595981462 ns/iter (± 13388505) 0.72
es/minify/libraries/vue 99061084 ns/iter (± 289777) 122366287 ns/iter (± 952611) 0.81
es/visitor/compare/clone 2001018 ns/iter (± 8257) 2330093 ns/iter (± 19829) 0.86
es/visitor/compare/visit_mut_span 2342088 ns/iter (± 6314) 2681840 ns/iter (± 3593) 0.87
es/visitor/compare/visit_mut_span_panic 2389356 ns/iter (± 2427) 2743977 ns/iter (± 2732) 0.87
es/visitor/compare/fold_span 3419771 ns/iter (± 7392) 3820901 ns/iter (± 28343) 0.90
es/visitor/compare/fold_span_panic 3562449 ns/iter (± 20362) 3937634 ns/iter (± 11879) 0.90
es/lexer/colors 11470 ns/iter (± 12) 13078 ns/iter (± 39) 0.88
es/lexer/angular 5777241 ns/iter (± 20903) 6401679 ns/iter (± 2601) 0.90
es/lexer/backbone 750034 ns/iter (± 1324) 793922 ns/iter (± 449) 0.94
es/lexer/jquery 4228694 ns/iter (± 10977) 4447227 ns/iter (± 2391) 0.95
es/lexer/jquery mobile 6451322 ns/iter (± 36532) 6928502 ns/iter (± 9233) 0.93
es/lexer/mootools 3315423 ns/iter (± 2027) 3489566 ns/iter (± 10139) 0.95
es/lexer/underscore 613642 ns/iter (± 3187) 655027 ns/iter (± 687) 0.94
es/lexer/three 19808456 ns/iter (± 39822) 20972148 ns/iter (± 14432) 0.94
es/lexer/yui 3578932 ns/iter (± 40043) 3886090 ns/iter (± 2138) 0.92
es/parser/colors 25747 ns/iter (± 37) 29645 ns/iter (± 208) 0.87
es/parser/angular 13140999 ns/iter (± 58347) 15335954 ns/iter (± 110706) 0.86
es/parser/backbone 1964465 ns/iter (± 10241) 2193281 ns/iter (± 12197) 0.90
es/parser/jquery 10607360 ns/iter (± 44174) 11913412 ns/iter (± 136531) 0.89
es/parser/jquery mobile 16352583 ns/iter (± 85016) 18571282 ns/iter (± 278436) 0.88
es/parser/mootools 8163528 ns/iter (± 21125) 9029575 ns/iter (± 27048) 0.90
es/parser/underscore 1685347 ns/iter (± 11105) 1859905 ns/iter (± 12491) 0.91
es/parser/three 45600005 ns/iter (± 235656) 55844122 ns/iter (± 280705) 0.82
es/parser/yui 8128215 ns/iter (± 41837) 9174488 ns/iter (± 61977) 0.89
es/preset-env/usage/builtin_type 130688 ns/iter (± 33262) 138227 ns/iter (± 34466) 0.95
es/preset-env/usage/property 14944 ns/iter (± 51) 20341 ns/iter (± 77) 0.73
es/resolver/typescript 85891202 ns/iter (± 957170) 120842030 ns/iter (± 2230417) 0.71
es/fixer/typescript 62922363 ns/iter (± 303475) 87677093 ns/iter (± 2325031) 0.72
es/hygiene/typescript 126892547 ns/iter (± 278799) 189733853 ns/iter (± 1699137) 0.67
es/resolver_with_hygiene/typescript 226596232 ns/iter (± 669227) 331196883 ns/iter (± 1505440) 0.68
es/visitor/base-perf/module_clone 58923 ns/iter (± 169) 80381 ns/iter (± 432) 0.73
es/visitor/base-perf/fold_empty 62891 ns/iter (± 301) 90615 ns/iter (± 262) 0.69
es/visitor/base-perf/fold_noop_impl_all 63352 ns/iter (± 275) 91001 ns/iter (± 307) 0.70
es/visitor/base-perf/fold_noop_impl_vec 63456 ns/iter (± 346) 91280 ns/iter (± 374) 0.70
es/visitor/base-perf/boxing_boxed_clone 51 ns/iter (± 0) 56 ns/iter (± 0) 0.91
es/visitor/base-perf/boxing_unboxed_clone 36 ns/iter (± 0) 42 ns/iter (± 0) 0.86
es/visitor/base-perf/boxing_boxed 110 ns/iter (± 0) 103 ns/iter (± 0) 1.07
es/visitor/base-perf/boxing_unboxed 76 ns/iter (± 0) 81 ns/iter (± 0) 0.94
es/visitor/base-perf/visit_empty 0 ns/iter (± 0)
es/visitor/base-perf/visit_contains_this 2580 ns/iter (± 6) 3356 ns/iter (± 88) 0.77
es/base/parallel/resolver/typescript 3918449390 ns/iter (± 311588868) 5996433138 ns/iter (± 367221911) 0.65
es/base/parallel/hygiene/typescript 1421160482 ns/iter (± 18339847) 2207761577 ns/iter (± 14150688) 0.64
misc/visitors/time-complexity/time 5 108 ns/iter (± 0) 103 ns/iter (± 0) 1.05
misc/visitors/time-complexity/time 10 276 ns/iter (± 1) 320 ns/iter (± 2) 0.86
misc/visitors/time-complexity/time 15 758 ns/iter (± 17) 648 ns/iter (± 12) 1.17
misc/visitors/time-complexity/time 20 1089 ns/iter (± 7) 1193 ns/iter (± 0) 0.91
misc/visitors/time-complexity/time 40 4317 ns/iter (± 250) 6164 ns/iter (± 66) 0.70
misc/visitors/time-complexity/time 60 9306 ns/iter (± 5) 15752 ns/iter (± 83) 0.59
es/full-target/es2016 225220 ns/iter (± 575) 254028 ns/iter (± 1454) 0.89
es/full-target/es2017 213865 ns/iter (± 1223) 246882 ns/iter (± 458) 0.87
es/full-target/es2018 201500 ns/iter (± 521) 236204 ns/iter (± 344) 0.85
es2020_nullish_coalescing 68679 ns/iter (± 402) 92882 ns/iter (± 532) 0.74
es2020_optional_chaining 95129 ns/iter (± 507) 123829 ns/iter (± 158) 0.77
es2022_class_properties 116485 ns/iter (± 538) 149125 ns/iter (± 375) 0.78
es2018_object_rest_spread 72146 ns/iter (± 214) 95843 ns/iter (± 185) 0.75
es2019_optional_catch_binding 63788 ns/iter (± 208) 84764 ns/iter (± 190) 0.75
es2017_async_to_generator 64014 ns/iter (± 223) 85427 ns/iter (± 234) 0.75
es2016_exponentiation 67396 ns/iter (± 168) 89837 ns/iter (± 269) 0.75
es2015_arrow 70697 ns/iter (± 248) 93843 ns/iter (± 211) 0.75
es2015_block_scoped_fn 67985 ns/iter (± 252) 91608 ns/iter (± 181) 0.74
es2015_block_scoping 117305 ns/iter (± 418) 169774 ns/iter (± 503) 0.69

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.