fix(es/minifier): Don't inline properties if the var is not fn-local (#7839)

**Related issue:**

 - vercel/next.js#54192.

Author: kdy1

crates/swc/tests/fixture/issues-7xxx/7228/output/input.js

@@ -1,3 +1,4 @@
 function f() {
-    return something.getFoos()?.[0];
+    const foos = something.getFoos();
+    return foos?.[0];
 }

crates/swc/tests/tsc-references/destructuringVariableDeclaration1ES5.2.minified.js

@@ -1,6 +1,11 @@
 //// [destructuringVariableDeclaration1ES5.ts]
 import { _ as _sliced_to_array } from "@swc/helpers/_/_sliced_to_array";
 import { _ as _to_consumable_array } from "@swc/helpers/_/_to_consumable_array";
+var _ref = {
+    a1: 10,
+    a2: "world"
+};
+_ref.a1, _ref.a2;
 var tmp = {
     b11: "world"
 };

crates/swc/tests/tsc-references/destructuringVariableDeclaration1ES5iterable.2.minified.js

@@ -1,6 +1,11 @@
 //// [destructuringVariableDeclaration1ES5iterable.ts]
 import { _ as _sliced_to_array } from "@swc/helpers/_/_sliced_to_array";
 import { _ as _to_consumable_array } from "@swc/helpers/_/_to_consumable_array";
+var _ref = {
+    a1: 10,
+    a2: "world"
+};
+_ref.a1, _ref.a2;
 var tmp = {
     b11: "world"
 };

crates/swc/tests/tsc-references/logicalNotOperatorWithAnyOtherType.2.minified.js

@@ -1,11 +1,14 @@
 //// [logicalNotOperatorWithAnyOtherType.ts]
 import { _ as _class_call_check } from "@swc/helpers/_/_class_call_check";
-var n, M, A = function() {
+var n, M, obj1 = {
+    x: "",
+    y: function() {}
+}, A = function() {
     function A() {
         _class_call_check(this, A);
     }
     return A.foo = function() {}, A;
 }();
 (M || (M = {})).n = n;
 var objA = new A();
-objA.a, M.n, A.foo(), objA.a, M.n;
+obj1.x, obj1.y, objA.a, M.n, A.foo(), objA.a, M.n;

crates/swc/tests/tsc-references/parserNotHexLiteral1.2.minified.js

@@ -1,2 +1,6 @@
 //// [parserNotHexLiteral1.ts]
-console.info("dog"), console.info("cat");
+var x = {
+    e0: "cat",
+    x0: "dog"
+};
+console.info(x.x0), console.info(x.e0);

crates/swc/tests/tsc-references/typeTagOnPropertyAssignment.2.minified.js

@@ -1 +1,8 @@
 //// [typeTagOnPropertyAssignment.js]
+var o = {
+    a: "a",
+    n: function() {
+        return "b";
+    }
+};
+o.a, o.n;

crates/swc/tests/tsc-references/typedefTagNested.2.minified.js

@@ -1 +1,7 @@
 //// [a.js]
+var sala = {
+    name: "uppsala",
+    not: 0,
+    nested: "ok"
+};
+sala.name, sala.not, sala.nested;

crates/swc/tests/tsc-references/unannotatedParametersAreOptional.2.minified.js

@@ -7,3 +7,8 @@ var C = function() {
     return C.prototype.m = function(x) {}, C.m = function(x) {}, C;
 }();
 C.m(), new C().m(), new C().p();
+var obj = {
+    m: function(x) {},
+    p: function(x) {}
+};
+obj.m(), obj.p();

crates/swc/tests/tsc-references/voidOperatorWithAnyOtherType.2.minified.js

@@ -1,11 +1,14 @@
 //// [voidOperatorWithAnyOtherType.ts]
 import { _ as _class_call_check } from "@swc/helpers/_/_class_call_check";
-var n, M, A = function() {
+var n, M, obj1 = {
+    x: "",
+    y: 1
+}, A = function() {
     function A() {
         _class_call_check(this, A);
     }
     return A.foo = function() {}, A;
 }();
 (M || (M = {})).n = n;
 var objA = new A();
-objA.a, M.n, A.foo(), objA.a, M.n;
+obj1.x, obj1.y, objA.a, M.n, A.foo(), objA.a, M.n;

crates/swc_ecma_minifier/src/compress/optimize/props.rs

@@ -34,6 +34,7 @@ impl Optimizer<'_> {
                         && !v.used_as_ref
                         && !v.used_as_arg
                         && !v.used_in_cond
+                        && (!v.is_fn_local || !self.mode.should_be_very_correct())
                         && !v.reassigned()
                         && !v.is_infected()
                 })
@@ -84,6 +85,10 @@ impl Optimizer<'_> {
                         }
                     }
                 }
+            } else {
+                if self.mode.should_be_very_correct() {
+                    return;
+                }
             }
 
             if !unknown_used_props.iter().all(|(_, v)| *v == 0) {

crates/swc_ecma_minifier/src/eval.rs

@@ -66,6 +66,10 @@ impl Mode for Eval {
     fn force_str_for_tpl(&self) -> bool {
         true
     }
+
+    fn should_be_very_correct(&self) -> bool {
+        false
+    }
 }
 
 impl Evaluator {

crates/swc_ecma_minifier/src/mode.rs

@@ -3,6 +3,8 @@ use swc_ecma_ast::*;
 pub(crate) trait Mode: Send + Sync {
     fn store(&self, id: Id, value: &Expr);
 
+    fn should_be_very_correct(&self) -> bool;
+
     /// If this returns true, template literals with `\n` or `\r` will be
     /// converted to [Lit::Str].
     fn force_str_for_tpl(&self) -> bool;
@@ -16,4 +18,8 @@ impl Mode for Minification {
     fn force_str_for_tpl(&self) -> bool {
         false
     }
+
+    fn should_be_very_correct(&self) -> bool {
+        true
+    }
 }

crates/swc_ecma_minifier/tests/benches-full/echarts.js

@@ -7773,8 +7773,8 @@
         }
     }
     function format(time, template, isUTC, lang) {
-        var date = parseDate(time), y = date[fullYearGetterName(isUTC)](), M = date[monthGetterName(isUTC)]() + 1, q = Math.floor((M - 1) / 4) + 1, d = date[dateGetterName(isUTC)](), e = date['get' + (isUTC ? 'UTC' : '') + 'Day'](), H = date[hoursGetterName(isUTC)](), h = (H - 1) % 12 + 1, m = date[minutesGetterName(isUTC)](), s = date[secondsGetterName(isUTC)](), S = date[millisecondsGetterName(isUTC)](), timeModel = (lang instanceof Model ? lang : localeModels[lang || SYSTEM_LANG] || localeModels.EN).getModel('time');
-        return (template || '').replace(/{yyyy}/g, y + '').replace(/{yy}/g, y % 100 + '').replace(/{Q}/g, q + '').replace(/{MMMM}/g, timeModel.get('month')[M - 1]).replace(/{MMM}/g, timeModel.get('monthAbbr')[M - 1]).replace(/{MM}/g, pad(M, 2)).replace(/{M}/g, M + '').replace(/{dd}/g, pad(d, 2)).replace(/{d}/g, d + '').replace(/{eeee}/g, timeModel.get('dayOfWeek')[e]).replace(/{ee}/g, timeModel.get('dayOfWeekAbbr')[e]).replace(/{e}/g, e + '').replace(/{HH}/g, pad(H, 2)).replace(/{H}/g, H + '').replace(/{hh}/g, pad(h + '', 2)).replace(/{h}/g, h + '').replace(/{mm}/g, pad(m, 2)).replace(/{m}/g, m + '').replace(/{ss}/g, pad(s, 2)).replace(/{s}/g, s + '').replace(/{SSS}/g, pad(S, 3)).replace(/{S}/g, S + '');
+        var date = parseDate(time), y = date[fullYearGetterName(isUTC)](), M = date[monthGetterName(isUTC)]() + 1, q = Math.floor((M - 1) / 4) + 1, d = date[dateGetterName(isUTC)](), e = date['get' + (isUTC ? 'UTC' : '') + 'Day'](), H = date[hoursGetterName(isUTC)](), h = (H - 1) % 12 + 1, m = date[minutesGetterName(isUTC)](), s = date[secondsGetterName(isUTC)](), S = date[millisecondsGetterName(isUTC)](), timeModel = (lang instanceof Model ? lang : localeModels[lang || SYSTEM_LANG] || localeModels.EN).getModel('time'), month = timeModel.get('month'), monthAbbr = timeModel.get('monthAbbr'), dayOfWeek = timeModel.get('dayOfWeek'), dayOfWeekAbbr = timeModel.get('dayOfWeekAbbr');
+        return (template || '').replace(/{yyyy}/g, y + '').replace(/{yy}/g, y % 100 + '').replace(/{Q}/g, q + '').replace(/{MMMM}/g, month[M - 1]).replace(/{MMM}/g, monthAbbr[M - 1]).replace(/{MM}/g, pad(M, 2)).replace(/{M}/g, M + '').replace(/{dd}/g, pad(d, 2)).replace(/{d}/g, d + '').replace(/{eeee}/g, dayOfWeek[e]).replace(/{ee}/g, dayOfWeekAbbr[e]).replace(/{e}/g, e + '').replace(/{HH}/g, pad(H, 2)).replace(/{H}/g, H + '').replace(/{hh}/g, pad(h + '', 2)).replace(/{h}/g, h + '').replace(/{mm}/g, pad(m, 2)).replace(/{m}/g, m + '').replace(/{ss}/g, pad(s, 2)).replace(/{s}/g, s + '').replace(/{SSS}/g, pad(S, 3)).replace(/{S}/g, S + '');
     }
     function getUnitFromValue(value, isUTC) {
         var date = parseDate(value), M = date[monthGetterName(isUTC)]() + 1, d = date[dateGetterName(isUTC)](), h = date[hoursGetterName(isUTC)](), m = date[minutesGetterName(isUTC)](), s = date[secondsGetterName(isUTC)](), isSecond = 0 === date[millisecondsGetterName(isUTC)](), isMinute = isSecond && 0 === s, isHour = isMinute && 0 === m, isDay = isHour && 0 === h, isMonth = isDay && 1 === d;
@@ -14490,7 +14490,7 @@
         }, List.prototype.downSample = function(dimension, rate, sampleValue, sampleIndex) {
             for(var list = cloneListForMapAndSample(this, [
                 dimension
-            ]), frameValues = [], frameSize = mathFloor(1 / rate), dimStore = list._storage[dimension], len = this.count(), rawExtentOnDim = list._rawExtent[dimension], newIndices = new (getIndicesCtor(this))(len), offset = 0, i = 0; i < len; i += frameSize){
+            ]), targetStorage = list._storage, frameValues = [], frameSize = mathFloor(1 / rate), dimStore = targetStorage[dimension], len = this.count(), rawExtentOnDim = list._rawExtent[dimension], newIndices = new (getIndicesCtor(this))(len), offset = 0, i = 0; i < len; i += frameSize){
                 frameSize > len - i && (frameSize = len - i, frameValues.length = frameSize);
                 for(var k = 0; k < frameSize; k++){
                     var dataIdx = this.getRawIndex(i + k);
@@ -25061,7 +25061,7 @@
                 getAutoCurvenessParams(this) && (this.__curvenessList = [], this.__edgeMap = {}, createCurveness(this));
                 var graph = createGraphFromNodeEdge(nodes, edges, this, !0, function(nodeData, edgeData) {
                     nodeData.wrapMethod('getItemModel', function(model) {
-                        var categoryIdx = model.getShallow('category'), categoryModel = self1._categoriesModels[categoryIdx];
+                        var categoryModel = self1._categoriesModels[model.getShallow('category')];
                         return categoryModel && (categoryModel.parentModel = model.parentModel, model.parentModel = categoryModel), model;
                     });
                     var oldGetModel = Model.prototype.getModel;
@@ -29234,7 +29234,7 @@
         }), path;
     }
     function createOrUpdateRepeatSymbols(bar, opt, symbolMeta, isUpdate) {
-        var bundle = bar.__pictorialBundle, valueLineWidth = symbolMeta.valueLineWidth, pathPosition = symbolMeta.pathPosition, valueDim = opt.valueDim, repeatTimes = symbolMeta.repeatTimes || 0, index = 0, unit = symbolMeta.symbolSize[opt.valueDim.index] + valueLineWidth + 2 * symbolMeta.symbolMargin;
+        var bundle = bar.__pictorialBundle, symbolSize = symbolMeta.symbolSize, valueLineWidth = symbolMeta.valueLineWidth, pathPosition = symbolMeta.pathPosition, valueDim = opt.valueDim, repeatTimes = symbolMeta.repeatTimes || 0, index = 0, unit = symbolSize[opt.valueDim.index] + valueLineWidth + 2 * symbolMeta.symbolMargin;
         for(eachPath(bar, function(path) {
             path.__pictorialAnimationIndex = index, path.__pictorialRepeatTimes = repeatTimes, index < repeatTimes ? updateAttr(path, null, makeTarget(index), symbolMeta, isUpdate) : updateAttr(path, null, {
                 scaleX: 0,
@@ -29440,11 +29440,11 @@
             return _this.type = ThemeRiverView.type, _this._layers = [], _this;
         }
         return __extends(ThemeRiverView, _super), ThemeRiverView.prototype.render = function(seriesModel, ecModel, api) {
-            var data = seriesModel.getData(), self1 = this, group = this.group, layersSeries = seriesModel.getLayerSeries(), layoutInfo = data.getLayout('layoutInfo'), rect = layoutInfo.rect;
+            var data = seriesModel.getData(), self1 = this, group = this.group, layersSeries = seriesModel.getLayerSeries(), layoutInfo = data.getLayout('layoutInfo'), rect = layoutInfo.rect, boundaryGap = layoutInfo.boundaryGap;
             function keyGetter(item) {
                 return item.name;
             }
-            group.x = 0, group.y = rect.y + layoutInfo.boundaryGap[0];
+            group.x = 0, group.y = rect.y + boundaryGap[0];
             var dataDiffer = new DataDiffer(this._layersSeries || [], layersSeries, keyGetter, keyGetter), newLayersGroups = [];
             function process(status, idx, oldIdx) {
                 var style, polygon, oldLayersGroups = self1._layers;
@@ -38876,6 +38876,9 @@
                     var otherShadowExtent = [
                         0,
                         size[1]
+                    ], thisShadowExtent = [
+                        0,
+                        size[0]
                     ], areaPoints = [
                         [
                             size[0],
@@ -38885,7 +38888,7 @@
                             0,
                             0
                         ]
-                    ], linePoints = [], step = size[0] / (data.count() - 1), thisCoord = 0, stride = Math.round(data.count() / size[0]);
+                    ], linePoints = [], step = thisShadowExtent[1] / (data.count() - 1), thisCoord = 0, stride = Math.round(data.count() / size[0]);
                     data.each([
                         otherDim
                     ], function(value, index) {
@@ -40049,11 +40052,11 @@
             var zr = this.api.getZr();
             this.visualMapModel.option.hoverLink ? (zr.on('mouseover', this._hoverLinkFromSeriesMouseOver, this), zr.on('mouseout', this._hideIndicator, this)) : this._clearHoverLinkFromSeries();
         }, ContinuousView.prototype._doHoverLinkToSeries = function(cursorPos, hoverOnBar) {
-            var visualMapModel = this.visualMapModel;
+            var visualMapModel = this.visualMapModel, itemSize = visualMapModel.itemSize;
             if (visualMapModel.option.hoverLink) {
                 var halfHoverLinkSize, hoverLinkDataSize, sizeExtent = [
                     0,
-                    visualMapModel.itemSize[1]
+                    itemSize[1]
                 ], dataExtent = visualMapModel.getExtent();
                 cursorPos = mathMin$a(mathMax$a(sizeExtent[0], cursorPos), sizeExtent[1]);
                 var halfHoverLinkSize1 = (halfHoverLinkSize = 6, (hoverLinkDataSize = visualMapModel.get('hoverLinkDataSize')) && (halfHoverLinkSize = linearMap(hoverLinkDataSize, dataExtent, sizeExtent, !0) / 2), halfHoverLinkSize), hoverRange = [

crates/swc_ecma_minifier/tests/benches-full/lodash.js

@@ -1329,8 +1329,8 @@
         }
         function createCaseFirst(methodName) {
             return function(string) {
-                var strSymbols = hasUnicode(string = toString(string)) ? stringToArray(string) : undefined, trailing = strSymbols ? castSlice(strSymbols, 1).join('') : string.slice(1);
-                return (strSymbols ? strSymbols[0] : string.charAt(0))[methodName]() + trailing;
+                var strSymbols = hasUnicode(string = toString(string)) ? stringToArray(string) : undefined, chr = strSymbols ? strSymbols[0] : string.charAt(0), trailing = strSymbols ? castSlice(strSymbols, 1).join('') : string.slice(1);
+                return chr[methodName]() + trailing;
             };
         }
         function createCompounder(callback) {

crates/swc_ecma_minifier/tests/benches-full/three.js

@@ -13073,8 +13073,8 @@
             lastInactiveAction._cacheIndex = cacheIndex, actions[cacheIndex] = lastInactiveAction, actions.pop(), action._cacheIndex = null;
             var clipUuid = action._clip.uuid, actionsByClip = this._actionsByClip, actionsForClip = actionsByClip[clipUuid], knownActionsForClip = actionsForClip.knownActions, lastKnownAction = knownActionsForClip[knownActionsForClip.length - 1], byClipCacheIndex = action._byClipCacheIndex;
             lastKnownAction._byClipCacheIndex = byClipCacheIndex, knownActionsForClip[byClipCacheIndex] = lastKnownAction, knownActionsForClip.pop(), action._byClipCacheIndex = null;
-            var rootUuid = (action._localRoot || this._root).uuid;
-            delete actionsForClip.actionByRoot[rootUuid], 0 === knownActionsForClip.length && delete actionsByClip[clipUuid], this._removeInactiveBindingsForAction(action);
+            var actionByRoot = actionsForClip.actionByRoot, rootUuid = (action._localRoot || this._root).uuid;
+            delete actionByRoot[rootUuid], 0 === knownActionsForClip.length && delete actionsByClip[clipUuid], this._removeInactiveBindingsForAction(action);
         },
         _removeInactiveBindingsForAction: function(action) {
             for(var bindings = action._propertyBindings, i = 0, n = bindings.length; i !== n; ++i){

crates/swc_ecma_minifier/tests/benches-full/victory.js

@@ -6864,7 +6864,7 @@
                     for(var _i = 0, _n2 = hull.length; _i < _n2; ++_i)hullIndex[hull[_i]] = _i;
                     hull.length <= 2 && hull.length > 0 && (this.triangles = new Int32Array(3).fill(-1), this.halfedges = new Int32Array(3).fill(-1), this.triangles[0] = hull[0], this.triangles[1] = hull[1], this.triangles[2] = hull[1], inedges[hull[0]] = 1, 2 === hull.length && (inedges[hull[1]] = 0));
                 }, _proto.neighbors = function(i) {
-                    var results = [], hull = this.hull, _hullIndex = this._hullIndex, halfedges = this.halfedges, triangles = this.triangles, e0 = this.inedges[i];
+                    var results = [], inedges = this.inedges, hull = this.hull, _hullIndex = this._hullIndex, halfedges = this.halfedges, triangles = this.triangles, e0 = inedges[i];
                     if (-1 === e0) return results;
                     var e = e0, p0 = -1;
                     do {
@@ -6881,8 +6881,8 @@
                     for(var c, i0 = i; (c = this._step(i, x, y)) >= 0 && c !== i && c !== i0;)i = c;
                     return c;
                 }, _proto._step = function(i, x, y) {
-                    var points = this.points;
-                    if (-1 === this.inedges[i] || !points.length) return (i + 1) % (points.length >> 1);
+                    var inedges = this.inedges, points = this.points;
+                    if (-1 === inedges[i] || !points.length) return (i + 1) % (points.length >> 1);
                     for(var c = i, dc = Math.pow(x - points[2 * i], 2) + Math.pow(y - points[2 * i + 1], 2), _iterator = this.neighbors(i), _isArray = Array.isArray(_iterator), _i2 = 0, _iterator = _isArray ? _iterator : _iterator[Symbol.iterator]();;){
                         if (_isArray) {
                             if (_i2 >= _iterator.length) break;

crates/swc_ecma_minifier/tests/fixture/issues/7228/1/output.js

@@ -1,3 +1,4 @@
 export function f() {
-    return something.getFoos()?.[0];
+    const foos = something.getFoos();
+    return foos?.[0];
 }

crates/swc_ecma_minifier/tests/fixture/issues/7839/1/input.js

@@ -0,0 +1,5 @@
+export function createCaseFirst(g, methodName) {
+    var chr = g.get(0)
+    console.log(123)
+    return chr[methodName]() + trailing;
+}

crates/swc_ecma_minifier/tests/fixture/issues/7839/1/output.js

@@ -0,0 +1,4 @@
+export function createCaseFirst(g, methodName) {
+    var chr = g.get(0);
+    return console.log(123), chr[methodName]() + trailing;
+}