Skip to content

Commit

Permalink
fix(css/ast): Make .hash() of Token not recursive (#8151)
Browse files Browse the repository at this point in the history
  • Loading branch information
stormslowly committed Oct 19, 2023
1 parent 5dacaa1 commit 8d7894c
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions crates/swc_css_ast/src/token.rs
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,7 @@ impl Hash for Token {
| Token::LParen
| Token::RParen
| Token::LBrace
| Token::RBrace => {
self.hash(state);
}
| Token::RBrace => {}
}
}
}
Expand Down

1 comment on commit 8d7894c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 8d7894c Previous: e186b80 Ratio
es/full/bugs-1 288688 ns/iter (± 5595) 282550 ns/iter (± 7717) 1.02
es/full/minify/libraries/antd 1383350684 ns/iter (± 11788999) 1384373816 ns/iter (± 19517629) 1.00
es/full/minify/libraries/d3 296319155 ns/iter (± 2253807) 291684503 ns/iter (± 2637807) 1.02
es/full/minify/libraries/echarts 1109579854 ns/iter (± 4405740) 1107930076 ns/iter (± 6037957) 1.00
es/full/minify/libraries/jquery 88987302 ns/iter (± 168124) 88911549 ns/iter (± 918564) 1.00
es/full/minify/libraries/lodash 104271650 ns/iter (± 479429) 103603119 ns/iter (± 315351) 1.01
es/full/minify/libraries/moment 52421190 ns/iter (± 99243) 52161073 ns/iter (± 76455) 1.00
es/full/minify/libraries/react 18862789 ns/iter (± 70621) 18828503 ns/iter (± 52955) 1.00
es/full/minify/libraries/terser 229662182 ns/iter (± 736719) 229079800 ns/iter (± 1565967) 1.00
es/full/minify/libraries/three 407653860 ns/iter (± 2586256) 411031599 ns/iter (± 2178496) 0.99
es/full/minify/libraries/typescript 2779689950 ns/iter (± 9224924) 2792299928 ns/iter (± 7248821) 1.00
es/full/minify/libraries/victory 594793169 ns/iter (± 2543440) 594477849 ns/iter (± 5600441) 1.00
es/full/minify/libraries/vue 125814658 ns/iter (± 204118) 125406477 ns/iter (± 533624) 1.00
es/full/codegen/es3 34569 ns/iter (± 56) 33266 ns/iter (± 83) 1.04
es/full/codegen/es5 34621 ns/iter (± 165) 33251 ns/iter (± 121) 1.04
es/full/codegen/es2015 34559 ns/iter (± 95) 33262 ns/iter (± 101) 1.04
es/full/codegen/es2016 34608 ns/iter (± 147) 33201 ns/iter (± 64) 1.04
es/full/codegen/es2017 34592 ns/iter (± 151) 33225 ns/iter (± 179) 1.04
es/full/codegen/es2018 34644 ns/iter (± 90) 33169 ns/iter (± 76) 1.04
es/full/codegen/es2019 34592 ns/iter (± 201) 33254 ns/iter (± 66) 1.04
es/full/codegen/es2020 34597 ns/iter (± 108) 33198 ns/iter (± 70) 1.04
es/full/all/es3 176204224 ns/iter (± 709095) 177186202 ns/iter (± 1240760) 0.99
es/full/all/es5 168609182 ns/iter (± 473897) 170003284 ns/iter (± 774839) 0.99
es/full/all/es2015 127574293 ns/iter (± 613526) 130917469 ns/iter (± 5958145) 0.97
es/full/all/es2016 126459668 ns/iter (± 1749259) 127629620 ns/iter (± 917737) 0.99
es/full/all/es2017 125908328 ns/iter (± 795191) 127703572 ns/iter (± 1340654) 0.99
es/full/all/es2018 123950332 ns/iter (± 1267294) 125494822 ns/iter (± 345831) 0.99
es/full/all/es2019 122742495 ns/iter (± 511746) 125101983 ns/iter (± 1004671) 0.98
es/full/all/es2020 119476634 ns/iter (± 426357) 120896160 ns/iter (± 377928) 0.99
es/full/parser 559583 ns/iter (± 3375) 562199 ns/iter (± 4451) 1.00
es/full/base/fixer 18925 ns/iter (± 90) 17652 ns/iter (± 44) 1.07
es/full/base/resolver_and_hygiene 83590 ns/iter (± 136) 85003 ns/iter (± 571) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.